Mailing List Archive: Separate Solr build: help with the remaining last mile needed.

Separate Solr build: help with the remaining last mile needed.

Mar 4, 2021, 12:25 AM

Post #1 of 12 (888 views)

Hi folks,

I'll need some help with some remaining tasks to make the transition
easier after the solr repo split. I've made some changes to allow
building just Solr or just Lucene on master --

https://github.com/apache/lucene-solr/pull/2448

1. I really don't know much about docker testing and why it fails on that PR.

2. Lucene build seems to work just fine.

3. You can build Solr independently (with a Lucene snapshot from
Apache repository) by running:

./gradlew -Dskip.lucene=true assemble check -x test -x documentation
-x checkBrokenLinks -x checkLocalJavadocLinksSite

the "-x" tasks are what I'll need some help with - I guess they do
have cross-references to Lucene-generated stuff that needs to be
replaced (or dropped).

4. There are three tests that need to be removed from the codebase,
moved to Lucene or rewritten: TestICUCollationField,
TestLuceneIndexBackCompat and TestXmlQParser. These tests require
access to Lucene test sources and these won't be published as an
artifact.

An alternative to trying to solve the above is to just split the repo
and let it burn/ crash, but I thought by fixing those issues on
current master branch we can prepare the infrastructure while
everything else just works.

Dawid

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Re: Separate Solr build: help with the remaining last mile needed. [ In reply to ]

houstonputman at gmail

Mar 4, 2021, 9:48 AM

Post #2 of 12 (887 views)

Permalink

I'm not sure why the docker github action is failing... I've tried it
locally and it works fine. I'll do some more investigation.

On Thu, Mar 4, 2021 at 3:25 AM Dawid Weiss <dawid.weiss@gmail.com> wrote:

> Hi folks,
>
> I'll need some help with some remaining tasks to make the transition
> easier after the solr repo split. I've made some changes to allow
> building just Solr or just Lucene on master --
>
> https://github.com/apache/lucene-solr/pull/2448
>
> 1. I really don't know much about docker testing and why it fails on that
> PR.
>
> 2. Lucene build seems to work just fine.
>
> 3. You can build Solr independently (with a Lucene snapshot from
> Apache repository) by running:
>
> ./gradlew -Dskip.lucene=true assemble check -x test -x documentation
> -x checkBrokenLinks -x checkLocalJavadocLinksSite
>
> the "-x" tasks are what I'll need some help with - I guess they do
> have cross-references to Lucene-generated stuff that needs to be
> replaced (or dropped).
>
> 4. There are three tests that need to be removed from the codebase,
> moved to Lucene or rewritten: TestICUCollationField,
> TestLuceneIndexBackCompat and TestXmlQParser. These tests require
> access to Lucene test sources and these won't be published as an
> artifact.
>
> An alternative to trying to solve the above is to just split the repo
> and let it burn/ crash, but I thought by fixing those issues on
> current master branch we can prepare the infrastructure while
> everything else just works.
>
> Dawid
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>

Re: Separate Solr build: help with the remaining last mile needed. [ In reply to ]

dawid.weiss at gmail

Mar 4, 2021, 10:38 AM

Post #3 of 12 (887 views)

Permalink

Thanks Houston. Is this failure on the branch only (does it work on master)?

Dawid

On Thu, Mar 4, 2021 at 6:48 PM Houston Putman <houstonputman@gmail.com> wrote:
>
> I'm not sure why the docker github action is failing... I've tried it locally and it works fine. I'll do some more investigation.
>
> On Thu, Mar 4, 2021 at 3:25 AM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>>
>> Hi folks,
>>
>> I'll need some help with some remaining tasks to make the transition
>> easier after the solr repo split. I've made some changes to allow
>> building just Solr or just Lucene on master --
>>
>> https://github.com/apache/lucene-solr/pull/2448
>>
>> 1. I really don't know much about docker testing and why it fails on that PR.
>>
>> 2. Lucene build seems to work just fine.
>>
>> 3. You can build Solr independently (with a Lucene snapshot from
>> Apache repository) by running:
>>
>> ./gradlew -Dskip.lucene=true assemble check -x test -x documentation
>> -x checkBrokenLinks -x checkLocalJavadocLinksSite
>>
>> the "-x" tasks are what I'll need some help with - I guess they do
>> have cross-references to Lucene-generated stuff that needs to be
>> replaced (or dropped).
>>
>> 4. There are three tests that need to be removed from the codebase,
>> moved to Lucene or rewritten: TestICUCollationField,
>> TestLuceneIndexBackCompat and TestXmlQParser. These tests require
>> access to Lucene test sources and these won't be published as an
>> artifact.
>>
>> An alternative to trying to solve the above is to just split the repo
>> and let it burn/ crash, but I thought by fixing those issues on
>> current master branch we can prepare the infrastructure while
>> everything else just works.
>>
>> Dawid
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Re: Separate Solr build: help with the remaining last mile needed. [ In reply to ]

houstonputman at gmail

Mar 4, 2021, 10:44 AM

Post #4 of 12 (887 views)

Permalink

It worked as of 10 days ago:
https://github.com/apache/lucene-solr/actions/workflows/docker-test.yml

I created a test PR to see if it works based on master:
https://github.com/apache/lucene-solr/pull/2454

On Thu, Mar 4, 2021 at 1:39 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:

> Thanks Houston. Is this failure on the branch only (does it work on
> master)?
>
> Dawid
>
> On Thu, Mar 4, 2021 at 6:48 PM Houston Putman <houstonputman@gmail.com>
> wrote:
> >
> > I'm not sure why the docker github action is failing... I've tried it
> locally and it works fine. I'll do some more investigation.
> >
> > On Thu, Mar 4, 2021 at 3:25 AM Dawid Weiss <dawid.weiss@gmail.com>
> wrote:
> >>
> >> Hi folks,
> >>
> >> I'll need some help with some remaining tasks to make the transition
> >> easier after the solr repo split. I've made some changes to allow
> >> building just Solr or just Lucene on master --
> >>
> >> https://github.com/apache/lucene-solr/pull/2448
> >>
> >> 1. I really don't know much about docker testing and why it fails on
> that PR.
> >>
> >> 2. Lucene build seems to work just fine.
> >>
> >> 3. You can build Solr independently (with a Lucene snapshot from
> >> Apache repository) by running:
> >>
> >> ./gradlew -Dskip.lucene=true assemble check -x test -x documentation
> >> -x checkBrokenLinks -x checkLocalJavadocLinksSite
> >>
> >> the "-x" tasks are what I'll need some help with - I guess they do
> >> have cross-references to Lucene-generated stuff that needs to be
> >> replaced (or dropped).
> >>
> >> 4. There are three tests that need to be removed from the codebase,
> >> moved to Lucene or rewritten: TestICUCollationField,
> >> TestLuceneIndexBackCompat and TestXmlQParser. These tests require
> >> access to Lucene test sources and these won't be published as an
> >> artifact.
> >>
> >> An alternative to trying to solve the above is to just split the repo
> >> and let it burn/ crash, but I thought by fixing those issues on
> >> current master branch we can prepare the infrastructure while
> >> everything else just works.
> >>
> >> Dawid
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >> For additional commands, e-mail: dev-help@lucene.apache.org
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>

Re: Separate Solr build: help with the remaining last mile needed. [ In reply to ]

dawid.weiss at gmail

Mar 4, 2021, 10:48 AM

Post #5 of 12 (887 views)

Permalink

Thanks. I might have broken something... but it seems unlikely. I
merely shuffled some things around - it should be an identical build.

D.

On Thu, Mar 4, 2021 at 7:45 PM Houston Putman <houstonputman@gmail.com> wrote:
>
> It worked as of 10 days ago: https://github.com/apache/lucene-solr/actions/workflows/docker-test.yml
>
> I created a test PR to see if it works based on master: https://github.com/apache/lucene-solr/pull/2454
>
> On Thu, Mar 4, 2021 at 1:39 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>>
>> Thanks Houston. Is this failure on the branch only (does it work on master)?
>>
>> Dawid
>>
>> On Thu, Mar 4, 2021 at 6:48 PM Houston Putman <houstonputman@gmail.com> wrote:
>> >
>> > I'm not sure why the docker github action is failing... I've tried it locally and it works fine. I'll do some more investigation.
>> >
>> > On Thu, Mar 4, 2021 at 3:25 AM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>> >>
>> >> Hi folks,
>> >>
>> >> I'll need some help with some remaining tasks to make the transition
>> >> easier after the solr repo split. I've made some changes to allow
>> >> building just Solr or just Lucene on master --
>> >>
>> >> https://github.com/apache/lucene-solr/pull/2448
>> >>
>> >> 1. I really don't know much about docker testing and why it fails on that PR.
>> >>
>> >> 2. Lucene build seems to work just fine.
>> >>
>> >> 3. You can build Solr independently (with a Lucene snapshot from
>> >> Apache repository) by running:
>> >>
>> >> ./gradlew -Dskip.lucene=true assemble check -x test -x documentation
>> >> -x checkBrokenLinks -x checkLocalJavadocLinksSite
>> >>
>> >> the "-x" tasks are what I'll need some help with - I guess they do
>> >> have cross-references to Lucene-generated stuff that needs to be
>> >> replaced (or dropped).
>> >>
>> >> 4. There are three tests that need to be removed from the codebase,
>> >> moved to Lucene or rewritten: TestICUCollationField,
>> >> TestLuceneIndexBackCompat and TestXmlQParser. These tests require
>> >> access to Lucene test sources and these won't be published as an
>> >> artifact.
>> >>
>> >> An alternative to trying to solve the above is to just split the repo
>> >> and let it burn/ crash, but I thought by fixing those issues on
>> >> current master branch we can prepare the infrastructure while
>> >> everything else just works.
>> >>
>> >> Dawid
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> >> For additional commands, e-mail: dev-help@lucene.apache.org
>> >>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Re: Separate Solr build: help with the remaining last mile needed. [ In reply to ]

houstonputman at gmail

Mar 4, 2021, 10:54 AM

Post #6 of 12 (887 views)

Permalink

Aha it's broken independently of your PR. I'll try to fix it, sorry for the
noise.

- Houston

On Thu, Mar 4, 2021 at 1:48 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:

> Thanks. I might have broken something... but it seems unlikely. I
> merely shuffled some things around - it should be an identical build.
>
> D.
>
> On Thu, Mar 4, 2021 at 7:45 PM Houston Putman <houstonputman@gmail.com>
> wrote:
> >
> > It worked as of 10 days ago:
> https://github.com/apache/lucene-solr/actions/workflows/docker-test.yml
> >
> > I created a test PR to see if it works based on master:
> https://github.com/apache/lucene-solr/pull/2454
> >
> > On Thu, Mar 4, 2021 at 1:39 PM Dawid Weiss <dawid.weiss@gmail.com>
> wrote:
> >>
> >> Thanks Houston. Is this failure on the branch only (does it work on
> master)?
> >>
> >> Dawid
> >>
> >> On Thu, Mar 4, 2021 at 6:48 PM Houston Putman <houstonputman@gmail.com>
> wrote:
> >> >
> >> > I'm not sure why the docker github action is failing... I've tried it
> locally and it works fine. I'll do some more investigation.
> >> >
> >> > On Thu, Mar 4, 2021 at 3:25 AM Dawid Weiss <dawid.weiss@gmail.com>
> wrote:
> >> >>
> >> >> Hi folks,
> >> >>
> >> >> I'll need some help with some remaining tasks to make the transition
> >> >> easier after the solr repo split. I've made some changes to allow
> >> >> building just Solr or just Lucene on master --
> >> >>
> >> >> https://github.com/apache/lucene-solr/pull/2448
> >> >>
> >> >> 1. I really don't know much about docker testing and why it fails on
> that PR.
> >> >>
> >> >> 2. Lucene build seems to work just fine.
> >> >>
> >> >> 3. You can build Solr independently (with a Lucene snapshot from
> >> >> Apache repository) by running:
> >> >>
> >> >> ./gradlew -Dskip.lucene=true assemble check -x test -x documentation
> >> >> -x checkBrokenLinks -x checkLocalJavadocLinksSite
> >> >>
> >> >> the "-x" tasks are what I'll need some help with - I guess they do
> >> >> have cross-references to Lucene-generated stuff that needs to be
> >> >> replaced (or dropped).
> >> >>
> >> >> 4. There are three tests that need to be removed from the codebase,
> >> >> moved to Lucene or rewritten: TestICUCollationField,
> >> >> TestLuceneIndexBackCompat and TestXmlQParser. These tests require
> >> >> access to Lucene test sources and these won't be published as an
> >> >> artifact.
> >> >>
> >> >> An alternative to trying to solve the above is to just split the repo
> >> >> and let it burn/ crash, but I thought by fixing those issues on
> >> >> current master branch we can prepare the infrastructure while
> >> >> everything else just works.
> >> >>
> >> >> Dawid
> >> >>
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >> >> For additional commands, e-mail: dev-help@lucene.apache.org
> >> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >> For additional commands, e-mail: dev-help@lucene.apache.org
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>

Re: Separate Solr build: help with the remaining last mile needed. [ In reply to ]

dawid.weiss at gmail

Mar 4, 2021, 11:36 AM

Post #7 of 12 (887 views)

Permalink

Thanks, Houston!

On Thu, Mar 4, 2021 at 7:54 PM Houston Putman <houstonputman@gmail.com> wrote:
>
> Aha it's broken independently of your PR. I'll try to fix it, sorry for the noise.
>
> - Houston
>
> On Thu, Mar 4, 2021 at 1:48 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>>
>> Thanks. I might have broken something... but it seems unlikely. I
>> merely shuffled some things around - it should be an identical build.
>>
>> D.
>>
>> On Thu, Mar 4, 2021 at 7:45 PM Houston Putman <houstonputman@gmail.com> wrote:
>> >
>> > It worked as of 10 days ago: https://github.com/apache/lucene-solr/actions/workflows/docker-test.yml
>> >
>> > I created a test PR to see if it works based on master: https://github.com/apache/lucene-solr/pull/2454
>> >
>> > On Thu, Mar 4, 2021 at 1:39 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>> >>
>> >> Thanks Houston. Is this failure on the branch only (does it work on master)?
>> >>
>> >> Dawid
>> >>
>> >> On Thu, Mar 4, 2021 at 6:48 PM Houston Putman <houstonputman@gmail.com> wrote:
>> >> >
>> >> > I'm not sure why the docker github action is failing... I've tried it locally and it works fine. I'll do some more investigation.
>> >> >
>> >> > On Thu, Mar 4, 2021 at 3:25 AM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>> >> >>
>> >> >> Hi folks,
>> >> >>
>> >> >> I'll need some help with some remaining tasks to make the transition
>> >> >> easier after the solr repo split. I've made some changes to allow
>> >> >> building just Solr or just Lucene on master --
>> >> >>
>> >> >> https://github.com/apache/lucene-solr/pull/2448
>> >> >>
>> >> >> 1. I really don't know much about docker testing and why it fails on that PR.
>> >> >>
>> >> >> 2. Lucene build seems to work just fine.
>> >> >>
>> >> >> 3. You can build Solr independently (with a Lucene snapshot from
>> >> >> Apache repository) by running:
>> >> >>
>> >> >> ./gradlew -Dskip.lucene=true assemble check -x test -x documentation
>> >> >> -x checkBrokenLinks -x checkLocalJavadocLinksSite
>> >> >>
>> >> >> the "-x" tasks are what I'll need some help with - I guess they do
>> >> >> have cross-references to Lucene-generated stuff that needs to be
>> >> >> replaced (or dropped).
>> >> >>
>> >> >> 4. There are three tests that need to be removed from the codebase,
>> >> >> moved to Lucene or rewritten: TestICUCollationField,
>> >> >> TestLuceneIndexBackCompat and TestXmlQParser. These tests require
>> >> >> access to Lucene test sources and these won't be published as an
>> >> >> artifact.
>> >> >>
>> >> >> An alternative to trying to solve the above is to just split the repo
>> >> >> and let it burn/ crash, but I thought by fixing those issues on
>> >> >> current master branch we can prepare the infrastructure while
>> >> >> everything else just works.
>> >> >>
>> >> >> Dawid
>> >> >>
>> >> >> ---------------------------------------------------------------------
>> >> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> >> >> For additional commands, e-mail: dev-help@lucene.apache.org
>> >> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> >> For additional commands, e-mail: dev-help@lucene.apache.org
>> >>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Re: Separate Solr build: help with the remaining last mile needed. [ In reply to ]

dawid.weiss at gmail

Mar 4, 2021, 11:56 PM

Post #8 of 12 (887 views)

Permalink

> ./gradlew -Dskip.lucene=true assemble check -x test -x documentation
> -x checkBrokenLinks -x checkLocalJavadocLinksSite

I made Solr documentation compile last night. Some of the generated
links point at void (and thus the broken links checker fails) but I
think it's enough to make the repository split and then clean up
what's needed in each corresponding repository.

So... this Sunday? Prior to that, we'd have to disable CI build
services currently pointing at the master branch so that they don't
start failing (I'll remove all content from master).

Dawid

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Re: Separate Solr build: help with the remaining last mile needed. [ In reply to ]

mdrob at mdrob

Mar 5, 2021, 11:11 AM

Post #9 of 12 (887 views)

Permalink

I think I can make TestICUCollationField work without depending on Lucene
test sources. The other two will be a bit trickier.

On Fri, Mar 5, 2021 at 1:56 AM Dawid Weiss <dawid.weiss@gmail.com> wrote:

> > ./gradlew -Dskip.lucene=true assemble check -x test -x documentation
> > -x checkBrokenLinks -x checkLocalJavadocLinksSite
>
> I made Solr documentation compile last night. Some of the generated
> links point at void (and thus the broken links checker fails) but I
> think it's enough to make the repository split and then clean up
> what's needed in each corresponding repository.
>
> So... this Sunday? Prior to that, we'd have to disable CI build
> services currently pointing at the master branch so that they don't
> start failing (I'll remove all content from master).
>
> Dawid
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>

Re: Separate Solr build: help with the remaining last mile needed. [ In reply to ]

dawid.weiss at gmail

Mar 5, 2021, 11:43 AM

Post #10 of 12 (887 views)

Permalink

This can be done later too, it's not crucial - these files will be
just ignored for compilation immediately after the split.

D.

On Fri, Mar 5, 2021 at 8:11 PM Mike Drob <mdrob@mdrob.com> wrote:
>
> I think I can make TestICUCollationField work without depending on Lucene test sources. The other two will be a bit trickier.
>
> On Fri, Mar 5, 2021 at 1:56 AM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>>
>> > ./gradlew -Dskip.lucene=true assemble check -x test -x documentation
>> > -x checkBrokenLinks -x checkLocalJavadocLinksSite
>>
>> I made Solr documentation compile last night. Some of the generated
>> links point at void (and thus the broken links checker fails) but I
>> think it's enough to make the repository split and then clean up
>> what's needed in each corresponding repository.
>>
>> So... this Sunday? Prior to that, we'd have to disable CI build
>> services currently pointing at the master branch so that they don't
>> start failing (I'll remove all content from master).
>>
>> Dawid
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

Re: Separate Solr build: help with the remaining last mile needed. [ In reply to ]

mdrob at mdrob

Mar 5, 2021, 12:20 PM

Post #11 of 12 (887 views)

Permalink

I created a PR for the tests https://github.com/apache/lucene-solr/pull/2462

On Fri, Mar 5, 2021 at 1:43 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:

> This can be done later too, it's not crucial - these files will be
> just ignored for compilation immediately after the split.
>
> D.
>
> On Fri, Mar 5, 2021 at 8:11 PM Mike Drob <mdrob@mdrob.com> wrote:
> >
> > I think I can make TestICUCollationField work without depending on
> Lucene test sources. The other two will be a bit trickier.
> >
> > On Fri, Mar 5, 2021 at 1:56 AM Dawid Weiss <dawid.weiss@gmail.com>
> wrote:
> >>
> >> > ./gradlew -Dskip.lucene=true assemble check -x test -x documentation
> >> > -x checkBrokenLinks -x checkLocalJavadocLinksSite
> >>
> >> I made Solr documentation compile last night. Some of the generated
> >> links point at void (and thus the broken links checker fails) but I
> >> think it's enough to make the repository split and then clean up
> >> what's needed in each corresponding repository.
> >>
> >> So... this Sunday? Prior to that, we'd have to disable CI build
> >> services currently pointing at the master branch so that they don't
> >> start failing (I'll remove all content from master).
> >>
> >> Dawid
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >> For additional commands, e-mail: dev-help@lucene.apache.org
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>

Re: Separate Solr build: help with the remaining last mile needed. [ In reply to ]

houstonputman at gmail

Mar 5, 2021, 2:54 PM

Post #12 of 12 (887 views)

Permalink

For posterity, the docker build broke because github changed the version of
ubuntu_latest in github actions from 18.04 to 20.04.

The ACL package is installed by default in Ubuntu 18, but not Ubuntu 20.
Installing it at the beginning of the docker action fixes the build.

On Fri, Mar 5, 2021 at 3:21 PM Mike Drob <mdrob@mdrob.com> wrote:

> I created a PR for the tests
> https://github.com/apache/lucene-solr/pull/2462
>
> On Fri, Mar 5, 2021 at 1:43 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>
>> This can be done later too, it's not crucial - these files will be
>> just ignored for compilation immediately after the split.
>>
>> D.
>>
>> On Fri, Mar 5, 2021 at 8:11 PM Mike Drob <mdrob@mdrob.com> wrote:
>> >
>> > I think I can make TestICUCollationField work without depending on
>> Lucene test sources. The other two will be a bit trickier.
>> >
>> > On Fri, Mar 5, 2021 at 1:56 AM Dawid Weiss <dawid.weiss@gmail.com>
>> wrote:
>> >>
>> >> > ./gradlew -Dskip.lucene=true assemble check -x test -x documentation
>> >> > -x checkBrokenLinks -x checkLocalJavadocLinksSite
>> >>
>> >> I made Solr documentation compile last night. Some of the generated
>> >> links point at void (and thus the broken links checker fails) but I
>> >> think it's enough to make the repository split and then clean up
>> >> what's needed in each corresponding repository.
>> >>
>> >> So... this Sunday? Prior to that, we'd have to disable CI build
>> >> services currently pointing at the master branch so that they don't
>> >> start failing (I'll remove all content from master).
>> >>
>> >> Dawid
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> >> For additional commands, e-mail: dev-help@lucene.apache.org
>> >>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>