Advanced
Mailing List Archive

Mailing List Archive

  1. Home >
  2. Lucene>
  3. Java-Dev
Failing gradle precommits
joelsolr at gmail
Jan 8, 2021, 7:08 AM
Post #1 of 16 (900 views)
Permalink
I'm getting failing gradle precommits in master:

*> Task :solr:contrib:validateSourcePatterns* FAILED

tabs instead spaces:
/Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder.xml

tabs instead spaces:
/Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSolrEntityProcessorEndToEnd.xml

tabs instead spaces:
/Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestErrorHandling.xml

tabs instead spaces:
/Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestScriptTransformer.xml

tabs instead spaces:
/Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSqlEntityProcessor.xml

tabs instead spaces:
/Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder2.xml

tabs instead spaces:
/Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestZKPropertiesWriter.xml

tabs instead spaces:
/Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler-extras/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestTikaEntityProcessor.xml


FAILURE: Build failed with an exception.


* Where:

Script
'/Users/joelbernstein/committer/lucene-solr/gradle/validation/validate-source-patterns.gradle'
line: 324


* What went wrong:

Execution failed for task ':solr:contrib:validateSourcePatterns'.

> Found 8 violations in source files (tabs instead spaces).


Are others seeing this as well? I'm not seeing Jenkins emails about this.


Joel Bernstein
http://joelsolr.blogspot.com/
Re: Failing gradle precommits [ In reply to ]
epugh at opensourceconnections
Jan 8, 2021, 7:55 AM
Post #2 of 16 (900 views)
Permalink
It ran for me just fine. I *think* you may not be up to date, as dataimporthandler/ is no longer in master!


> On Jan 8, 2021, at 10:08 AM, Joel Bernstein <joelsolr@gmail.com> wrote:
>
> I'm getting failing gradle precommits in master:
>
> > Task :solr:contrib:validateSourcePatterns FAILED
> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder.xml
> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSolrEntityProcessorEndToEnd.xml
> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestErrorHandling.xml
> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestScriptTransformer.xml
> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSqlEntityProcessor.xml
> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder2.xml
> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestZKPropertiesWriter.xml
> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler-extras/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestTikaEntityProcessor.xml
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Script '/Users/joelbernstein/committer/lucene-solr/gradle/validation/validate-source-patterns.gradle' line: 324
>
> * What went wrong:
> Execution failed for task ':solr:contrib:validateSourcePatterns'.
> > Found 8 violations in source files (tabs instead spaces).
>
>
> Are others seeing this as well? I'm not seeing Jenkins emails about this.
>
>
> Joel Bernstein
> http://joelsolr.blogspot.com/ <http://joelsolr.blogspot.com/>

_______________________
Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com <http://www.opensourceconnections.com/> | My Free/Busy <http://tinyurl.com/eric-cal>
Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
Re: Failing gradle precommits [ In reply to ]
joelsolr at gmail
Jan 8, 2021, 8:16 AM
Post #3 of 16 (900 views)
Permalink
Thanks Eric, I'll do a fresh clone, something must be out of wack with my
local repo.


Joel Bernstein
http://joelsolr.blogspot.com/


On Fri, Jan 8, 2021 at 10:55 AM Eric Pugh <epugh@opensourceconnections.com>
wrote:

> It ran for me just fine. I *think* you may not be up to date, as
> dataimporthandler/ is no longer in master!
>
>
> On Jan 8, 2021, at 10:08 AM, Joel Bernstein <joelsolr@gmail.com> wrote:
>
> I'm getting failing gradle precommits in master:
>
> *> Task :solr:contrib:validateSourcePatterns* FAILED
> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder.xml
> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSolrEntityProcessorEndToEnd.xml
> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestErrorHandling.xml
> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestScriptTransformer.xml
> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSqlEntityProcessor.xml
> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder2.xml
> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestZKPropertiesWriter.xml
> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler-extras/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestTikaEntityProcessor.xml
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Script
> '/Users/joelbernstein/committer/lucene-solr/gradle/validation/validate-source-patterns.gradle'
> line: 324
>
> * What went wrong:
> Execution failed for task ':solr:contrib:validateSourcePatterns'.
> > Found 8 violations in source files (tabs instead spaces).
>
>
> Are others seeing this as well? I'm not seeing Jenkins emails about this.
>
>
> Joel Bernstein
> http://joelsolr.blogspot.com/
>
>
> _______________________
> *Eric Pugh **| *Founder & CEO | OpenSource Connections, LLC | 434.466.1467
> | http://www.opensourceconnections.com | My Free/Busy
> <http://tinyurl.com/eric-cal>
> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
> <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
> This e-mail and all contents, including attachments, is considered to be
> Company Confidential unless explicitly stated otherwise, regardless
> of whether attachments are marked as such.
>
>
Re: Failing gradle precommits [ In reply to ]
joelsolr at gmail
Jan 8, 2021, 8:35 AM
Post #4 of 16 (900 views)
Permalink
It turned out to be this while I merged branches:

warning: inexact rename detection was skipped due to too many files.

warning: you may want to set your merge.renamelimit variable to at least
1639 and retry the command.

Joel Bernstein
http://joelsolr.blogspot.com/


On Fri, Jan 8, 2021 at 11:16 AM Joel Bernstein <joelsolr@gmail.com> wrote:

> Thanks Eric, I'll do a fresh clone, something must be out of wack with my
> local repo.
>
>
> Joel Bernstein
> http://joelsolr.blogspot.com/
>
>
> On Fri, Jan 8, 2021 at 10:55 AM Eric Pugh <epugh@opensourceconnections.com>
> wrote:
>
>> It ran for me just fine. I *think* you may not be up to date, as
>> dataimporthandler/ is no longer in master!
>>
>>
>> On Jan 8, 2021, at 10:08 AM, Joel Bernstein <joelsolr@gmail.com> wrote:
>>
>> I'm getting failing gradle precommits in master:
>>
>> *> Task :solr:contrib:validateSourcePatterns* FAILED
>> tabs instead spaces:
>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder.xml
>> tabs instead spaces:
>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSolrEntityProcessorEndToEnd.xml
>> tabs instead spaces:
>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestErrorHandling.xml
>> tabs instead spaces:
>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestScriptTransformer.xml
>> tabs instead spaces:
>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSqlEntityProcessor.xml
>> tabs instead spaces:
>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder2.xml
>> tabs instead spaces:
>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestZKPropertiesWriter.xml
>> tabs instead spaces:
>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler-extras/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestTikaEntityProcessor.xml
>>
>> FAILURE: Build failed with an exception.
>>
>> * Where:
>> Script
>> '/Users/joelbernstein/committer/lucene-solr/gradle/validation/validate-source-patterns.gradle'
>> line: 324
>>
>> * What went wrong:
>> Execution failed for task ':solr:contrib:validateSourcePatterns'.
>> > Found 8 violations in source files (tabs instead spaces).
>>
>>
>> Are others seeing this as well? I'm not seeing Jenkins emails about this.
>>
>>
>> Joel Bernstein
>> http://joelsolr.blogspot.com/
>>
>>
>> _______________________
>> *Eric Pugh **| *Founder & CEO | OpenSource Connections, LLC | 434.466.1467
>> | http://www.opensourceconnections.com | My Free/Busy
>> <http://tinyurl.com/eric-cal>
>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
>> <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
>> This e-mail and all contents, including attachments, is considered to be
>> Company Confidential unless explicitly stated otherwise, regardless
>> of whether attachments are marked as such.
>>
>>
Re: Failing gradle precommits [ In reply to ]
houstonputman at gmail
Jan 8, 2021, 8:43 AM
Post #5 of 16 (900 views)
Permalink
Weirdly enough, Github PR precommit actions have started to OOM. Not sure
if it's a github thing or something that changed on our end...

On Fri, Jan 8, 2021 at 11:37 AM Joel Bernstein <joelsolr@gmail.com> wrote:

> It turned out to be this while I merged branches:
>
> warning: inexact rename detection was skipped due to too many files.
>
> warning: you may want to set your merge.renamelimit variable to at least
> 1639 and retry the command.
>
> Joel Bernstein
> http://joelsolr.blogspot.com/
>
>
> On Fri, Jan 8, 2021 at 11:16 AM Joel Bernstein <joelsolr@gmail.com> wrote:
>
>> Thanks Eric, I'll do a fresh clone, something must be out of wack with my
>> local repo.
>>
>>
>> Joel Bernstein
>> http://joelsolr.blogspot.com/
>>
>>
>> On Fri, Jan 8, 2021 at 10:55 AM Eric Pugh <
>> epugh@opensourceconnections.com> wrote:
>>
>>> It ran for me just fine. I *think* you may not be up to date, as
>>> dataimporthandler/ is no longer in master!
>>>
>>>
>>> On Jan 8, 2021, at 10:08 AM, Joel Bernstein <joelsolr@gmail.com> wrote:
>>>
>>> I'm getting failing gradle precommits in master:
>>>
>>> *> Task :solr:contrib:validateSourcePatterns* FAILED
>>> tabs instead spaces:
>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder.xml
>>> tabs instead spaces:
>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSolrEntityProcessorEndToEnd.xml
>>> tabs instead spaces:
>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestErrorHandling.xml
>>> tabs instead spaces:
>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestScriptTransformer.xml
>>> tabs instead spaces:
>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSqlEntityProcessor.xml
>>> tabs instead spaces:
>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder2.xml
>>> tabs instead spaces:
>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestZKPropertiesWriter.xml
>>> tabs instead spaces:
>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler-extras/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestTikaEntityProcessor.xml
>>>
>>> FAILURE: Build failed with an exception.
>>>
>>> * Where:
>>> Script
>>> '/Users/joelbernstein/committer/lucene-solr/gradle/validation/validate-source-patterns.gradle'
>>> line: 324
>>>
>>> * What went wrong:
>>> Execution failed for task ':solr:contrib:validateSourcePatterns'.
>>> > Found 8 violations in source files (tabs instead spaces).
>>>
>>>
>>> Are others seeing this as well? I'm not seeing Jenkins emails about this.
>>>
>>>
>>> Joel Bernstein
>>> http://joelsolr.blogspot.com/
>>>
>>>
>>> _______________________
>>> *Eric Pugh **| *Founder & CEO | OpenSource Connections, LLC | 434.466.1467
>>> | http://www.opensourceconnections.com | My Free/Busy
>>> <http://tinyurl.com/eric-cal>
>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
>>> <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
>>> This e-mail and all contents, including attachments, is considered to be
>>> Company Confidential unless explicitly stated otherwise, regardless
>>> of whether attachments are marked as such.
>>>
>>>
Re: Failing gradle precommits [ In reply to ]
thelabdude at gmail
Jan 8, 2021, 10:06 AM
Post #6 of 16 (900 views)
Permalink
Same for my PR too ... OOMs about 14 minutes in ...

On Fri, Jan 8, 2021 at 9:45 AM Houston Putman <houstonputman@gmail.com>
wrote:

> Weirdly enough, Github PR precommit actions have started to OOM. Not sure
> if it's a github thing or something that changed on our end...
>
> On Fri, Jan 8, 2021 at 11:37 AM Joel Bernstein <joelsolr@gmail.com> wrote:
>
>> It turned out to be this while I merged branches:
>>
>> warning: inexact rename detection was skipped due to too many files.
>>
>> warning: you may want to set your merge.renamelimit variable to at least
>> 1639 and retry the command.
>>
>> Joel Bernstein
>> http://joelsolr.blogspot.com/
>>
>>
>> On Fri, Jan 8, 2021 at 11:16 AM Joel Bernstein <joelsolr@gmail.com>
>> wrote:
>>
>>> Thanks Eric, I'll do a fresh clone, something must be out of wack with
>>> my local repo.
>>>
>>>
>>> Joel Bernstein
>>> http://joelsolr.blogspot.com/
>>>
>>>
>>> On Fri, Jan 8, 2021 at 10:55 AM Eric Pugh <
>>> epugh@opensourceconnections.com> wrote:
>>>
>>>> It ran for me just fine. I *think* you may not be up to date, as
>>>> dataimporthandler/ is no longer in master!
>>>>
>>>>
>>>> On Jan 8, 2021, at 10:08 AM, Joel Bernstein <joelsolr@gmail.com> wrote:
>>>>
>>>> I'm getting failing gradle precommits in master:
>>>>
>>>> *> Task :solr:contrib:validateSourcePatterns* FAILED
>>>> tabs instead spaces:
>>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder.xml
>>>> tabs instead spaces:
>>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSolrEntityProcessorEndToEnd.xml
>>>> tabs instead spaces:
>>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestErrorHandling.xml
>>>> tabs instead spaces:
>>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestScriptTransformer.xml
>>>> tabs instead spaces:
>>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSqlEntityProcessor.xml
>>>> tabs instead spaces:
>>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder2.xml
>>>> tabs instead spaces:
>>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestZKPropertiesWriter.xml
>>>> tabs instead spaces:
>>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler-extras/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestTikaEntityProcessor.xml
>>>>
>>>> FAILURE: Build failed with an exception.
>>>>
>>>> * Where:
>>>> Script
>>>> '/Users/joelbernstein/committer/lucene-solr/gradle/validation/validate-source-patterns.gradle'
>>>> line: 324
>>>>
>>>> * What went wrong:
>>>> Execution failed for task ':solr:contrib:validateSourcePatterns'.
>>>> > Found 8 violations in source files (tabs instead spaces).
>>>>
>>>>
>>>> Are others seeing this as well? I'm not seeing Jenkins emails about
>>>> this.
>>>>
>>>>
>>>> Joel Bernstein
>>>> http://joelsolr.blogspot.com/
>>>>
>>>>
>>>> _______________________
>>>> *Eric Pugh **| *Founder & CEO | OpenSource Connections, LLC | 434.466.1467
>>>> | http://www.opensourceconnections.com | My Free/Busy
>>>> <http://tinyurl.com/eric-cal>
>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
>>>> <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
>>>> This e-mail and all contents, including attachments, is considered to
>>>> be Company Confidential unless explicitly stated otherwise, regardless
>>>> of whether attachments are marked as such.
>>>>
>>>>
Re: Failing gradle precommits [ In reply to ]
dsmiley at apache
Jan 8, 2021, 10:13 AM
Post #7 of 16 (900 views)
Permalink
Perhaps the OOMs are because .github/workflows/gradle-precommit.yml
yesterday switched from doing "gradlew check -x test" to "gradlew precomit"
? CC Michael Sokolov

~ David Smiley
Apache Lucene/Solr Search Developer
http://www.linkedin.com/in/davidwsmiley


On Fri, Jan 8, 2021 at 1:06 PM Timothy Potter <thelabdude@gmail.com> wrote:

> Same for my PR too ... OOMs about 14 minutes in ...
>
> On Fri, Jan 8, 2021 at 9:45 AM Houston Putman <houstonputman@gmail.com>
> wrote:
>
>> Weirdly enough, Github PR precommit actions have started to OOM. Not sure
>> if it's a github thing or something that changed on our end...
>>
>> On Fri, Jan 8, 2021 at 11:37 AM Joel Bernstein <joelsolr@gmail.com>
>> wrote:
>>
>>> It turned out to be this while I merged branches:
>>>
>>> warning: inexact rename detection was skipped due to too many files.
>>>
>>> warning: you may want to set your merge.renamelimit variable to at least
>>> 1639 and retry the command.
>>>
>>> Joel Bernstein
>>> http://joelsolr.blogspot.com/
>>>
>>>
>>> On Fri, Jan 8, 2021 at 11:16 AM Joel Bernstein <joelsolr@gmail.com>
>>> wrote:
>>>
>>>> Thanks Eric, I'll do a fresh clone, something must be out of wack with
>>>> my local repo.
>>>>
>>>>
>>>> Joel Bernstein
>>>> http://joelsolr.blogspot.com/
>>>>
>>>>
>>>> On Fri, Jan 8, 2021 at 10:55 AM Eric Pugh <
>>>> epugh@opensourceconnections.com> wrote:
>>>>
>>>>> It ran for me just fine. I *think* you may not be up to date, as
>>>>> dataimporthandler/ is no longer in master!
>>>>>
>>>>>
>>>>> On Jan 8, 2021, at 10:08 AM, Joel Bernstein <joelsolr@gmail.com>
>>>>> wrote:
>>>>>
>>>>> I'm getting failing gradle precommits in master:
>>>>>
>>>>> *> Task :solr:contrib:validateSourcePatterns* FAILED
>>>>> tabs instead spaces:
>>>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder.xml
>>>>> tabs instead spaces:
>>>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSolrEntityProcessorEndToEnd.xml
>>>>> tabs instead spaces:
>>>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestErrorHandling.xml
>>>>> tabs instead spaces:
>>>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestScriptTransformer.xml
>>>>> tabs instead spaces:
>>>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSqlEntityProcessor.xml
>>>>> tabs instead spaces:
>>>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder2.xml
>>>>> tabs instead spaces:
>>>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestZKPropertiesWriter.xml
>>>>> tabs instead spaces:
>>>>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler-extras/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestTikaEntityProcessor.xml
>>>>>
>>>>> FAILURE: Build failed with an exception.
>>>>>
>>>>> * Where:
>>>>> Script
>>>>> '/Users/joelbernstein/committer/lucene-solr/gradle/validation/validate-source-patterns.gradle'
>>>>> line: 324
>>>>>
>>>>> * What went wrong:
>>>>> Execution failed for task ':solr:contrib:validateSourcePatterns'.
>>>>> > Found 8 violations in source files (tabs instead spaces).
>>>>>
>>>>>
>>>>> Are others seeing this as well? I'm not seeing Jenkins emails about
>>>>> this.
>>>>>
>>>>>
>>>>> Joel Bernstein
>>>>> http://joelsolr.blogspot.com/
>>>>>
>>>>>
>>>>> _______________________
>>>>> *Eric Pugh **| *Founder & CEO | OpenSource Connections, LLC | 434.466.1467
>>>>> | http://www.opensourceconnections.com | My Free/Busy
>>>>> <http://tinyurl.com/eric-cal>
>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
>>>>> <https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
>>>>> This e-mail and all contents, including attachments, is considered to
>>>>> be Company Confidential unless explicitly stated otherwise, regardless
>>>>> of whether attachments are marked as such.
>>>>>
>>>>>
Re: Failing gradle precommits [ In reply to ]
uwe at thetaphi
Jan 8, 2021, 10:43 AM
Post #8 of 16 (900 views)
Permalink
The problembcomes from the fact that Gradle sets a Xmx for itself in the settings file. Jenkins installs a settings file before.

As every GitHub run is a clean checkout in new working dir, the settings never persist.

IMHO, we should change the command line and pass JVM options to set heap size as it is written to the settings file.

Uwe

Am January 8, 2021 6:13:01 PM UTC schrieb David Smiley <dsmiley@apache.org>:
>Perhaps the OOMs are because .github/workflows/gradle-precommit.yml
>yesterday switched from doing "gradlew check -x test" to "gradlew
>precomit"
>? CC Michael Sokolov
>
>~ David Smiley
>Apache Lucene/Solr Search Developer
>http://www.linkedin.com/in/davidwsmiley
>
>
>On Fri, Jan 8, 2021 at 1:06 PM Timothy Potter <thelabdude@gmail.com>
>wrote:
>
>> Same for my PR too ... OOMs about 14 minutes in ...
>>
>> On Fri, Jan 8, 2021 at 9:45 AM Houston Putman
><houstonputman@gmail.com>
>> wrote:
>>
>>> Weirdly enough, Github PR precommit actions have started to OOM. Not
>sure
>>> if it's a github thing or something that changed on our end...
>>>
>>> On Fri, Jan 8, 2021 at 11:37 AM Joel Bernstein <joelsolr@gmail.com>
>>> wrote:
>>>
>>>> It turned out to be this while I merged branches:
>>>>
>>>> warning: inexact rename detection was skipped due to too many
>files.
>>>>
>>>> warning: you may want to set your merge.renamelimit variable to at
>least
>>>> 1639 and retry the command.
>>>>
>>>> Joel Bernstein
>>>> http://joelsolr.blogspot.com/
>>>>
>>>>
>>>> On Fri, Jan 8, 2021 at 11:16 AM Joel Bernstein <joelsolr@gmail.com>
>>>> wrote:
>>>>
>>>>> Thanks Eric, I'll do a fresh clone, something must be out of wack
>with
>>>>> my local repo.
>>>>>
>>>>>
>>>>> Joel Bernstein
>>>>> http://joelsolr.blogspot.com/
>>>>>
>>>>>
>>>>> On Fri, Jan 8, 2021 at 10:55 AM Eric Pugh <
>>>>> epugh@opensourceconnections.com> wrote:
>>>>>
>>>>>> It ran for me just fine. I *think* you may not be up to date,
>as
>>>>>> dataimporthandler/ is no longer in master!
>>>>>>
>>>>>>
>>>>>> On Jan 8, 2021, at 10:08 AM, Joel Bernstein <joelsolr@gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>> I'm getting failing gradle precommits in master:
>>>>>>
>>>>>> *> Task :solr:contrib:validateSourcePatterns* FAILED
>>>>>> tabs instead spaces:
>>>>>>
>/Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder.xml
>>>>>> tabs instead spaces:
>>>>>>
>/Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSolrEntityProcessorEndToEnd.xml
>>>>>> tabs instead spaces:
>>>>>>
>/Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestErrorHandling.xml
>>>>>> tabs instead spaces:
>>>>>>
>/Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestScriptTransformer.xml
>>>>>> tabs instead spaces:
>>>>>>
>/Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSqlEntityProcessor.xml
>>>>>> tabs instead spaces:
>>>>>>
>/Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder2.xml
>>>>>> tabs instead spaces:
>>>>>>
>/Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestZKPropertiesWriter.xml
>>>>>> tabs instead spaces:
>>>>>>
>/Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler-extras/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestTikaEntityProcessor.xml
>>>>>>
>>>>>> FAILURE: Build failed with an exception.
>>>>>>
>>>>>> * Where:
>>>>>> Script
>>>>>>
>'/Users/joelbernstein/committer/lucene-solr/gradle/validation/validate-source-patterns.gradle'
>>>>>> line: 324
>>>>>>
>>>>>> * What went wrong:
>>>>>> Execution failed for task ':solr:contrib:validateSourcePatterns'.
>>>>>> > Found 8 violations in source files (tabs instead spaces).
>>>>>>
>>>>>>
>>>>>> Are others seeing this as well? I'm not seeing Jenkins emails
>about
>>>>>> this.
>>>>>>
>>>>>>
>>>>>> Joel Bernstein
>>>>>> http://joelsolr.blogspot.com/
>>>>>>
>>>>>>
>>>>>> _______________________
>>>>>> *Eric Pugh **| *Founder & CEO | OpenSource Connections, LLC |
>434.466.1467
>>>>>> | http://www.opensourceconnections.com | My Free/Busy
>>>>>> <http://tinyurl.com/eric-cal>
>>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
>>>>>>
><https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
>>>>>> This e-mail and all contents, including attachments, is
>considered to
>>>>>> be Company Confidential unless explicitly stated otherwise,
>regardless
>>>>>> of whether attachments are marked as such.
>>>>>>
>>>>>>

--
Uwe Schindler
Achterdiek 19, 28357 Bremen
https://www.thetaphi.de
Re: Failing gradle precommits [ In reply to ]
dawid.weiss at gmail
Jan 8, 2021, 11:02 AM
Post #9 of 16 (900 views)
Permalink
Can those jobs just run a sequence of two commands -

./gradlew localSettings
./gradlew check -x test

This would solve the problem as proper JVM settings (tuned for the
machine/ image it's running on) would be written and used on
subsequent run.

Dawid

On Fri, Jan 8, 2021 at 7:44 PM Uwe Schindler <uwe@thetaphi.de> wrote:
>
> The problembcomes from the fact that Gradle sets a Xmx for itself in the settings file. Jenkins installs a settings file before.
>
> As every GitHub run is a clean checkout in new working dir, the settings never persist.
>
> IMHO, we should change the command line and pass JVM options to set heap size as it is written to the settings file.
>
> Uwe
>
> Am January 8, 2021 6:13:01 PM UTC schrieb David Smiley <dsmiley@apache.org>:
>>
>> Perhaps the OOMs are because .github/workflows/gradle-precommit.yml yesterday switched from doing "gradlew check -x test" to "gradlew precomit" ? CC Michael Sokolov
>>
>> ~ David Smiley
>> Apache Lucene/Solr Search Developer
>> http://www.linkedin.com/in/davidwsmiley
>>
>>
>> On Fri, Jan 8, 2021 at 1:06 PM Timothy Potter <thelabdude@gmail.com> wrote:
>>>
>>> Same for my PR too ... OOMs about 14 minutes in ...
>>>
>>> On Fri, Jan 8, 2021 at 9:45 AM Houston Putman <houstonputman@gmail.com> wrote:
>>>>
>>>> Weirdly enough, Github PR precommit actions have started to OOM. Not sure if it's a github thing or something that changed on our end...
>>>>
>>>> On Fri, Jan 8, 2021 at 11:37 AM Joel Bernstein <joelsolr@gmail.com> wrote:
>>>>>
>>>>> It turned out to be this while I merged branches:
>>>>>
>>>>> warning: inexact rename detection was skipped due to too many files.
>>>>>
>>>>> warning: you may want to set your merge.renamelimit variable to at least 1639 and retry the command.
>>>>>
>>>>>
>>>>> Joel Bernstein
>>>>> http://joelsolr.blogspot.com/
>>>>>
>>>>>
>>>>> On Fri, Jan 8, 2021 at 11:16 AM Joel Bernstein <joelsolr@gmail.com> wrote:
>>>>>>
>>>>>> Thanks Eric, I'll do a fresh clone, something must be out of wack with my local repo.
>>>>>>
>>>>>>
>>>>>> Joel Bernstein
>>>>>> http://joelsolr.blogspot.com/
>>>>>>
>>>>>>
>>>>>> On Fri, Jan 8, 2021 at 10:55 AM Eric Pugh <epugh@opensourceconnections.com> wrote:
>>>>>>>
>>>>>>> It ran for me just fine. I *think* you may not be up to date, as dataimporthandler/ is no longer in master!
>>>>>>>
>>>>>>>
>>>>>>> On Jan 8, 2021, at 10:08 AM, Joel Bernstein <joelsolr@gmail.com> wrote:
>>>>>>>
>>>>>>> I'm getting failing gradle precommits in master:
>>>>>>>
>>>>>>> > Task :solr:contrib:validateSourcePatterns FAILED
>>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder.xml
>>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSolrEntityProcessorEndToEnd.xml
>>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestErrorHandling.xml
>>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestScriptTransformer.xml
>>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSqlEntityProcessor.xml
>>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder2.xml
>>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestZKPropertiesWriter.xml
>>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler-extras/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestTikaEntityProcessor.xml
>>>>>>>
>>>>>>> FAILURE: Build failed with an exception.
>>>>>>>
>>>>>>> * Where:
>>>>>>> Script '/Users/joelbernstein/committer/lucene-solr/gradle/validation/validate-source-patterns.gradle' line: 324
>>>>>>>
>>>>>>> * What went wrong:
>>>>>>> Execution failed for task ':solr:contrib:validateSourcePatterns'.
>>>>>>> > Found 8 violations in source files (tabs instead spaces).
>>>>>>>
>>>>>>>
>>>>>>> Are others seeing this as well? I'm not seeing Jenkins emails about this.
>>>>>>>
>>>>>>>
>>>>>>> Joel Bernstein
>>>>>>> http://joelsolr.blogspot.com/
>>>>>>>
>>>>>>>
>>>>>>> _______________________
>>>>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com | My Free/Busy
>>>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
>>>>>>> This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
>>>>>>>
>
> --
> Uwe Schindler
> Achterdiek 19, 28357 Bremen
> https://www.thetaphi.de

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Failing gradle precommits [ In reply to ]
houstonputman at gmail
Jan 8, 2021, 11:26 AM
Post #10 of 16 (900 views)
Permalink
Yeah, that should work Dawid. I'll create a PR that tests it out.

- Houston

On Fri, Jan 8, 2021 at 2:02 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:

> Can those jobs just run a sequence of two commands -
>
> ./gradlew localSettings
> ./gradlew check -x test
>
> This would solve the problem as proper JVM settings (tuned for the
> machine/ image it's running on) would be written and used on
> subsequent run.
>
> Dawid
>
> On Fri, Jan 8, 2021 at 7:44 PM Uwe Schindler <uwe@thetaphi.de> wrote:
> >
> > The problembcomes from the fact that Gradle sets a Xmx for itself in the
> settings file. Jenkins installs a settings file before.
> >
> > As every GitHub run is a clean checkout in new working dir, the settings
> never persist.
> >
> > IMHO, we should change the command line and pass JVM options to set heap
> size as it is written to the settings file.
> >
> > Uwe
> >
> > Am January 8, 2021 6:13:01 PM UTC schrieb David Smiley <
> dsmiley@apache.org>:
> >>
> >> Perhaps the OOMs are because .github/workflows/gradle-precommit.yml
> yesterday switched from doing "gradlew check -x test" to "gradlew precomit"
> ? CC Michael Sokolov
> >>
> >> ~ David Smiley
> >> Apache Lucene/Solr Search Developer
> >> http://www.linkedin.com/in/davidwsmiley
> >>
> >>
> >> On Fri, Jan 8, 2021 at 1:06 PM Timothy Potter <thelabdude@gmail.com>
> wrote:
> >>>
> >>> Same for my PR too ... OOMs about 14 minutes in ...
> >>>
> >>> On Fri, Jan 8, 2021 at 9:45 AM Houston Putman <houstonputman@gmail.com>
> wrote:
> >>>>
> >>>> Weirdly enough, Github PR precommit actions have started to OOM. Not
> sure if it's a github thing or something that changed on our end...
> >>>>
> >>>> On Fri, Jan 8, 2021 at 11:37 AM Joel Bernstein <joelsolr@gmail.com>
> wrote:
> >>>>>
> >>>>> It turned out to be this while I merged branches:
> >>>>>
> >>>>> warning: inexact rename detection was skipped due to too many files.
> >>>>>
> >>>>> warning: you may want to set your merge.renamelimit variable to at
> least 1639 and retry the command.
> >>>>>
> >>>>>
> >>>>> Joel Bernstein
> >>>>> http://joelsolr.blogspot.com/
> >>>>>
> >>>>>
> >>>>> On Fri, Jan 8, 2021 at 11:16 AM Joel Bernstein <joelsolr@gmail.com>
> wrote:
> >>>>>>
> >>>>>> Thanks Eric, I'll do a fresh clone, something must be out of wack
> with my local repo.
> >>>>>>
> >>>>>>
> >>>>>> Joel Bernstein
> >>>>>> http://joelsolr.blogspot.com/
> >>>>>>
> >>>>>>
> >>>>>> On Fri, Jan 8, 2021 at 10:55 AM Eric Pugh <
> epugh@opensourceconnections.com> wrote:
> >>>>>>>
> >>>>>>> It ran for me just fine. I *think* you may not be up to date, as
> dataimporthandler/ is no longer in master!
> >>>>>>>
> >>>>>>>
> >>>>>>> On Jan 8, 2021, at 10:08 AM, Joel Bernstein <joelsolr@gmail.com>
> wrote:
> >>>>>>>
> >>>>>>> I'm getting failing gradle precommits in master:
> >>>>>>>
> >>>>>>> > Task :solr:contrib:validateSourcePatterns FAILED
> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder.xml
> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSolrEntityProcessorEndToEnd.xml
> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestErrorHandling.xml
> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestScriptTransformer.xml
> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSqlEntityProcessor.xml
> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder2.xml
> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestZKPropertiesWriter.xml
> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler-extras/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestTikaEntityProcessor.xml
> >>>>>>>
> >>>>>>> FAILURE: Build failed with an exception.
> >>>>>>>
> >>>>>>> * Where:
> >>>>>>> Script
> '/Users/joelbernstein/committer/lucene-solr/gradle/validation/validate-source-patterns.gradle'
> line: 324
> >>>>>>>
> >>>>>>> * What went wrong:
> >>>>>>> Execution failed for task ':solr:contrib:validateSourcePatterns'.
> >>>>>>> > Found 8 violations in source files (tabs instead spaces).
> >>>>>>>
> >>>>>>>
> >>>>>>> Are others seeing this as well? I'm not seeing Jenkins emails
> about this.
> >>>>>>>
> >>>>>>>
> >>>>>>> Joel Bernstein
> >>>>>>> http://joelsolr.blogspot.com/
> >>>>>>>
> >>>>>>>
> >>>>>>> _______________________
> >>>>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC |
> 434.466.1467 | http://www.opensourceconnections.com | My Free/Busy
> >>>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
> >>>>>>> This e-mail and all contents, including attachments, is considered
> to be Company Confidential unless explicitly stated otherwise, regardless
> of whether attachments are marked as such.
> >>>>>>>
> >
> > --
> > Uwe Schindler
> > Achterdiek 19, 28357 Bremen
> > https://www.thetaphi.de
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
Re: Failing gradle precommits [ In reply to ]
dawid.weiss at gmail
Jan 8, 2021, 11:28 AM
Post #11 of 16 (900 views)
Permalink
The switch to full check (minus tests) makes the "precommit" really
heavy... it's around 14 minutes on my not-so-fancy machine. I'm
curious if it's going to pass on github or timeout somehow.

On Fri, Jan 8, 2021 at 8:26 PM Houston Putman <houstonputman@gmail.com> wrote:
>
> Yeah, that should work Dawid. I'll create a PR that tests it out.
>
> - Houston
>
> On Fri, Jan 8, 2021 at 2:02 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>>
>> Can those jobs just run a sequence of two commands -
>>
>> ./gradlew localSettings
>> ./gradlew check -x test
>>
>> This would solve the problem as proper JVM settings (tuned for the
>> machine/ image it's running on) would be written and used on
>> subsequent run.
>>
>> Dawid
>>
>> On Fri, Jan 8, 2021 at 7:44 PM Uwe Schindler <uwe@thetaphi.de> wrote:
>> >
>> > The problembcomes from the fact that Gradle sets a Xmx for itself in the settings file. Jenkins installs a settings file before.
>> >
>> > As every GitHub run is a clean checkout in new working dir, the settings never persist.
>> >
>> > IMHO, we should change the command line and pass JVM options to set heap size as it is written to the settings file.
>> >
>> > Uwe
>> >
>> > Am January 8, 2021 6:13:01 PM UTC schrieb David Smiley <dsmiley@apache.org>:
>> >>
>> >> Perhaps the OOMs are because .github/workflows/gradle-precommit.yml yesterday switched from doing "gradlew check -x test" to "gradlew precomit" ? CC Michael Sokolov
>> >>
>> >> ~ David Smiley
>> >> Apache Lucene/Solr Search Developer
>> >> http://www.linkedin.com/in/davidwsmiley
>> >>
>> >>
>> >> On Fri, Jan 8, 2021 at 1:06 PM Timothy Potter <thelabdude@gmail.com> wrote:
>> >>>
>> >>> Same for my PR too ... OOMs about 14 minutes in ...
>> >>>
>> >>> On Fri, Jan 8, 2021 at 9:45 AM Houston Putman <houstonputman@gmail.com> wrote:
>> >>>>
>> >>>> Weirdly enough, Github PR precommit actions have started to OOM. Not sure if it's a github thing or something that changed on our end...
>> >>>>
>> >>>> On Fri, Jan 8, 2021 at 11:37 AM Joel Bernstein <joelsolr@gmail.com> wrote:
>> >>>>>
>> >>>>> It turned out to be this while I merged branches:
>> >>>>>
>> >>>>> warning: inexact rename detection was skipped due to too many files.
>> >>>>>
>> >>>>> warning: you may want to set your merge.renamelimit variable to at least 1639 and retry the command.
>> >>>>>
>> >>>>>
>> >>>>> Joel Bernstein
>> >>>>> http://joelsolr.blogspot.com/
>> >>>>>
>> >>>>>
>> >>>>> On Fri, Jan 8, 2021 at 11:16 AM Joel Bernstein <joelsolr@gmail.com> wrote:
>> >>>>>>
>> >>>>>> Thanks Eric, I'll do a fresh clone, something must be out of wack with my local repo.
>> >>>>>>
>> >>>>>>
>> >>>>>> Joel Bernstein
>> >>>>>> http://joelsolr.blogspot.com/
>> >>>>>>
>> >>>>>>
>> >>>>>> On Fri, Jan 8, 2021 at 10:55 AM Eric Pugh <epugh@opensourceconnections.com> wrote:
>> >>>>>>>
>> >>>>>>> It ran for me just fine. I *think* you may not be up to date, as dataimporthandler/ is no longer in master!
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> On Jan 8, 2021, at 10:08 AM, Joel Bernstein <joelsolr@gmail.com> wrote:
>> >>>>>>>
>> >>>>>>> I'm getting failing gradle precommits in master:
>> >>>>>>>
>> >>>>>>> > Task :solr:contrib:validateSourcePatterns FAILED
>> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder.xml
>> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSolrEntityProcessorEndToEnd.xml
>> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestErrorHandling.xml
>> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestScriptTransformer.xml
>> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSqlEntityProcessor.xml
>> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder2.xml
>> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestZKPropertiesWriter.xml
>> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler-extras/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestTikaEntityProcessor.xml
>> >>>>>>>
>> >>>>>>> FAILURE: Build failed with an exception.
>> >>>>>>>
>> >>>>>>> * Where:
>> >>>>>>> Script '/Users/joelbernstein/committer/lucene-solr/gradle/validation/validate-source-patterns.gradle' line: 324
>> >>>>>>>
>> >>>>>>> * What went wrong:
>> >>>>>>> Execution failed for task ':solr:contrib:validateSourcePatterns'.
>> >>>>>>> > Found 8 violations in source files (tabs instead spaces).
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> Are others seeing this as well? I'm not seeing Jenkins emails about this.
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> Joel Bernstein
>> >>>>>>> http://joelsolr.blogspot.com/
>> >>>>>>>
>> >>>>>>>
>> >>>>>>> _______________________
>> >>>>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com | My Free/Busy
>> >>>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
>> >>>>>>> This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
>> >>>>>>>
>> >
>> > --
>> > Uwe Schindler
>> > Achterdiek 19, 28357 Bremen
>> > https://www.thetaphi.de
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Failing gradle precommits [ In reply to ]
msokolov at gmail
Jan 8, 2021, 12:07 PM
Post #12 of 16 (900 views)
Permalink
Whoops! Well I guess we'll see. I wonder what other checks we are running
now that's were not part of precommit, aside from spotless?

On Fri, Jan 8, 2021, 2:28 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:

> The switch to full check (minus tests) makes the "precommit" really
> heavy... it's around 14 minutes on my not-so-fancy machine. I'm
> curious if it's going to pass on github or timeout somehow.
>
> On Fri, Jan 8, 2021 at 8:26 PM Houston Putman <houstonputman@gmail.com>
> wrote:
> >
> > Yeah, that should work Dawid. I'll create a PR that tests it out.
> >
> > - Houston
> >
> > On Fri, Jan 8, 2021 at 2:02 PM Dawid Weiss <dawid.weiss@gmail.com>
> wrote:
> >>
> >> Can those jobs just run a sequence of two commands -
> >>
> >> ./gradlew localSettings
> >> ./gradlew check -x test
> >>
> >> This would solve the problem as proper JVM settings (tuned for the
> >> machine/ image it's running on) would be written and used on
> >> subsequent run.
> >>
> >> Dawid
> >>
> >> On Fri, Jan 8, 2021 at 7:44 PM Uwe Schindler <uwe@thetaphi.de> wrote:
> >> >
> >> > The problembcomes from the fact that Gradle sets a Xmx for itself in
> the settings file. Jenkins installs a settings file before.
> >> >
> >> > As every GitHub run is a clean checkout in new working dir, the
> settings never persist.
> >> >
> >> > IMHO, we should change the command line and pass JVM options to set
> heap size as it is written to the settings file.
> >> >
> >> > Uwe
> >> >
> >> > Am January 8, 2021 6:13:01 PM UTC schrieb David Smiley <
> dsmiley@apache.org>:
> >> >>
> >> >> Perhaps the OOMs are because .github/workflows/gradle-precommit.yml
> yesterday switched from doing "gradlew check -x test" to "gradlew precomit"
> ? CC Michael Sokolov
> >> >>
> >> >> ~ David Smiley
> >> >> Apache Lucene/Solr Search Developer
> >> >> http://www.linkedin.com/in/davidwsmiley
> >> >>
> >> >>
> >> >> On Fri, Jan 8, 2021 at 1:06 PM Timothy Potter <thelabdude@gmail.com>
> wrote:
> >> >>>
> >> >>> Same for my PR too ... OOMs about 14 minutes in ...
> >> >>>
> >> >>> On Fri, Jan 8, 2021 at 9:45 AM Houston Putman <
> houstonputman@gmail.com> wrote:
> >> >>>>
> >> >>>> Weirdly enough, Github PR precommit actions have started to OOM.
> Not sure if it's a github thing or something that changed on our end...
> >> >>>>
> >> >>>> On Fri, Jan 8, 2021 at 11:37 AM Joel Bernstein <joelsolr@gmail.com>
> wrote:
> >> >>>>>
> >> >>>>> It turned out to be this while I merged branches:
> >> >>>>>
> >> >>>>> warning: inexact rename detection was skipped due to too many
> files.
> >> >>>>>
> >> >>>>> warning: you may want to set your merge.renamelimit variable to
> at least 1639 and retry the command.
> >> >>>>>
> >> >>>>>
> >> >>>>> Joel Bernstein
> >> >>>>> http://joelsolr.blogspot.com/
> >> >>>>>
> >> >>>>>
> >> >>>>> On Fri, Jan 8, 2021 at 11:16 AM Joel Bernstein <
> joelsolr@gmail.com> wrote:
> >> >>>>>>
> >> >>>>>> Thanks Eric, I'll do a fresh clone, something must be out of
> wack with my local repo.
> >> >>>>>>
> >> >>>>>>
> >> >>>>>> Joel Bernstein
> >> >>>>>> http://joelsolr.blogspot.com/
> >> >>>>>>
> >> >>>>>>
> >> >>>>>> On Fri, Jan 8, 2021 at 10:55 AM Eric Pugh <
> epugh@opensourceconnections.com> wrote:
> >> >>>>>>>
> >> >>>>>>> It ran for me just fine. I *think* you may not be up to date,
> as dataimporthandler/ is no longer in master!
> >> >>>>>>>
> >> >>>>>>>
> >> >>>>>>> On Jan 8, 2021, at 10:08 AM, Joel Bernstein <joelsolr@gmail.com>
> wrote:
> >> >>>>>>>
> >> >>>>>>> I'm getting failing gradle precommits in master:
> >> >>>>>>>
> >> >>>>>>> > Task :solr:contrib:validateSourcePatterns FAILED
> >> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder.xml
> >> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSolrEntityProcessorEndToEnd.xml
> >> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestErrorHandling.xml
> >> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestScriptTransformer.xml
> >> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSqlEntityProcessor.xml
> >> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder2.xml
> >> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestZKPropertiesWriter.xml
> >> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler-extras/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestTikaEntityProcessor.xml
> >> >>>>>>>
> >> >>>>>>> FAILURE: Build failed with an exception.
> >> >>>>>>>
> >> >>>>>>> * Where:
> >> >>>>>>> Script
> '/Users/joelbernstein/committer/lucene-solr/gradle/validation/validate-source-patterns.gradle'
> line: 324
> >> >>>>>>>
> >> >>>>>>> * What went wrong:
> >> >>>>>>> Execution failed for task
> ':solr:contrib:validateSourcePatterns'.
> >> >>>>>>> > Found 8 violations in source files (tabs instead spaces).
> >> >>>>>>>
> >> >>>>>>>
> >> >>>>>>> Are others seeing this as well? I'm not seeing Jenkins emails
> about this.
> >> >>>>>>>
> >> >>>>>>>
> >> >>>>>>> Joel Bernstein
> >> >>>>>>> http://joelsolr.blogspot.com/
> >> >>>>>>>
> >> >>>>>>>
> >> >>>>>>> _______________________
> >> >>>>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC |
> 434.466.1467 | http://www.opensourceconnections.com | My Free/Busy
> >> >>>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
> >> >>>>>>> This e-mail and all contents, including attachments, is
> considered to be Company Confidential unless explicitly stated otherwise,
> regardless of whether attachments are marked as such.
> >> >>>>>>>
> >> >
> >> > --
> >> > Uwe Schindler
> >> > Achterdiek 19, 28357 Bremen
> >> > https://www.thetaphi.de
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >> For additional commands, e-mail: dev-help@lucene.apache.org
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
Re: Failing gradle precommits [ In reply to ]
dawid.weiss at gmail
Jan 8, 2021, 1:42 PM
Post #13 of 16 (900 views)
Permalink
I don't remember, to be honest. I think javadocs, html linters - they
all contribute. We could remove some of them (via -x) on github if
they're too heavy.

On Fri, Jan 8, 2021 at 9:08 PM Michael Sokolov <msokolov@gmail.com> wrote:
>
> Whoops! Well I guess we'll see. I wonder what other checks we are running now that's were not part of precommit, aside from spotless?
>
> On Fri, Jan 8, 2021, 2:28 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>>
>> The switch to full check (minus tests) makes the "precommit" really
>> heavy... it's around 14 minutes on my not-so-fancy machine. I'm
>> curious if it's going to pass on github or timeout somehow.
>>
>> On Fri, Jan 8, 2021 at 8:26 PM Houston Putman <houstonputman@gmail.com> wrote:
>> >
>> > Yeah, that should work Dawid. I'll create a PR that tests it out.
>> >
>> > - Houston
>> >
>> > On Fri, Jan 8, 2021 at 2:02 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>> >>
>> >> Can those jobs just run a sequence of two commands -
>> >>
>> >> ./gradlew localSettings
>> >> ./gradlew check -x test
>> >>
>> >> This would solve the problem as proper JVM settings (tuned for the
>> >> machine/ image it's running on) would be written and used on
>> >> subsequent run.
>> >>
>> >> Dawid
>> >>
>> >> On Fri, Jan 8, 2021 at 7:44 PM Uwe Schindler <uwe@thetaphi.de> wrote:
>> >> >
>> >> > The problembcomes from the fact that Gradle sets a Xmx for itself in the settings file. Jenkins installs a settings file before.
>> >> >
>> >> > As every GitHub run is a clean checkout in new working dir, the settings never persist.
>> >> >
>> >> > IMHO, we should change the command line and pass JVM options to set heap size as it is written to the settings file.
>> >> >
>> >> > Uwe
>> >> >
>> >> > Am January 8, 2021 6:13:01 PM UTC schrieb David Smiley <dsmiley@apache.org>:
>> >> >>
>> >> >> Perhaps the OOMs are because .github/workflows/gradle-precommit.yml yesterday switched from doing "gradlew check -x test" to "gradlew precomit" ? CC Michael Sokolov
>> >> >>
>> >> >> ~ David Smiley
>> >> >> Apache Lucene/Solr Search Developer
>> >> >> http://www.linkedin.com/in/davidwsmiley
>> >> >>
>> >> >>
>> >> >> On Fri, Jan 8, 2021 at 1:06 PM Timothy Potter <thelabdude@gmail.com> wrote:
>> >> >>>
>> >> >>> Same for my PR too ... OOMs about 14 minutes in ...
>> >> >>>
>> >> >>> On Fri, Jan 8, 2021 at 9:45 AM Houston Putman <houstonputman@gmail.com> wrote:
>> >> >>>>
>> >> >>>> Weirdly enough, Github PR precommit actions have started to OOM. Not sure if it's a github thing or something that changed on our end...
>> >> >>>>
>> >> >>>> On Fri, Jan 8, 2021 at 11:37 AM Joel Bernstein <joelsolr@gmail.com> wrote:
>> >> >>>>>
>> >> >>>>> It turned out to be this while I merged branches:
>> >> >>>>>
>> >> >>>>> warning: inexact rename detection was skipped due to too many files.
>> >> >>>>>
>> >> >>>>> warning: you may want to set your merge.renamelimit variable to at least 1639 and retry the command.
>> >> >>>>>
>> >> >>>>>
>> >> >>>>> Joel Bernstein
>> >> >>>>> http://joelsolr.blogspot.com/
>> >> >>>>>
>> >> >>>>>
>> >> >>>>> On Fri, Jan 8, 2021 at 11:16 AM Joel Bernstein <joelsolr@gmail.com> wrote:
>> >> >>>>>>
>> >> >>>>>> Thanks Eric, I'll do a fresh clone, something must be out of wack with my local repo.
>> >> >>>>>>
>> >> >>>>>>
>> >> >>>>>> Joel Bernstein
>> >> >>>>>> http://joelsolr.blogspot.com/
>> >> >>>>>>
>> >> >>>>>>
>> >> >>>>>> On Fri, Jan 8, 2021 at 10:55 AM Eric Pugh <epugh@opensourceconnections.com> wrote:
>> >> >>>>>>>
>> >> >>>>>>> It ran for me just fine. I *think* you may not be up to date, as dataimporthandler/ is no longer in master!
>> >> >>>>>>>
>> >> >>>>>>>
>> >> >>>>>>> On Jan 8, 2021, at 10:08 AM, Joel Bernstein <joelsolr@gmail.com> wrote:
>> >> >>>>>>>
>> >> >>>>>>> I'm getting failing gradle precommits in master:
>> >> >>>>>>>
>> >> >>>>>>> > Task :solr:contrib:validateSourcePatterns FAILED
>> >> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder.xml
>> >> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSolrEntityProcessorEndToEnd.xml
>> >> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestErrorHandling.xml
>> >> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestScriptTransformer.xml
>> >> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSqlEntityProcessor.xml
>> >> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder2.xml
>> >> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestZKPropertiesWriter.xml
>> >> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler-extras/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestTikaEntityProcessor.xml
>> >> >>>>>>>
>> >> >>>>>>> FAILURE: Build failed with an exception.
>> >> >>>>>>>
>> >> >>>>>>> * Where:
>> >> >>>>>>> Script '/Users/joelbernstein/committer/lucene-solr/gradle/validation/validate-source-patterns.gradle' line: 324
>> >> >>>>>>>
>> >> >>>>>>> * What went wrong:
>> >> >>>>>>> Execution failed for task ':solr:contrib:validateSourcePatterns'.
>> >> >>>>>>> > Found 8 violations in source files (tabs instead spaces).
>> >> >>>>>>>
>> >> >>>>>>>
>> >> >>>>>>> Are others seeing this as well? I'm not seeing Jenkins emails about this.
>> >> >>>>>>>
>> >> >>>>>>>
>> >> >>>>>>> Joel Bernstein
>> >> >>>>>>> http://joelsolr.blogspot.com/
>> >> >>>>>>>
>> >> >>>>>>>
>> >> >>>>>>> _______________________
>> >> >>>>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com | My Free/Busy
>> >> >>>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
>> >> >>>>>>> This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
>> >> >>>>>>>
>> >> >
>> >> > --
>> >> > Uwe Schindler
>> >> > Achterdiek 19, 28357 Bremen
>> >> > https://www.thetaphi.de
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> >> For additional commands, e-mail: dev-help@lucene.apache.org
>> >>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: Failing gradle precommits [ In reply to ]
lucene at mikemccandless
Jan 11, 2021, 6:01 AM
Post #14 of 16 (900 views)
Permalink
+1 to fix precommit slowness! It is really depressing to run precommit on
my 128 core box and watch how slow it is :)

I'll try to add (read: open an issue!) a chart to our nightly benchmarks
tracking precommit time over time ...

Mike McCandless

http://blog.mikemccandless.com


On Fri, Jan 8, 2021 at 4:43 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:

> I don't remember, to be honest. I think javadocs, html linters - they
> all contribute. We could remove some of them (via -x) on github if
> they're too heavy.
>
> On Fri, Jan 8, 2021 at 9:08 PM Michael Sokolov <msokolov@gmail.com> wrote:
> >
> > Whoops! Well I guess we'll see. I wonder what other checks we are
> running now that's were not part of precommit, aside from spotless?
> >
> > On Fri, Jan 8, 2021, 2:28 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
> >>
> >> The switch to full check (minus tests) makes the "precommit" really
> >> heavy... it's around 14 minutes on my not-so-fancy machine. I'm
> >> curious if it's going to pass on github or timeout somehow.
> >>
> >> On Fri, Jan 8, 2021 at 8:26 PM Houston Putman <houstonputman@gmail.com>
> wrote:
> >> >
> >> > Yeah, that should work Dawid. I'll create a PR that tests it out.
> >> >
> >> > - Houston
> >> >
> >> > On Fri, Jan 8, 2021 at 2:02 PM Dawid Weiss <dawid.weiss@gmail.com>
> wrote:
> >> >>
> >> >> Can those jobs just run a sequence of two commands -
> >> >>
> >> >> ./gradlew localSettings
> >> >> ./gradlew check -x test
> >> >>
> >> >> This would solve the problem as proper JVM settings (tuned for the
> >> >> machine/ image it's running on) would be written and used on
> >> >> subsequent run.
> >> >>
> >> >> Dawid
> >> >>
> >> >> On Fri, Jan 8, 2021 at 7:44 PM Uwe Schindler <uwe@thetaphi.de>
> wrote:
> >> >> >
> >> >> > The problembcomes from the fact that Gradle sets a Xmx for itself
> in the settings file. Jenkins installs a settings file before.
> >> >> >
> >> >> > As every GitHub run is a clean checkout in new working dir, the
> settings never persist.
> >> >> >
> >> >> > IMHO, we should change the command line and pass JVM options to
> set heap size as it is written to the settings file.
> >> >> >
> >> >> > Uwe
> >> >> >
> >> >> > Am January 8, 2021 6:13:01 PM UTC schrieb David Smiley <
> dsmiley@apache.org>:
> >> >> >>
> >> >> >> Perhaps the OOMs are because
> .github/workflows/gradle-precommit.yml yesterday switched from doing
> "gradlew check -x test" to "gradlew precomit" ? CC Michael Sokolov
> >> >> >>
> >> >> >> ~ David Smiley
> >> >> >> Apache Lucene/Solr Search Developer
> >> >> >> http://www.linkedin.com/in/davidwsmiley
> >> >> >>
> >> >> >>
> >> >> >> On Fri, Jan 8, 2021 at 1:06 PM Timothy Potter <
> thelabdude@gmail.com> wrote:
> >> >> >>>
> >> >> >>> Same for my PR too ... OOMs about 14 minutes in ...
> >> >> >>>
> >> >> >>> On Fri, Jan 8, 2021 at 9:45 AM Houston Putman <
> houstonputman@gmail.com> wrote:
> >> >> >>>>
> >> >> >>>> Weirdly enough, Github PR precommit actions have started to
> OOM. Not sure if it's a github thing or something that changed on our end...
> >> >> >>>>
> >> >> >>>> On Fri, Jan 8, 2021 at 11:37 AM Joel Bernstein <
> joelsolr@gmail.com> wrote:
> >> >> >>>>>
> >> >> >>>>> It turned out to be this while I merged branches:
> >> >> >>>>>
> >> >> >>>>> warning: inexact rename detection was skipped due to too many
> files.
> >> >> >>>>>
> >> >> >>>>> warning: you may want to set your merge.renamelimit variable
> to at least 1639 and retry the command.
> >> >> >>>>>
> >> >> >>>>>
> >> >> >>>>> Joel Bernstein
> >> >> >>>>> http://joelsolr.blogspot.com/
> >> >> >>>>>
> >> >> >>>>>
> >> >> >>>>> On Fri, Jan 8, 2021 at 11:16 AM Joel Bernstein <
> joelsolr@gmail.com> wrote:
> >> >> >>>>>>
> >> >> >>>>>> Thanks Eric, I'll do a fresh clone, something must be out of
> wack with my local repo.
> >> >> >>>>>>
> >> >> >>>>>>
> >> >> >>>>>> Joel Bernstein
> >> >> >>>>>> http://joelsolr.blogspot.com/
> >> >> >>>>>>
> >> >> >>>>>>
> >> >> >>>>>> On Fri, Jan 8, 2021 at 10:55 AM Eric Pugh <
> epugh@opensourceconnections.com> wrote:
> >> >> >>>>>>>
> >> >> >>>>>>> It ran for me just fine. I *think* you may not be up to
> date, as dataimporthandler/ is no longer in master!
> >> >> >>>>>>>
> >> >> >>>>>>>
> >> >> >>>>>>> On Jan 8, 2021, at 10:08 AM, Joel Bernstein <
> joelsolr@gmail.com> wrote:
> >> >> >>>>>>>
> >> >> >>>>>>> I'm getting failing gradle precommits in master:
> >> >> >>>>>>>
> >> >> >>>>>>> > Task :solr:contrib:validateSourcePatterns FAILED
> >> >> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder.xml
> >> >> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSolrEntityProcessorEndToEnd.xml
> >> >> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestErrorHandling.xml
> >> >> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestScriptTransformer.xml
> >> >> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSqlEntityProcessor.xml
> >> >> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder2.xml
> >> >> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestZKPropertiesWriter.xml
> >> >> >>>>>>> tabs instead spaces:
> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler-extras/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestTikaEntityProcessor.xml
> >> >> >>>>>>>
> >> >> >>>>>>> FAILURE: Build failed with an exception.
> >> >> >>>>>>>
> >> >> >>>>>>> * Where:
> >> >> >>>>>>> Script
> '/Users/joelbernstein/committer/lucene-solr/gradle/validation/validate-source-patterns.gradle'
> line: 324
> >> >> >>>>>>>
> >> >> >>>>>>> * What went wrong:
> >> >> >>>>>>> Execution failed for task
> ':solr:contrib:validateSourcePatterns'.
> >> >> >>>>>>> > Found 8 violations in source files (tabs instead spaces).
> >> >> >>>>>>>
> >> >> >>>>>>>
> >> >> >>>>>>> Are others seeing this as well? I'm not seeing Jenkins
> emails about this.
> >> >> >>>>>>>
> >> >> >>>>>>>
> >> >> >>>>>>> Joel Bernstein
> >> >> >>>>>>> http://joelsolr.blogspot.com/
> >> >> >>>>>>>
> >> >> >>>>>>>
> >> >> >>>>>>> _______________________
> >> >> >>>>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC |
> 434.466.1467 | http://www.opensourceconnections.com | My Free/Busy
> >> >> >>>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
> >> >> >>>>>>> This e-mail and all contents, including attachments, is
> considered to be Company Confidential unless explicitly stated otherwise,
> regardless of whether attachments are marked as such.
> >> >> >>>>>>>
> >> >> >
> >> >> > --
> >> >> > Uwe Schindler
> >> >> > Achterdiek 19, 28357 Bremen
> >> >> > https://www.thetaphi.de
> >> >>
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >> >> For additional commands, e-mail: dev-help@lucene.apache.org
> >> >>
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> >> For additional commands, e-mail: dev-help@lucene.apache.org
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
Re: Failing gradle precommits [ In reply to ]
lucene at mikemccandless
Jan 11, 2021, 6:04 AM
Post #15 of 16 (900 views)
Permalink
OK I opened https://github.com/mikemccand/luceneutil/issues/96

Patches welcome!

Mike McCandless

http://blog.mikemccandless.com


On Mon, Jan 11, 2021 at 9:01 AM Michael McCandless <
lucene@mikemccandless.com> wrote:

> +1 to fix precommit slowness! It is really depressing to run precommit on
> my 128 core box and watch how slow it is :)
>
> I'll try to add (read: open an issue!) a chart to our nightly benchmarks
> tracking precommit time over time ...
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
>
> On Fri, Jan 8, 2021 at 4:43 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>
>> I don't remember, to be honest. I think javadocs, html linters - they
>> all contribute. We could remove some of them (via -x) on github if
>> they're too heavy.
>>
>> On Fri, Jan 8, 2021 at 9:08 PM Michael Sokolov <msokolov@gmail.com>
>> wrote:
>> >
>> > Whoops! Well I guess we'll see. I wonder what other checks we are
>> running now that's were not part of precommit, aside from spotless?
>> >
>> > On Fri, Jan 8, 2021, 2:28 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>> >>
>> >> The switch to full check (minus tests) makes the "precommit" really
>> >> heavy... it's around 14 minutes on my not-so-fancy machine. I'm
>> >> curious if it's going to pass on github or timeout somehow.
>> >>
>> >> On Fri, Jan 8, 2021 at 8:26 PM Houston Putman <houstonputman@gmail.com>
>> wrote:
>> >> >
>> >> > Yeah, that should work Dawid. I'll create a PR that tests it out.
>> >> >
>> >> > - Houston
>> >> >
>> >> > On Fri, Jan 8, 2021 at 2:02 PM Dawid Weiss <dawid.weiss@gmail.com>
>> wrote:
>> >> >>
>> >> >> Can those jobs just run a sequence of two commands -
>> >> >>
>> >> >> ./gradlew localSettings
>> >> >> ./gradlew check -x test
>> >> >>
>> >> >> This would solve the problem as proper JVM settings (tuned for the
>> >> >> machine/ image it's running on) would be written and used on
>> >> >> subsequent run.
>> >> >>
>> >> >> Dawid
>> >> >>
>> >> >> On Fri, Jan 8, 2021 at 7:44 PM Uwe Schindler <uwe@thetaphi.de>
>> wrote:
>> >> >> >
>> >> >> > The problembcomes from the fact that Gradle sets a Xmx for itself
>> in the settings file. Jenkins installs a settings file before.
>> >> >> >
>> >> >> > As every GitHub run is a clean checkout in new working dir, the
>> settings never persist.
>> >> >> >
>> >> >> > IMHO, we should change the command line and pass JVM options to
>> set heap size as it is written to the settings file.
>> >> >> >
>> >> >> > Uwe
>> >> >> >
>> >> >> > Am January 8, 2021 6:13:01 PM UTC schrieb David Smiley <
>> dsmiley@apache.org>:
>> >> >> >>
>> >> >> >> Perhaps the OOMs are because
>> .github/workflows/gradle-precommit.yml yesterday switched from doing
>> "gradlew check -x test" to "gradlew precomit" ? CC Michael Sokolov
>> >> >> >>
>> >> >> >> ~ David Smiley
>> >> >> >> Apache Lucene/Solr Search Developer
>> >> >> >> http://www.linkedin.com/in/davidwsmiley
>> >> >> >>
>> >> >> >>
>> >> >> >> On Fri, Jan 8, 2021 at 1:06 PM Timothy Potter <
>> thelabdude@gmail.com> wrote:
>> >> >> >>>
>> >> >> >>> Same for my PR too ... OOMs about 14 minutes in ...
>> >> >> >>>
>> >> >> >>> On Fri, Jan 8, 2021 at 9:45 AM Houston Putman <
>> houstonputman@gmail.com> wrote:
>> >> >> >>>>
>> >> >> >>>> Weirdly enough, Github PR precommit actions have started to
>> OOM. Not sure if it's a github thing or something that changed on our end...
>> >> >> >>>>
>> >> >> >>>> On Fri, Jan 8, 2021 at 11:37 AM Joel Bernstein <
>> joelsolr@gmail.com> wrote:
>> >> >> >>>>>
>> >> >> >>>>> It turned out to be this while I merged branches:
>> >> >> >>>>>
>> >> >> >>>>> warning: inexact rename detection was skipped due to too many
>> files.
>> >> >> >>>>>
>> >> >> >>>>> warning: you may want to set your merge.renamelimit variable
>> to at least 1639 and retry the command.
>> >> >> >>>>>
>> >> >> >>>>>
>> >> >> >>>>> Joel Bernstein
>> >> >> >>>>> http://joelsolr.blogspot.com/
>> >> >> >>>>>
>> >> >> >>>>>
>> >> >> >>>>> On Fri, Jan 8, 2021 at 11:16 AM Joel Bernstein <
>> joelsolr@gmail.com> wrote:
>> >> >> >>>>>>
>> >> >> >>>>>> Thanks Eric, I'll do a fresh clone, something must be out of
>> wack with my local repo.
>> >> >> >>>>>>
>> >> >> >>>>>>
>> >> >> >>>>>> Joel Bernstein
>> >> >> >>>>>> http://joelsolr.blogspot.com/
>> >> >> >>>>>>
>> >> >> >>>>>>
>> >> >> >>>>>> On Fri, Jan 8, 2021 at 10:55 AM Eric Pugh <
>> epugh@opensourceconnections.com> wrote:
>> >> >> >>>>>>>
>> >> >> >>>>>>> It ran for me just fine. I *think* you may not be up to
>> date, as dataimporthandler/ is no longer in master!
>> >> >> >>>>>>>
>> >> >> >>>>>>>
>> >> >> >>>>>>> On Jan 8, 2021, at 10:08 AM, Joel Bernstein <
>> joelsolr@gmail.com> wrote:
>> >> >> >>>>>>>
>> >> >> >>>>>>> I'm getting failing gradle precommits in master:
>> >> >> >>>>>>>
>> >> >> >>>>>>> > Task :solr:contrib:validateSourcePatterns FAILED
>> >> >> >>>>>>> tabs instead spaces:
>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder.xml
>> >> >> >>>>>>> tabs instead spaces:
>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSolrEntityProcessorEndToEnd.xml
>> >> >> >>>>>>> tabs instead spaces:
>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestErrorHandling.xml
>> >> >> >>>>>>> tabs instead spaces:
>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestScriptTransformer.xml
>> >> >> >>>>>>> tabs instead spaces:
>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSqlEntityProcessor.xml
>> >> >> >>>>>>> tabs instead spaces:
>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder2.xml
>> >> >> >>>>>>> tabs instead spaces:
>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestZKPropertiesWriter.xml
>> >> >> >>>>>>> tabs instead spaces:
>> /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler-extras/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestTikaEntityProcessor.xml
>> >> >> >>>>>>>
>> >> >> >>>>>>> FAILURE: Build failed with an exception.
>> >> >> >>>>>>>
>> >> >> >>>>>>> * Where:
>> >> >> >>>>>>> Script
>> '/Users/joelbernstein/committer/lucene-solr/gradle/validation/validate-source-patterns.gradle'
>> line: 324
>> >> >> >>>>>>>
>> >> >> >>>>>>> * What went wrong:
>> >> >> >>>>>>> Execution failed for task
>> ':solr:contrib:validateSourcePatterns'.
>> >> >> >>>>>>> > Found 8 violations in source files (tabs instead spaces).
>> >> >> >>>>>>>
>> >> >> >>>>>>>
>> >> >> >>>>>>> Are others seeing this as well? I'm not seeing Jenkins
>> emails about this.
>> >> >> >>>>>>>
>> >> >> >>>>>>>
>> >> >> >>>>>>> Joel Bernstein
>> >> >> >>>>>>> http://joelsolr.blogspot.com/
>> >> >> >>>>>>>
>> >> >> >>>>>>>
>> >> >> >>>>>>> _______________________
>> >> >> >>>>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC |
>> 434.466.1467 | http://www.opensourceconnections.com | My Free/Busy
>> >> >> >>>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
>> >> >> >>>>>>> This e-mail and all contents, including attachments, is
>> considered to be Company Confidential unless explicitly stated otherwise,
>> regardless of whether attachments are marked as such.
>> >> >> >>>>>>>
>> >> >> >
>> >> >> > --
>> >> >> > Uwe Schindler
>> >> >> > Achterdiek 19, 28357 Bremen
>> >> >> > https://www.thetaphi.de
>> >> >>
>> >> >>
>> ---------------------------------------------------------------------
>> >> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> >> >> For additional commands, e-mail: dev-help@lucene.apache.org
>> >> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> >> For additional commands, e-mail: dev-help@lucene.apache.org
>> >>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>>
Re: Failing gradle precommits [ In reply to ]
dawid.weiss at gmail
Jan 11, 2021, 6:46 AM
Post #16 of 16 (900 views)
Permalink
> +1 to fix precommit slowness!

It's doing a *lot* of checks, Mike... So the tradeoff for disabling a
precommit is to either push it later to a CI run or to
skip a check that was otherwise doing something.

> It is really depressing to run precommit on my 128 core box and watch how slow it is :)

What are your generated gradle settings? I have a slightly less beefy
box (ryzen, 64 threads) and
precommit takes ~2mins.

D.


>
> I'll try to add (read: open an issue!) a chart to our nightly benchmarks tracking precommit time over time ...
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
>
> On Fri, Jan 8, 2021 at 4:43 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>>
>> I don't remember, to be honest. I think javadocs, html linters - they
>> all contribute. We could remove some of them (via -x) on github if
>> they're too heavy.
>>
>> On Fri, Jan 8, 2021 at 9:08 PM Michael Sokolov <msokolov@gmail.com> wrote:
>> >
>> > Whoops! Well I guess we'll see. I wonder what other checks we are running now that's were not part of precommit, aside from spotless?
>> >
>> > On Fri, Jan 8, 2021, 2:28 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>> >>
>> >> The switch to full check (minus tests) makes the "precommit" really
>> >> heavy... it's around 14 minutes on my not-so-fancy machine. I'm
>> >> curious if it's going to pass on github or timeout somehow.
>> >>
>> >> On Fri, Jan 8, 2021 at 8:26 PM Houston Putman <houstonputman@gmail.com> wrote:
>> >> >
>> >> > Yeah, that should work Dawid. I'll create a PR that tests it out.
>> >> >
>> >> > - Houston
>> >> >
>> >> > On Fri, Jan 8, 2021 at 2:02 PM Dawid Weiss <dawid.weiss@gmail.com> wrote:
>> >> >>
>> >> >> Can those jobs just run a sequence of two commands -
>> >> >>
>> >> >> ./gradlew localSettings
>> >> >> ./gradlew check -x test
>> >> >>
>> >> >> This would solve the problem as proper JVM settings (tuned for the
>> >> >> machine/ image it's running on) would be written and used on
>> >> >> subsequent run.
>> >> >>
>> >> >> Dawid
>> >> >>
>> >> >> On Fri, Jan 8, 2021 at 7:44 PM Uwe Schindler <uwe@thetaphi.de> wrote:
>> >> >> >
>> >> >> > The problembcomes from the fact that Gradle sets a Xmx for itself in the settings file. Jenkins installs a settings file before.
>> >> >> >
>> >> >> > As every GitHub run is a clean checkout in new working dir, the settings never persist.
>> >> >> >
>> >> >> > IMHO, we should change the command line and pass JVM options to set heap size as it is written to the settings file.
>> >> >> >
>> >> >> > Uwe
>> >> >> >
>> >> >> > Am January 8, 2021 6:13:01 PM UTC schrieb David Smiley <dsmiley@apache.org>:
>> >> >> >>
>> >> >> >> Perhaps the OOMs are because .github/workflows/gradle-precommit.yml yesterday switched from doing "gradlew check -x test" to "gradlew precomit" ? CC Michael Sokolov
>> >> >> >>
>> >> >> >> ~ David Smiley
>> >> >> >> Apache Lucene/Solr Search Developer
>> >> >> >> http://www.linkedin.com/in/davidwsmiley
>> >> >> >>
>> >> >> >>
>> >> >> >> On Fri, Jan 8, 2021 at 1:06 PM Timothy Potter <thelabdude@gmail.com> wrote:
>> >> >> >>>
>> >> >> >>> Same for my PR too ... OOMs about 14 minutes in ...
>> >> >> >>>
>> >> >> >>> On Fri, Jan 8, 2021 at 9:45 AM Houston Putman <houstonputman@gmail.com> wrote:
>> >> >> >>>>
>> >> >> >>>> Weirdly enough, Github PR precommit actions have started to OOM. Not sure if it's a github thing or something that changed on our end...
>> >> >> >>>>
>> >> >> >>>> On Fri, Jan 8, 2021 at 11:37 AM Joel Bernstein <joelsolr@gmail.com> wrote:
>> >> >> >>>>>
>> >> >> >>>>> It turned out to be this while I merged branches:
>> >> >> >>>>>
>> >> >> >>>>> warning: inexact rename detection was skipped due to too many files.
>> >> >> >>>>>
>> >> >> >>>>> warning: you may want to set your merge.renamelimit variable to at least 1639 and retry the command.
>> >> >> >>>>>
>> >> >> >>>>>
>> >> >> >>>>> Joel Bernstein
>> >> >> >>>>> http://joelsolr.blogspot.com/
>> >> >> >>>>>
>> >> >> >>>>>
>> >> >> >>>>> On Fri, Jan 8, 2021 at 11:16 AM Joel Bernstein <joelsolr@gmail.com> wrote:
>> >> >> >>>>>>
>> >> >> >>>>>> Thanks Eric, I'll do a fresh clone, something must be out of wack with my local repo.
>> >> >> >>>>>>
>> >> >> >>>>>>
>> >> >> >>>>>> Joel Bernstein
>> >> >> >>>>>> http://joelsolr.blogspot.com/
>> >> >> >>>>>>
>> >> >> >>>>>>
>> >> >> >>>>>> On Fri, Jan 8, 2021 at 10:55 AM Eric Pugh <epugh@opensourceconnections.com> wrote:
>> >> >> >>>>>>>
>> >> >> >>>>>>> It ran for me just fine. I *think* you may not be up to date, as dataimporthandler/ is no longer in master!
>> >> >> >>>>>>>
>> >> >> >>>>>>>
>> >> >> >>>>>>> On Jan 8, 2021, at 10:08 AM, Joel Bernstein <joelsolr@gmail.com> wrote:
>> >> >> >>>>>>>
>> >> >> >>>>>>> I'm getting failing gradle precommits in master:
>> >> >> >>>>>>>
>> >> >> >>>>>>> > Task :solr:contrib:validateSourcePatterns FAILED
>> >> >> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder.xml
>> >> >> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSolrEntityProcessorEndToEnd.xml
>> >> >> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestErrorHandling.xml
>> >> >> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestScriptTransformer.xml
>> >> >> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestSqlEntityProcessor.xml
>> >> >> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestDocBuilder2.xml
>> >> >> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestZKPropertiesWriter.xml
>> >> >> >>>>>>> tabs instead spaces: /Users/joelbernstein/committer/lucene-solr/solr/contrib/dataimporthandler-extras/build/test-results/test/TEST-org.apache.solr.handler.dataimport.TestTikaEntityProcessor.xml
>> >> >> >>>>>>>
>> >> >> >>>>>>> FAILURE: Build failed with an exception.
>> >> >> >>>>>>>
>> >> >> >>>>>>> * Where:
>> >> >> >>>>>>> Script '/Users/joelbernstein/committer/lucene-solr/gradle/validation/validate-source-patterns.gradle' line: 324
>> >> >> >>>>>>>
>> >> >> >>>>>>> * What went wrong:
>> >> >> >>>>>>> Execution failed for task ':solr:contrib:validateSourcePatterns'.
>> >> >> >>>>>>> > Found 8 violations in source files (tabs instead spaces).
>> >> >> >>>>>>>
>> >> >> >>>>>>>
>> >> >> >>>>>>> Are others seeing this as well? I'm not seeing Jenkins emails about this.
>> >> >> >>>>>>>
>> >> >> >>>>>>>
>> >> >> >>>>>>> Joel Bernstein
>> >> >> >>>>>>> http://joelsolr.blogspot.com/
>> >> >> >>>>>>>
>> >> >> >>>>>>>
>> >> >> >>>>>>> _______________________
>> >> >> >>>>>>> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com | My Free/Busy
>> >> >> >>>>>>> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed
>> >> >> >>>>>>> This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
>> >> >> >>>>>>>
>> >> >> >
>> >> >> > --
>> >> >> > Uwe Schindler
>> >> >> > Achterdiek 19, 28357 Bremen
>> >> >> > https://www.thetaphi.de
>> >> >>
>> >> >> ---------------------------------------------------------------------
>> >> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> >> >> For additional commands, e-mail: dev-help@lucene.apache.org
>> >> >>
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> >> For additional commands, e-mail: dev-help@lucene.apache.org
>> >>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

©2024 GT.net. A Gossamer Threads company.
5th Floor, 455 Granville St., Vancouver, BC V6C 1T1, Canada | Legal