Mailing List Archive

Re: [jira] [Commented] (SOLR-14151) Make schema components load from packages
I have to take it back a little. Hoss’ rollups show these tests failing 100% of the time, but they pass on my machine locally at least some of the time…. IDK quite why there’s a difference.

Noble:

Let me know if I can help, I can at least beast any fix.

Erick

> On Sep 18, 2020, at 2:13 PM, Ishan Chattopadhyaya (Jira) <jira@apache.org> wrote:
>
>
> [ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198482#comment-17198482 ]
>
> Ishan Chattopadhyaya commented on SOLR-14151:
> ---------------------------------------------
>
> +1 on reverting all traces of this work immediately, and committing back only when there are no failures. We can request Uwe to enable Jenkins builds on a branch where we iterate on this until we are able to merge to master. Such drastic test failure situation is unacceptable.
>
>> Make schema components load from packages
>> -----------------------------------------
>>
>> Key: SOLR-14151
>> URL: https://issues.apache.org/jira/browse/SOLR-14151
>> Project: Solr
>> Issue Type: Sub-task
>> Reporter: Noble Paul
>> Assignee: Noble Paul
>> Priority: Major
>> Labels: packagemanager
>> Fix For: 8.7
>>
>> Time Spent: 12h 50m
>> Remaining Estimate: 0h
>>
>> Example:
>> {code:xml}
>> <fieldType name="mytype1" class="pkg1:my.pkg.FieldTypeImpl">
>> <analyzer type="index">
>> <tokenizer class="pkg2:my.pkg2.MyTokenizerFactory"/>
>> <filter class="pkg2:my.pkg3.MyFilterFactory" generateWordParts="1" generateNumberParts="0" catenateWords="0"
>> catenateNumbers="0" catenateAll="0"/>
>> <filter class="solr.LowerCaseFilterFactory"/>
>> <filter class="solr.FlattenGraphFilterFactory"/>
>> </analyzer>
>> </fieldType>
>> {code}
>> * When a package is updated, the entire {{IndexSchema}} object is refreshed, but the SolrCore object is not reloaded
>> * Any component can be prefixed with the package name
>> * The semantics of loading plugins remain the same as that of the components in {{solrconfig.xml}}
>> * Plugins can be registered using schema API
>
>
>
> --
> This message was sent by Atlassian Jira
> (v8.3.4#803005)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
> For additional commands, e-mail: issues-help@lucene.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (SOLR-14151) Make schema components load from packages [ In reply to ]
I'm beasting changes so many times and I can't see the failures happening

I'm wondering if we should just disable the
TestPackages@testSchemaPlugins() or revert the changes wholesale

On Sat, Sep 19, 2020 at 10:44 PM Erick Erickson <erickerickson@gmail.com> wrote:
>
> I have to take it back a little. Hoss’ rollups show these tests failing 100% of the time, but they pass on my machine locally at least some of the time…. IDK quite why there’s a difference.
>
> Noble:
>
> Let me know if I can help, I can at least beast any fix.
>
> Erick
>
> > On Sep 18, 2020, at 2:13 PM, Ishan Chattopadhyaya (Jira) <jira@apache.org> wrote:
> >
> >
> > [ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198482#comment-17198482 ]
> >
> > Ishan Chattopadhyaya commented on SOLR-14151:
> > ---------------------------------------------
> >
> > +1 on reverting all traces of this work immediately, and committing back only when there are no failures. We can request Uwe to enable Jenkins builds on a branch where we iterate on this until we are able to merge to master. Such drastic test failure situation is unacceptable.
> >
> >> Make schema components load from packages
> >> -----------------------------------------
> >>
> >> Key: SOLR-14151
> >> URL: https://issues.apache.org/jira/browse/SOLR-14151
> >> Project: Solr
> >> Issue Type: Sub-task
> >> Reporter: Noble Paul
> >> Assignee: Noble Paul
> >> Priority: Major
> >> Labels: packagemanager
> >> Fix For: 8.7
> >>
> >> Time Spent: 12h 50m
> >> Remaining Estimate: 0h
> >>
> >> Example:
> >> {code:xml}
> >> <fieldType name="mytype1" class="pkg1:my.pkg.FieldTypeImpl">
> >> <analyzer type="index">
> >> <tokenizer class="pkg2:my.pkg2.MyTokenizerFactory"/>
> >> <filter class="pkg2:my.pkg3.MyFilterFactory" generateWordParts="1" generateNumberParts="0" catenateWords="0"
> >> catenateNumbers="0" catenateAll="0"/>
> >> <filter class="solr.LowerCaseFilterFactory"/>
> >> <filter class="solr.FlattenGraphFilterFactory"/>
> >> </analyzer>
> >> </fieldType>
> >> {code}
> >> * When a package is updated, the entire {{IndexSchema}} object is refreshed, but the SolrCore object is not reloaded
> >> * Any component can be prefixed with the package name
> >> * The semantics of loading plugins remain the same as that of the components in {{solrconfig.xml}}
> >> * Plugins can be registered using schema API
> >
> >
> >
> > --
> > This message was sent by Atlassian Jira
> > (v8.3.4#803005)
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: issues-help@lucene.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>


--
-----------------------------------------------------
Noble Paul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (SOLR-14151) Make schema components load from packages [ In reply to ]
Yeah, I can't seem to get it to fail on demand either. I can look this
evening at some of the Jenkins failures to see if there's a pattern or
machine or whatever...

On Sat, Sep 19, 2020, 09:31 Noble Paul <noble.paul@gmail.com> wrote:

> I'm beasting changes so many times and I can't see the failures happening
>
> I'm wondering if we should just disable the
> TestPackages@testSchemaPlugins() or revert the changes wholesale
>
> On Sat, Sep 19, 2020 at 10:44 PM Erick Erickson <erickerickson@gmail.com>
> wrote:
> >
> > I have to take it back a little. Hoss’ rollups show these tests failing
> 100% of the time, but they pass on my machine locally at least some of the
> time…. IDK quite why there’s a difference.
> >
> > Noble:
> >
> > Let me know if I can help, I can at least beast any fix.
> >
> > Erick
> >
> > > On Sep 18, 2020, at 2:13 PM, Ishan Chattopadhyaya (Jira) <
> jira@apache.org> wrote:
> > >
> > >
> > > [
> https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198482#comment-17198482
> ]
> > >
> > > Ishan Chattopadhyaya commented on SOLR-14151:
> > > ---------------------------------------------
> > >
> > > +1 on reverting all traces of this work immediately, and committing
> back only when there are no failures. We can request Uwe to enable Jenkins
> builds on a branch where we iterate on this until we are able to merge to
> master. Such drastic test failure situation is unacceptable.
> > >
> > >> Make schema components load from packages
> > >> -----------------------------------------
> > >>
> > >> Key: SOLR-14151
> > >> URL: https://issues.apache.org/jira/browse/SOLR-14151
> > >> Project: Solr
> > >> Issue Type: Sub-task
> > >> Reporter: Noble Paul
> > >> Assignee: Noble Paul
> > >> Priority: Major
> > >> Labels: packagemanager
> > >> Fix For: 8.7
> > >>
> > >> Time Spent: 12h 50m
> > >> Remaining Estimate: 0h
> > >>
> > >> Example:
> > >> {code:xml}
> > >> <fieldType name="mytype1" class="pkg1:my.pkg.FieldTypeImpl">
> > >> <analyzer type="index">
> > >> <tokenizer class="pkg2:my.pkg2.MyTokenizerFactory"/>
> > >> <filter class="pkg2:my.pkg3.MyFilterFactory"
> generateWordParts="1" generateNumberParts="0" catenateWords="0"
> > >> catenateNumbers="0" catenateAll="0"/>
> > >> <filter class="solr.LowerCaseFilterFactory"/>
> > >> <filter class="solr.FlattenGraphFilterFactory"/>
> > >> </analyzer>
> > >> </fieldType>
> > >> {code}
> > >> * When a package is updated, the entire {{IndexSchema}} object is
> refreshed, but the SolrCore object is not reloaded
> > >> * Any component can be prefixed with the package name
> > >> * The semantics of loading plugins remain the same as that of the
> components in {{solrconfig.xml}}
> > >> * Plugins can be registered using schema API
> > >
> > >
> > >
> > > --
> > > This message was sent by Atlassian Jira
> > > (v8.3.4#803005)
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
> > > For additional commands, e-mail: issues-help@lucene.apache.org
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: dev-help@lucene.apache.org
> >
>
>
> --
> -----------------------------------------------------
> Noble Paul
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>
Re: [jira] [Commented] (SOLR-14151) Make schema components load from packages [ In reply to ]
I beated this test for 100 repetitions . No failures. it's frustrating

On Sun, Sep 20, 2020 at 12:33 AM Erick Erickson <erickerickson@gmail.com> wrote:
>
> Yeah, I can't seem to get it to fail on demand either. I can look this evening at some of the Jenkins failures to see if there's a pattern or machine or whatever...
>
> On Sat, Sep 19, 2020, 09:31 Noble Paul <noble.paul@gmail.com> wrote:
>>
>> I'm beasting changes so many times and I can't see the failures happening
>>
>> I'm wondering if we should just disable the
>> TestPackages@testSchemaPlugins() or revert the changes wholesale
>>
>> On Sat, Sep 19, 2020 at 10:44 PM Erick Erickson <erickerickson@gmail.com> wrote:
>> >
>> > I have to take it back a little. Hoss’ rollups show these tests failing 100% of the time, but they pass on my machine locally at least some of the time…. IDK quite why there’s a difference.
>> >
>> > Noble:
>> >
>> > Let me know if I can help, I can at least beast any fix.
>> >
>> > Erick
>> >
>> > > On Sep 18, 2020, at 2:13 PM, Ishan Chattopadhyaya (Jira) <jira@apache.org> wrote:
>> > >
>> > >
>> > > [ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198482#comment-17198482 ]
>> > >
>> > > Ishan Chattopadhyaya commented on SOLR-14151:
>> > > ---------------------------------------------
>> > >
>> > > +1 on reverting all traces of this work immediately, and committing back only when there are no failures. We can request Uwe to enable Jenkins builds on a branch where we iterate on this until we are able to merge to master. Such drastic test failure situation is unacceptable.
>> > >
>> > >> Make schema components load from packages
>> > >> -----------------------------------------
>> > >>
>> > >> Key: SOLR-14151
>> > >> URL: https://issues.apache.org/jira/browse/SOLR-14151
>> > >> Project: Solr
>> > >> Issue Type: Sub-task
>> > >> Reporter: Noble Paul
>> > >> Assignee: Noble Paul
>> > >> Priority: Major
>> > >> Labels: packagemanager
>> > >> Fix For: 8.7
>> > >>
>> > >> Time Spent: 12h 50m
>> > >> Remaining Estimate: 0h
>> > >>
>> > >> Example:
>> > >> {code:xml}
>> > >> <fieldType name="mytype1" class="pkg1:my.pkg.FieldTypeImpl">
>> > >> <analyzer type="index">
>> > >> <tokenizer class="pkg2:my.pkg2.MyTokenizerFactory"/>
>> > >> <filter class="pkg2:my.pkg3.MyFilterFactory" generateWordParts="1" generateNumberParts="0" catenateWords="0"
>> > >> catenateNumbers="0" catenateAll="0"/>
>> > >> <filter class="solr.LowerCaseFilterFactory"/>
>> > >> <filter class="solr.FlattenGraphFilterFactory"/>
>> > >> </analyzer>
>> > >> </fieldType>
>> > >> {code}
>> > >> * When a package is updated, the entire {{IndexSchema}} object is refreshed, but the SolrCore object is not reloaded
>> > >> * Any component can be prefixed with the package name
>> > >> * The semantics of loading plugins remain the same as that of the components in {{solrconfig.xml}}
>> > >> * Plugins can be registered using schema API
>> > >
>> > >
>> > >
>> > > --
>> > > This message was sent by Atlassian Jira
>> > > (v8.3.4#803005)
>> > >
>> > > ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
>> > > For additional commands, e-mail: issues-help@lucene.apache.org
>> > >
>> >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> > For additional commands, e-mail: dev-help@lucene.apache.org
>> >
>>
>>
>> --
>> -----------------------------------------------------
>> Noble Paul
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>


--
-----------------------------------------------------
Noble Paul

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: [jira] [Commented] (SOLR-14151) Make schema components load from packages [ In reply to ]
I can get this to fail fairly regularly on 8x, here’s one:

ant test -Dtestcase=TestPackages -Dtests.multiplier=2 -Dtests.slow=true -Dtests.locale=et-EE -Dtests.timezone=Europe/Mariehamn -Dtests.asserts=true -Dtests.file.encoding=UTF-8

I tried this on master with equivalent params and it passed 100 times. I hate these...

> On Sep 19, 2020, at 9:24 PM, Noble Paul <noble.paul@gmail.com> wrote:
>
> I beated this test for 100 repetitions . No failures. it's frustrating
>
> On Sun, Sep 20, 2020 at 12:33 AM Erick Erickson <erickerickson@gmail.com> wrote:
>>
>> Yeah, I can't seem to get it to fail on demand either. I can look this evening at some of the Jenkins failures to see if there's a pattern or machine or whatever...
>>
>> On Sat, Sep 19, 2020, 09:31 Noble Paul <noble.paul@gmail.com> wrote:
>>>
>>> I'm beasting changes so many times and I can't see the failures happening
>>>
>>> I'm wondering if we should just disable the
>>> TestPackages@testSchemaPlugins() or revert the changes wholesale
>>>
>>> On Sat, Sep 19, 2020 at 10:44 PM Erick Erickson <erickerickson@gmail.com> wrote:
>>>>
>>>> I have to take it back a little. Hoss’ rollups show these tests failing 100% of the time, but they pass on my machine locally at least some of the time…. IDK quite why there’s a difference.
>>>>
>>>> Noble:
>>>>
>>>> Let me know if I can help, I can at least beast any fix.
>>>>
>>>> Erick
>>>>
>>>>> On Sep 18, 2020, at 2:13 PM, Ishan Chattopadhyaya (Jira) <jira@apache.org> wrote:
>>>>>
>>>>>
>>>>> [ https://issues.apache.org/jira/browse/SOLR-14151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198482#comment-17198482 ]
>>>>>
>>>>> Ishan Chattopadhyaya commented on SOLR-14151:
>>>>> ---------------------------------------------
>>>>>
>>>>> +1 on reverting all traces of this work immediately, and committing back only when there are no failures. We can request Uwe to enable Jenkins builds on a branch where we iterate on this until we are able to merge to master. Such drastic test failure situation is unacceptable.
>>>>>
>>>>>> Make schema components load from packages
>>>>>> -----------------------------------------
>>>>>>
>>>>>> Key: SOLR-14151
>>>>>> URL: https://issues.apache.org/jira/browse/SOLR-14151
>>>>>> Project: Solr
>>>>>> Issue Type: Sub-task
>>>>>> Reporter: Noble Paul
>>>>>> Assignee: Noble Paul
>>>>>> Priority: Major
>>>>>> Labels: packagemanager
>>>>>> Fix For: 8.7
>>>>>>
>>>>>> Time Spent: 12h 50m
>>>>>> Remaining Estimate: 0h
>>>>>>
>>>>>> Example:
>>>>>> {code:xml}
>>>>>> <fieldType name="mytype1" class="pkg1:my.pkg.FieldTypeImpl">
>>>>>> <analyzer type="index">
>>>>>> <tokenizer class="pkg2:my.pkg2.MyTokenizerFactory"/>
>>>>>> <filter class="pkg2:my.pkg3.MyFilterFactory" generateWordParts="1" generateNumberParts="0" catenateWords="0"
>>>>>> catenateNumbers="0" catenateAll="0"/>
>>>>>> <filter class="solr.LowerCaseFilterFactory"/>
>>>>>> <filter class="solr.FlattenGraphFilterFactory"/>
>>>>>> </analyzer>
>>>>>> </fieldType>
>>>>>> {code}
>>>>>> * When a package is updated, the entire {{IndexSchema}} object is refreshed, but the SolrCore object is not reloaded
>>>>>> * Any component can be prefixed with the package name
>>>>>> * The semantics of loading plugins remain the same as that of the components in {{solrconfig.xml}}
>>>>>> * Plugins can be registered using schema API
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> This message was sent by Atlassian Jira
>>>>> (v8.3.4#803005)
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
>>>>> For additional commands, e-mail: issues-help@lucene.apache.org
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>>
>>>
>>>
>>> --
>>> -----------------------------------------------------
>>> Noble Paul
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>
>
> --
> -----------------------------------------------------
> Noble Paul
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org