Mailing List Archive

[PATCH] Standard indentation of arguments
Standard indentation of arguments.
I use right blank space to displace the last table, in order to make the arguments alining. For example:

old:
extern void test_fun(struct list_head *new,
struct list_head *prev,
struct list_head *next);
new:
extern void test_fun(struct list_head *new,
struct list_head *prev,
struct list_head *next);

Signed-off-by: Jianjun Kong <kongjianjun@gmail.com>
---
include/linux/list.h | 27 ++++++++++++++-------------
1 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/include/linux/list.h b/include/linux/list.h
index 08cf4f6..6d16696 100644
--- a/include/linux/list.h
+++ b/include/linux/list.h
@@ -49,8 +49,8 @@ static inline void __list_add(struct list_head *new,
}
#else
extern void __list_add(struct list_head *new,
- struct list_head *prev,
- struct list_head *next);
+ struct list_head *prev,
+ struct list_head *next);
#endif

/**
@@ -91,7 +91,8 @@ static inline void list_add_tail(struct list_head *new, struct list_head *head)
* the prev/next entries already!
*/
static inline void __list_add_rcu(struct list_head * new,
- struct list_head * prev, struct list_head * next)
+ struct list_head * prev,
+ struct list_head * next)
{
new->next = next;
new->prev = prev;
@@ -138,7 +139,7 @@ static inline void list_add_rcu(struct list_head *new, struct list_head *head)
* list_for_each_entry_rcu().
*/
static inline void list_add_tail_rcu(struct list_head *new,
- struct list_head *head)
+ struct list_head *head)
{
__list_add_rcu(new, head->prev, head);
}
@@ -220,7 +221,7 @@ static inline void list_replace(struct list_head *old,
}

static inline void list_replace_init(struct list_head *old,
- struct list_head *new)
+ struct list_head *new)
{
list_replace(old, new);
INIT_LIST_HEAD(old);
@@ -235,7 +236,7 @@ static inline void list_replace_init(struct list_head *old,
* Note: @old should not be empty.
*/
static inline void list_replace_rcu(struct list_head *old,
- struct list_head *new)
+ struct list_head *new)
{
new->next = old->next;
new->prev = old->prev;
@@ -284,7 +285,7 @@ static inline void list_move_tail(struct list_head *list,
* @head: the head of the list
*/
static inline int list_is_last(const struct list_head *list,
- const struct list_head *head)
+ const struct list_head *head)
{
return list->next == head;
}
@@ -346,7 +347,7 @@ static inline void __list_splice(const struct list_head *list,
* @head: the place to add it in the first list.
*/
static inline void list_splice(const struct list_head *list,
- struct list_head *head)
+ struct list_head *head)
{
if (!list_empty(list))
__list_splice(list, head);
@@ -696,7 +697,7 @@ struct hlist_node {
};

#define HLIST_HEAD_INIT { .first = NULL }
-#define HLIST_HEAD(name) struct hlist_head name = { .first = NULL }
+#define HLIST_HEAD(name) struct hlist_head name = { .first = NULL }
#define INIT_HLIST_HEAD(ptr) ((ptr)->first = NULL)
static inline void INIT_HLIST_NODE(struct hlist_node *h)
{
@@ -771,7 +772,7 @@ static inline void hlist_del_init(struct hlist_node *n)
* The @old entry will be replaced with the @new entry atomically.
*/
static inline void hlist_replace_rcu(struct hlist_node *old,
- struct hlist_node *new)
+ struct hlist_node *new)
{
struct hlist_node *next = old->next;

@@ -815,7 +816,7 @@ static inline void hlist_add_head(struct hlist_node *n, struct hlist_head *h)
* list-traversal primitive must be guarded by rcu_read_lock().
*/
static inline void hlist_add_head_rcu(struct hlist_node *n,
- struct hlist_head *h)
+ struct hlist_head *h)
{
struct hlist_node *first = h->first;
n->next = first;
@@ -828,7 +829,7 @@ static inline void hlist_add_head_rcu(struct hlist_node *n,

/* next must be != NULL */
static inline void hlist_add_before(struct hlist_node *n,
- struct hlist_node *next)
+ struct hlist_node *next)
{
n->pprev = next->pprev;
n->next = next;
@@ -837,7 +838,7 @@ static inline void hlist_add_before(struct hlist_node *n,
}

static inline void hlist_add_after(struct hlist_node *n,
- struct hlist_node *next)
+ struct hlist_node *next)
{
next->next = n->next;
n->next = next;
--
1.5.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Standard indentation of arguments [ In reply to ]
On 05/21/2008 07:58 AM, Jianjun Kong wrote:
> Standard indentation of arguments.
> I use right blank space to displace the last table, in order to make the arguments alining. For example:
>
> old:
> extern void test_fun(struct list_head *new,
> struct list_head *prev,
> struct list_head *next);
> new:
> extern void test_fun(struct list_head *new,
> struct list_head *prev,
> struct list_head *next);

I think, there is no "standard" on this. I personally do prefer indentation by tabs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Standard indentation of arguments [ In reply to ]
Jiri Slaby wrote:
> On 05/21/2008 07:58 AM, Jianjun Kong wrote:
>> Standard indentation of arguments.
>> I use right blank space to displace the last table, in order to make
>> the arguments alining.
>
> I think, there is no "standard" on this. I personally do prefer
> indentation by tabs.

So do I, but that pales compared to how annoying I find patches that can
best be described as anal-retentive. Let the person who writes the code
decide how to lay it out.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/