Mailing List Archive: [PATCH] memcg: use helper macro FLUSH

[PATCH] memcg: use helper macro FLUSH_TIME

Jun 3, 2023, 1:05 AM

Post #1 of 5 (36 views)

Use helper macro FLUSH_TIME to indicate the flush time to improve the
readability a bit. No functional change intended.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index d8569594239c..f204c9f2e69c 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -5397,7 +5397,7 @@ static int mem_cgroup_css_online(struct cgroup_subsys_state *css)

if (unlikely(mem_cgroup_is_root(memcg)))
queue_delayed_work(system_unbound_wq, &stats_flush_dwork,
- 2UL*HZ);
+ FLUSH_TIME);
lru_gen_online_memcg(memcg);
return 0;
offline_kmem:
--
2.27.0

Re: [PATCH] memcg: use helper macro FLUSH_TIME [ In reply to ]

shakeelb at google

Jun 3, 2023, 1:05 AM

Post #2 of 5 (36 views)

Permalink

On Sat, Jun 3, 2023 at 12:21?AM Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> Use helper macro FLUSH_TIME to indicate the flush time to improve the
> readability a bit. No functional change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Acked-by: Shakeel Butt <shakeelb@google.com>

Re: [PATCH] memcg: use helper macro FLUSH_TIME [ In reply to ]

muchun.song at linux

Jun 3, 2023, 4:15 AM

Post #3 of 5 (36 views)

Permalink

> On Jun 3, 2023, at 15:21, Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> Use helper macro FLUSH_TIME to indicate the flush time to improve the
> readability a bit. No functional change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks

Re: [PATCH] memcg: use helper macro FLUSH_TIME [ In reply to ]

david at redhat

Jun 5, 2023, 6:15 AM

Post #4 of 5 (36 views)

Permalink

On 03.06.23 09:21, Miaohe Lin wrote:
> Use helper macro FLUSH_TIME to indicate the flush time to improve the
> readability a bit. No functional change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/memcontrol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index d8569594239c..f204c9f2e69c 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -5397,7 +5397,7 @@ static int mem_cgroup_css_online(struct cgroup_subsys_state *css)
>
> if (unlikely(mem_cgroup_is_root(memcg)))
> queue_delayed_work(system_unbound_wq, &stats_flush_dwork,
> - 2UL*HZ);
> + FLUSH_TIME);
> lru_gen_online_memcg(memcg);
> return 0;
> offline_kmem:

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Cheers,

David / dhildenb

Re: [PATCH] memcg: use helper macro FLUSH_TIME [ In reply to ]

roman.gushchin at linux

Jun 5, 2023, 6:15 PM

Post #5 of 5 (36 views)

Permalink

On Sat, Jun 03, 2023 at 03:21:16PM +0800, Miaohe Lin wrote:
> Use helper macro FLUSH_TIME to indicate the flush time to improve the
> readability a bit. No functional change intended.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Acked-by: Roman Gushchin <roman.gushchin@linux.dev>

Thanks!