Mailing List Archive: [PATCH] soc: qcom: icc-bwmon: Fix MSM8998 count unit

[PATCH] soc: qcom: icc-bwmon: Fix MSM8998 count unit

May 31, 2023, 10:15 AM

Post #1 of 5 (21 views)

MSM8998's BWMON counts in megabytes. Fix it.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
drivers/soc/qcom/icc-bwmon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/icc-bwmon.c b/drivers/soc/qcom/icc-bwmon.c
index f65bfeca7ed6..40068a285913 100644
--- a/drivers/soc/qcom/icc-bwmon.c
+++ b/drivers/soc/qcom/icc-bwmon.c
@@ -806,7 +806,7 @@ static int bwmon_remove(struct platform_device *pdev)

static const struct icc_bwmon_data msm8998_bwmon_data = {
.sample_ms = 4,
- .count_unit_kb = 64,
+ .count_unit_kb = 1024,
.default_highbw_kbps = 4800 * 1024, /* 4.8 GBps */
.default_medbw_kbps = 512 * 1024, /* 512 MBps */
.default_lowbw_kbps = 0,

---
base-commit: d4cee89031c80066ec461bb77b5e13a4f37d5fd2
change-id: 20230531-topic-msm8998-bwmon-ba20827e470e

Best regards,
--
Konrad Dybcio <konrad.dybcio@linaro.org>

Re: [PATCH] soc: qcom: icc-bwmon: Fix MSM8998 count unit [ In reply to ]

krzysztof.kozlowski at linaro

May 31, 2023, 10:15 AM

Post #2 of 5 (21 views)

Permalink

On 31/05/2023 18:33, Konrad Dybcio wrote:
> MSM8998's BWMON counts in megabytes. Fix it.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> drivers/soc/qcom/icc-bwmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

If this is
https://lore.kernel.org/all/33c61f23-6442-6d9b-492f-dd6e9c64a8c1@quicinc.com/
(and QLT 1872) then add reported-by tag.

Change seems logical, although not really documented (a bit
contradictory information for sdm845), so assuming this was really tested:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH] soc: qcom: icc-bwmon: Fix MSM8998 count unit [ In reply to ]

konrad.dybcio at linaro

May 31, 2023, 10:15 AM

Post #3 of 5 (21 views)

Permalink

On 31.05.2023 19:03, Krzysztof Kozlowski wrote:
> On 31/05/2023 18:33, Konrad Dybcio wrote:
>> MSM8998's BWMON counts in megabytes. Fix it.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> drivers/soc/qcom/icc-bwmon.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> If this is
> https://lore.kernel.org/all/33c61f23-6442-6d9b-492f-dd6e9c64a8c1@quicinc.com/
> (and QLT 1872) then add reported-by tag.
It's not, I fired up 8998, added debug prints and ran mybw.

>
> Change seems logical, although not really documented (a bit
> contradictory information for sdm845), so assuming this was really tested:
It's not for sdm845, after the last cleanup both BWMONs on that
one got its own driver data struct.

Konrad
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>

Re: [PATCH] soc: qcom: icc-bwmon: Fix MSM8998 count unit [ In reply to ]

krzysztof.kozlowski at linaro

May 31, 2023, 10:15 AM

Post #4 of 5 (21 views)

Permalink

On 31/05/2023 19:05, Konrad Dybcio wrote:
>
>
> On 31.05.2023 19:03, Krzysztof Kozlowski wrote:
>> On 31/05/2023 18:33, Konrad Dybcio wrote:
>>> MSM8998's BWMON counts in megabytes. Fix it.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
>>> drivers/soc/qcom/icc-bwmon.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> If this is
>> https://lore.kernel.org/all/33c61f23-6442-6d9b-492f-dd6e9c64a8c1@quicinc.com/
>> (and QLT 1872) then add reported-by tag.
> It's not, I fired up 8998, added debug prints and ran mybw.
>
>>
>> Change seems logical, although not really documented (a bit
>> contradictory information for sdm845), so assuming this was really tested:
> It's not for sdm845, after the last cleanup both BWMONs on that
> one got its own driver data struct.

Ah, ok, Acks stays :)

Best regards,
Krzysztof

Re: [PATCH] soc: qcom: icc-bwmon: Fix MSM8998 count unit [ In reply to ]

andersson at kernel

Jun 13, 2023, 4:15 PM

Post #5 of 5 (20 views)

Permalink

On Wed, 31 May 2023 18:33:03 +0200, Konrad Dybcio wrote:
> MSM8998's BWMON counts in megabytes. Fix it.
>
>

Applied, thanks!

[1/1] soc: qcom: icc-bwmon: Fix MSM8998 count unit
commit: 1c8267cd14ed6a592a2c2a8eb0fefad4eabe5b4f

Best regards,
--
Bjorn Andersson <andersson@kernel.org>