Mailing List Archive: [PATCH v10 2/7] iommu: Add iommu probe for CDX bus

[PATCH v10 2/7] iommu: Add iommu probe for CDX bus

Mar 13, 2023, 8:15 AM

Post #1 of 3 (10 views)

Add CDX bus to iommu_buses so that IOMMU probe is called
for it.

Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Tested-by: Nikhil Agarwal <nikhil.agarwal@amd.com>
---
drivers/iommu/iommu.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 10db680acaed..0025a631b8e1 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -28,6 +28,7 @@
#include <linux/fsl/mc.h>
#include <linux/module.h>
#include <linux/cc_platform.h>
+#include <linux/cdx/cdx_bus.h>
#include <trace/events/iommu.h>
#include <linux/sched/mm.h>
#include <linux/msi.h>
@@ -129,6 +130,9 @@ static struct bus_type * const iommu_buses[] = {
#ifdef CONFIG_TEGRA_HOST1X_CONTEXT_BUS
&host1x_context_device_bus_type,
#endif
+#ifdef CONFIG_CDX_BUS
+ &cdx_bus_type,
+#endif
};

/*
--
2.17.1

Re: [PATCH v10 2/7] iommu: Add iommu probe for CDX bus [ In reply to ]

gregkh at linuxfoundation

Mar 29, 2023, 4:15 AM

Post #2 of 3 (10 views)

Permalink

On Mon, Mar 13, 2023 at 06:56:31PM +0530, Nipun Gupta wrote:
> Add CDX bus to iommu_buses so that IOMMU probe is called
> for it.
>
> Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
> Tested-by: Nikhil Agarwal <nikhil.agarwal@amd.com>
> ---
> drivers/iommu/iommu.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 10db680acaed..0025a631b8e1 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -28,6 +28,7 @@
> #include <linux/fsl/mc.h>
> #include <linux/module.h>
> #include <linux/cc_platform.h>
> +#include <linux/cdx/cdx_bus.h>
> #include <trace/events/iommu.h>
> #include <linux/sched/mm.h>
> #include <linux/msi.h>
> @@ -129,6 +130,9 @@ static struct bus_type * const iommu_buses[] = {
> #ifdef CONFIG_TEGRA_HOST1X_CONTEXT_BUS
> &host1x_context_device_bus_type,
> #endif
> +#ifdef CONFIG_CDX_BUS
> + &cdx_bus_type,
> +#endif
> };

Note, this prevents the ability for this struct bus_type from being
moved into read-only memory in the future. But hopefully that will be
fixed up eventually, you are in good company with some other busses
here...

Other than that, this series looks good, I'll queue this up through my
tree for now as I seem to collect new subsystems. Feel free to send
future patches through me as well until you get tired of that and want
to send stuff to Linus directly.

thanks,

greg k-h

RE: [PATCH v10 2/7] iommu: Add iommu probe for CDX bus [ In reply to ]

Nipun.Gupta at amd

Mar 29, 2023, 10:15 PM

Post #3 of 3 (10 views)

Permalink

[AMD Official Use Only - General]

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Wednesday, March 29, 2023 3:56 PM
> To: Gupta, Nipun <Nipun.Gupta@amd.com>
> Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> rafael@kernel.org; eric.auger@redhat.com; alex.williamson@redhat.com;
> cohuck@redhat.com; song.bao.hua@hisilicon.com;
> mchehab+huawei@kernel.org; maz@kernel.org; f.fainelli@gmail.com;
> jeffrey.l.hugo@gmail.com; saravanak@google.com;
> Michael.Srba@seznam.cz; mani@kernel.org; yishaih@nvidia.com;
> jgg@ziepe.ca; jgg@nvidia.com; robin.murphy@arm.com; will@kernel.org;
> joro@8bytes.org; masahiroy@kernel.org; ndesaulniers@google.com;
> rdunlap@infradead.org; baolu.lu@linux.intel.com; linux-arm-
> kernel@lists.infradead.org; linux-kbuild@vger.kernel.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; okaya@kernel.org;
> Anand, Harpreet <harpreet.anand@amd.com>; Agarwal, Nikhil
> <nikhil.agarwal@amd.com>; Simek, Michal <michal.simek@amd.com>;
> Jansen Van Vuuren, Pieter <pieter.jansen-van-vuuren@amd.com>; Cascon,
> Pablo <pablo.cascon@amd.com>; git (AMD-Xilinx) <git@amd.com>
> Subject: Re: [PATCH v10 2/7] iommu: Add iommu probe for CDX bus
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On Mon, Mar 13, 2023 at 06:56:31PM +0530, Nipun Gupta wrote:
> > Add CDX bus to iommu_buses so that IOMMU probe is called
> > for it.
> >
> > Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
> > Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-
> vuuren@amd.com>
> > Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
> > Tested-by: Nikhil Agarwal <nikhil.agarwal@amd.com>
> > ---
> > drivers/iommu/iommu.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> > index 10db680acaed..0025a631b8e1 100644
> > --- a/drivers/iommu/iommu.c
> > +++ b/drivers/iommu/iommu.c
> > @@ -28,6 +28,7 @@
> > #include <linux/fsl/mc.h>
> > #include <linux/module.h>
> > #include <linux/cc_platform.h>
> > +#include <linux/cdx/cdx_bus.h>
> > #include <trace/events/iommu.h>
> > #include <linux/sched/mm.h>
> > #include <linux/msi.h>
> > @@ -129,6 +130,9 @@ static struct bus_type * const iommu_buses[] = {
> > #ifdef CONFIG_TEGRA_HOST1X_CONTEXT_BUS
> > &host1x_context_device_bus_type,
> > #endif
> > +#ifdef CONFIG_CDX_BUS
> > + &cdx_bus_type,
> > +#endif
> > };
>
> Note, this prevents the ability for this struct bus_type from being
> moved into read-only memory in the future. But hopefully that will be
> fixed up eventually, you are in good company with some other busses
> here...
>
> Other than that, this series looks good, I'll queue this up through my
> tree for now as I seem to collect new subsystems. Feel free to send
> future patches through me as well until you get tired of that and want
> to send stuff to Linus directly.

Thanks, Greg, for the review and helping get the series in : )

Regards,
Nipun

>
> thanks,
>
> greg k-h