Mailing List Archive: [PATCH] cpufreq: Make kobj

[PATCH] cpufreq: Make kobj_type structure constant

Feb 7, 2023, 12:15 PM

Post #1 of 3 (77 views)

Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.

Take advantage of this to constify the structure definition to prevent
modification at runtime.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
drivers/cpufreq/cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 7e56a42750ea..ceb1574417f9 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -993,7 +993,7 @@ static const struct sysfs_ops sysfs_ops = {
.store = store,
};

-static struct kobj_type ktype_cpufreq = {
+static const struct kobj_type ktype_cpufreq = {
.sysfs_ops = &sysfs_ops,
.default_groups = cpufreq_groups,
.release = cpufreq_sysfs_release,

---
base-commit: 513c1a3d3f1982fb850c910937099525b0d35e24
change-id: 20230207-kobj_type-cpufreq-fdad53f0b538

Best regards,
--
Thomas Weißschuh <linux@weissschuh.net>

Re: [PATCH] cpufreq: Make kobj_type structure constant [ In reply to ]

viresh.kumar at linaro

Feb 7, 2023, 10:15 PM

Post #2 of 3 (75 views)

Permalink

On 07-02-23, 19:58, Thomas Wei?schuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Wei?schuh <linux@weissschuh.net>
> ---
> drivers/cpufreq/cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 7e56a42750ea..ceb1574417f9 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -993,7 +993,7 @@ static const struct sysfs_ops sysfs_ops = {
> .store = store,
> };
>
> -static struct kobj_type ktype_cpufreq = {
> +static const struct kobj_type ktype_cpufreq = {
> .sysfs_ops = &sysfs_ops,
> .default_groups = cpufreq_groups,
> .release = cpufreq_sysfs_release,
>

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

--
viresh

Re: [PATCH] cpufreq: Make kobj_type structure constant [ In reply to ]

rafael at kernel

Feb 9, 2023, 12:15 PM

Post #3 of 3 (72 views)

Permalink

On Wed, Feb 8, 2023 at 6:04 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 07-02-23, 19:58, Thomas Weißschuh wrote:
> > Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> > the driver core allows the usage of const struct kobj_type.
> >
> > Take advantage of this to constify the structure definition to prevent
> > modification at runtime.
> >
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> > ---
> > drivers/cpufreq/cpufreq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > index 7e56a42750ea..ceb1574417f9 100644
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> > @@ -993,7 +993,7 @@ static const struct sysfs_ops sysfs_ops = {
> > .store = store,
> > };
> >
> > -static struct kobj_type ktype_cpufreq = {
> > +static const struct kobj_type ktype_cpufreq = {
> > .sysfs_ops = &sysfs_ops,
> > .default_groups = cpufreq_groups,
> > .release = cpufreq_sysfs_release,
> >
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Applied as 6.3 material, thanks!