Mailing List Archive

[PATCH][next] kernel/user.c: Fix spelling mistake "cpunter" -> "counter"
From: Colin Ian King <colin.king@canonical.com>

There is a spelling mistake in a panic message. Fix it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
kernel/user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/user.c b/kernel/user.c
index a2673f940506..7fc40af8d8ac 100644
--- a/kernel/user.c
+++ b/kernel/user.c
@@ -223,7 +223,7 @@ static int __init uid_cache_init(void)
INIT_HLIST_HEAD(uidhash_table + n);

if (percpu_counter_init(&root_user.epoll_watches, 0, GFP_KERNEL))
- panic("percpu cpunter alloc failed");
+ panic("percpu counter alloc failed");

/* Insert the root user immediately (init already runs as root) */
spin_lock_irq(&uidhash_lock);
--
2.31.1
Re: [PATCH][next] kernel/user.c: Fix spelling mistake "cpunter" -> "counter" [ In reply to ]
On 8/4/21 5:06 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a spelling mistake in a panic message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> kernel/user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/user.c b/kernel/user.c
> index a2673f940506..7fc40af8d8ac 100644
> --- a/kernel/user.c
> +++ b/kernel/user.c
> @@ -223,7 +223,7 @@ static int __init uid_cache_init(void)
> INIT_HLIST_HEAD(uidhash_table + n);
>
> if (percpu_counter_init(&root_user.epoll_watches, 0, GFP_KERNEL))
> - panic("percpu cpunter alloc failed");
> + panic("percpu counter alloc failed");
>
> /* Insert the root user immediately (init already runs as root) */
> spin_lock_irq(&uidhash_lock);
>

Nick Piggin has reworded that panic message text in a patch
yesterday so this patch isn't needed.

https://lore.kernel.org/lkml/1628051945.fens3r99ox.astroid@bobo.none/


thanks.
--
~Randy
Re: [PATCH][next] kernel/user.c: Fix spelling mistake "cpunter" -> "counter" [ In reply to ]
On 04/08/2021 14:35, Randy Dunlap wrote:
> On 8/4/21 5:06 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There is a spelling mistake in a panic message. Fix it.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>   kernel/user.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/user.c b/kernel/user.c
>> index a2673f940506..7fc40af8d8ac 100644
>> --- a/kernel/user.c
>> +++ b/kernel/user.c
>> @@ -223,7 +223,7 @@ static int __init uid_cache_init(void)
>>           INIT_HLIST_HEAD(uidhash_table + n);
>>         if (percpu_counter_init(&root_user.epoll_watches, 0, GFP_KERNEL))
>> -        panic("percpu cpunter alloc failed");
>> +        panic("percpu counter alloc failed");
>>         /* Insert the root user immediately (init already runs as
>> root) */
>>       spin_lock_irq(&uidhash_lock);
>>
>
> Nick Piggin has reworded that panic message text in a patch
> yesterday so this patch isn't needed.

Fair enough. Thanks for the info.

>
> https://lore.kernel.org/lkml/1628051945.fens3r99ox.astroid@bobo.none/
>
>
> thanks.