Mailing List Archive: [PATCH v11 0/4] add some power supply properties about wireless/wired charging

[PATCH v11 0/4] add some power supply properties about wireless/wired charging

Aug 4, 2021, 4:15 AM

Post #1 of 4 (1 views)

From: wangting11 <wangting11@xiaomi.com>

This patchset aims to provide power supply properties about wireless/wired charging.
"quick_charge_type" reports different types of quick charge based on the charging power;
"tx_adapter" shows" the type of wireless charging adapter;
"signal_strength" shows the coupling level between TX and RX;
"reverse_chg_mode" provides the interface of enabling/disabling wireless reverse charging.

Changes in V11
- Fix build error on linus/master
- Fix build error on power-supply/for-next
- Fix conflict

Changes in V10
- Fix build error on linus/master v5.9-rc2 next-20200824 Reported-by: kernel test robot <lkp@intel.com>
- Fix build error on power-supply/for-next Reported-by: kernel test robot <lkp@intel.com>

Changes in v9
- Set bat_imax When get quick charger type

Changes in v8
- Add quick charge type driver in qcom_smbb suggested by GregKH

Changes in v7
- Fix PATCH version error in 0/X email

Changes in v6
- Replace "phones" with "devices" suggested by GregKH
- Add permission statement for "reverse_chg_mode"
- Update description for "reverse_chg_mode" in ABI suggested by GregKH
- Update description for "PING phase" in ABI suggested by GregKH

Changes in v5
- Add details in 0/X email

Changes in v4
- Exclude the patch of "power: supply: supply battery soc with decimal form"
- Fix some typo

Changes in v3
- Add enumederated for quick charge type
- Add enumederated for tx adapter type
- Update the return type and description in ABI

Changes in v2
- modify to capital letters for "power_supply_attrs"
- Update the return type and description in ABI

wangting11 (4):
power: supply: core: add quick charge type property
power: supply: core: add wireless charger adapter type property
power: supply: core: add wireless signal strength property
power: supply: core: property to control reverse charge

Documentation/ABI/testing/sysfs-class-power | 85 +++++++++++++++++++++
drivers/power/supply/power_supply_sysfs.c | 4 +
drivers/power/supply/qcom_smbb.c | 81 +++++++++++++++++++-
include/linux/power_supply.h | 35 +++++++++
4 files changed, 204 insertions(+), 1 deletion(-)

--
2.17.1

Re: [PATCH v11 0/4] add some power supply properties about wireless/wired charging [ In reply to ]

gregkh at linuxfoundation

Aug 4, 2021, 6:15 AM

Post #2 of 4 (1 views)

Permalink

On Wed, Aug 04, 2021 at 07:01:57PM +0800, Ting Wang wrote:
> From: wangting11 <wangting11@xiaomi.com>
>
> This patchset aims to provide power supply properties about wireless/wired charging.
> "quick_charge_type" reports different types of quick charge based on the charging power;
> "tx_adapter" shows" the type of wireless charging adapter;
> "signal_strength" shows the coupling level between TX and RX;
> "reverse_chg_mode" provides the interface of enabling/disabling wireless reverse charging.
>
> Changes in V11
> - Fix build error on linus/master
> - Fix build error on power-supply/for-next
> - Fix conflict

Where are the users of these new properties? Shouldn't drivers be
submitted with them as well, otherwise why would these be added?

thanks,

greg k-h

Re: [PATCH v11 0/4] add some power supply properties about wireless/wired charging [ In reply to ]

zxc52fgh at gmail

Aug 4, 2021, 8:15 PM

Post #3 of 4 (1 views)

Permalink

Hi Greg,

A demo of “The usage of quick charge type property” is uploaded in
PATCH v11 1/4 drivers/power/supply/qcom_smbb.c.

The usage of the other three properties is about wireless charging.The
code of our driver can refer to the link below.

POWER_SUPPLY_PROP_QUICK_CHARGE_TYPE?
https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/umi-q-oss/drivers/power/supply/qcom/qpnp-smb5.c#L1434

POWER_SUPPLY_PROP_REVERSE_CHG_MODE?
https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/umi-q-oss/drivers/power/supply/qcom/qpnp-smb5.c#L2572

POWER_SUPPLY_PROP_TX_ADAPTER?
https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/umi-q-oss/drivers/power/supply/qcom/qpnp-smb5.c#L2633

POWER_SUPPLY_PROP_SIGNAL_STRENGTH?
https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/umi-q-oss/drivers/power/supply/qcom/qpnp-smb5.c#L2609

Thanks?
Wangting

Greg KH <gregkh@linuxfoundation.org> ?2021?8?4??? ??8:04???
>
> On Wed, Aug 04, 2021 at 07:01:57PM +0800, Ting Wang wrote:
> > From: wangting11 <wangting11@xiaomi.com>
> >
> > This patchset aims to provide power supply properties about wireless/wired charging.
> > "quick_charge_type" reports different types of quick charge based on the charging power;
> > "tx_adapter" shows" the type of wireless charging adapter;
> > "signal_strength" shows the coupling level between TX and RX;
> > "reverse_chg_mode" provides the interface of enabling/disabling wireless reverse charging.
> >
> > Changes in V11
> > - Fix build error on linus/master
> > - Fix build error on power-supply/for-next
> > - Fix conflict
>
> Where are the users of these new properties? Shouldn't drivers be
> submitted with them as well, otherwise why would these be added?
>
> thanks,
>
> greg k-h

Re: [PATCH v11 0/4] add some power supply properties about wireless/wired charging [ In reply to ]

gregkh at linuxfoundation

Aug 5, 2021, 2:15 AM

Post #4 of 4 (1 views)

Permalink

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Aug 05, 2021 at 10:29:08AM +0800, ?!?? wrote:
> Hi Greg,
>
> A demo of “The usage of quick charge type property” is uploaded in
> PATCH v11 1/4 drivers/power/supply/qcom_smbb.c.
>
>
> The usage of the other three properties is about wireless charging.The
> code of our driver can refer to the link below.
>
> POWER_SUPPLY_PROP_QUICK_CHARGE_TYPE?
> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/umi-q-oss/drivers/power/supply/qcom/qpnp-smb5.c#L1434
>
> POWER_SUPPLY_PROP_REVERSE_CHG_MODE?
> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/umi-q-oss/drivers/power/supply/qcom/qpnp-smb5.c#L2572
>
> POWER_SUPPLY_PROP_TX_ADAPTER?
> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/umi-q-oss/drivers/power/supply/qcom/qpnp-smb5.c#L2633
>
> POWER_SUPPLY_PROP_SIGNAL_STRENGTH?
> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/umi-q-oss/drivers/power/supply/qcom/qpnp-smb5.c#L2609

Wonderful, please submit these drivers to be merged as part of this
patch series and all should be good.

Otherwise, please realize that we can not support out-of-tree drivers at
all, that way lies madness and a kernel that we can never support well
over time.

thanks,

greg k-h