Mailing List Archive: [PATCH 0/2] coresight: ultrasoc: Add support for System Memory Buffer device

[PATCH 0/2] coresight: ultrasoc: Add support for System Memory Buffer device

Jul 19, 2021, 6:15 AM

Post #1 of 5 (1 views)

This patchset add support for SMB(System Memory Buffer) device, SMB
obtains CPU instructions from Coresight ETM device and stores these
messages in system memory.
SMB is developed by Ultrasoc technology, which is acquired by Siemens,
and we still use "Ultrasoc" to name document and driver.

Change since RFC:
- Move ultrasoc driver to drivers/hwtracing/coresight.
- Remove ultrasoc-axi-com.c, as AXI-COM doesn't need to be configured in
basic tracing function.
- Remove ultrasoc.c as SMB does not need to register with the ultrasoc core.
- Address the comments from Mathieu and Suzuki.
- Link: https://lists.linaro.org/pipermail/coresight/2021-June/006535.html

Qi Liu (2):
Documentation: tracing: Documentation for ultrasoc SMB drivers
coresight: ultrasoc: Add System Memory Buffer driver

.../trace/coresight/ultrasoc-trace.rst | 193 +++++
MAINTAINERS | 7 +
drivers/hwtracing/coresight/Kconfig | 3 +
drivers/hwtracing/coresight/Makefile | 2 +
drivers/hwtracing/coresight/ultrasoc/Kconfig | 12 +
drivers/hwtracing/coresight/ultrasoc/Makefile | 6 +
.../coresight/ultrasoc/ultrasoc-smb.c | 722 ++++++++++++++++++
.../coresight/ultrasoc/ultrasoc-smb.h | 142 ++++
8 files changed, 1087 insertions(+)
create mode 100644 Documentation/trace/coresight/ultrasoc-trace.rst
create mode 100644 drivers/hwtracing/coresight/ultrasoc/Kconfig
create mode 100644 drivers/hwtracing/coresight/ultrasoc/Makefile
create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.c
create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.h

--
2.17.1

Re: [PATCH 0/2] coresight: ultrasoc: Add support for System Memory Buffer device [ In reply to ]

liuqi115 at huawei

Aug 4, 2021, 2:15 AM

Post #2 of 5 (1 views)

Permalink

Gentle ping...
Hi Mathieu and Suzuki, can you have a look at this patchset? thanks.

On 2021/7/19 19:17, Qi Liu wrote:
> This patchset add support for SMB(System Memory Buffer) device, SMB
> obtains CPU instructions from Coresight ETM device and stores these
> messages in system memory.
> SMB is developed by Ultrasoc technology, which is acquired by Siemens,
> and we still use "Ultrasoc" to name document and driver.
>
> Change since RFC:
> - Move ultrasoc driver to drivers/hwtracing/coresight.
> - Remove ultrasoc-axi-com.c, as AXI-COM doesn't need to be configured in
> basic tracing function.
> - Remove ultrasoc.c as SMB does not need to register with the ultrasoc core.
> - Address the comments from Mathieu and Suzuki.
> - Link: https://lists.linaro.org/pipermail/coresight/2021-June/006535.html
>
> Qi Liu (2):
> Documentation: tracing: Documentation for ultrasoc SMB drivers
> coresight: ultrasoc: Add System Memory Buffer driver
>
> .../trace/coresight/ultrasoc-trace.rst | 193 +++++
> MAINTAINERS | 7 +
> drivers/hwtracing/coresight/Kconfig | 3 +
> drivers/hwtracing/coresight/Makefile | 2 +
> drivers/hwtracing/coresight/ultrasoc/Kconfig | 12 +
> drivers/hwtracing/coresight/ultrasoc/Makefile | 6 +
> .../coresight/ultrasoc/ultrasoc-smb.c | 722 ++++++++++++++++++
> .../coresight/ultrasoc/ultrasoc-smb.h | 142 ++++
> 8 files changed, 1087 insertions(+)
> create mode 100644 Documentation/trace/coresight/ultrasoc-trace.rst
> create mode 100644 drivers/hwtracing/coresight/ultrasoc/Kconfig
> create mode 100644 drivers/hwtracing/coresight/ultrasoc/Makefile
> create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.c
> create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.h
>

Re: [PATCH 0/2] coresight: ultrasoc: Add support for System Memory Buffer device [ In reply to ]

mathieu.poirier at linaro

Aug 4, 2021, 8:15 AM

Post #3 of 5 (1 views)

Permalink

On Wed, 4 Aug 2021 at 02:05, liuqi (BA) <liuqi115@huawei.com> wrote:
>
> Gentle ping...
> Hi Mathieu and Suzuki, can you have a look at this patchset? thanks.
>

On August 2nd I got back to you privately saying I won't be able to
review this patchset before the last week of August or the first week
of September. Pinging me again on it won't change that reality.

> On 2021/7/19 19:17, Qi Liu wrote:
> > This patchset add support for SMB(System Memory Buffer) device, SMB
> > obtains CPU instructions from Coresight ETM device and stores these
> > messages in system memory.
> > SMB is developed by Ultrasoc technology, which is acquired by Siemens,
> > and we still use "Ultrasoc" to name document and driver.
> >
> > Change since RFC:
> > - Move ultrasoc driver to drivers/hwtracing/coresight.
> > - Remove ultrasoc-axi-com.c, as AXI-COM doesn't need to be configured in
> > basic tracing function.
> > - Remove ultrasoc.c as SMB does not need to register with the ultrasoc core.
> > - Address the comments from Mathieu and Suzuki.
> > - Link: https://lists.linaro.org/pipermail/coresight/2021-June/006535.html
> >
> > Qi Liu (2):
> > Documentation: tracing: Documentation for ultrasoc SMB drivers
> > coresight: ultrasoc: Add System Memory Buffer driver
> >
> > .../trace/coresight/ultrasoc-trace.rst | 193 +++++
> > MAINTAINERS | 7 +
> > drivers/hwtracing/coresight/Kconfig | 3 +
> > drivers/hwtracing/coresight/Makefile | 2 +
> > drivers/hwtracing/coresight/ultrasoc/Kconfig | 12 +
> > drivers/hwtracing/coresight/ultrasoc/Makefile | 6 +
> > .../coresight/ultrasoc/ultrasoc-smb.c | 722 ++++++++++++++++++
> > .../coresight/ultrasoc/ultrasoc-smb.h | 142 ++++
> > 8 files changed, 1087 insertions(+)
> > create mode 100644 Documentation/trace/coresight/ultrasoc-trace.rst
> > create mode 100644 drivers/hwtracing/coresight/ultrasoc/Kconfig
> > create mode 100644 drivers/hwtracing/coresight/ultrasoc/Makefile
> > create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.c
> > create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.h
> >
>

Re: [PATCH 0/2] coresight: ultrasoc: Add support for System Memory Buffer device [ In reply to ]

liuqi115 at huawei

Aug 5, 2021, 1:05 AM

Post #4 of 5 (1 views)

Permalink

On 2021/8/4 22:31, Mathieu Poirier wrote:
> On Wed, 4 Aug 2021 at 02:05, liuqi (BA) <liuqi115@huawei.com> wrote:
>>
>> Gentle ping...
>> Hi Mathieu and Suzuki, can you have a look at this patchset? thanks.
>>
>
> On August 2nd I got back to you privately saying I won't be able to
> review this patchset before the last week of August or the first week
> of September. Pinging me again on it won't change that reality.
>
Hi Mathieu,

Sorry for pinging again as I didn't see that email, perhaps because it
is not captured to my coresight subfolder by my mailbox filtering rule
:(. I'll wait patiently for your reply.

Thanks,
Qi

>> On 2021/7/19 19:17, Qi Liu wrote:
>>> This patchset add support for SMB(System Memory Buffer) device, SMB
>>> obtains CPU instructions from Coresight ETM device and stores these
>>> messages in system memory.
>>> SMB is developed by Ultrasoc technology, which is acquired by Siemens,
>>> and we still use "Ultrasoc" to name document and driver.
>>>
>>> Change since RFC:
>>> - Move ultrasoc driver to drivers/hwtracing/coresight.
>>> - Remove ultrasoc-axi-com.c, as AXI-COM doesn't need to be configured in
>>> basic tracing function.
>>> - Remove ultrasoc.c as SMB does not need to register with the ultrasoc core.
>>> - Address the comments from Mathieu and Suzuki.
>>> - Link: https://lists.linaro.org/pipermail/coresight/2021-June/006535.html
>>>
>>> Qi Liu (2):
>>> Documentation: tracing: Documentation for ultrasoc SMB drivers
>>> coresight: ultrasoc: Add System Memory Buffer driver
>>>
>>> .../trace/coresight/ultrasoc-trace.rst | 193 +++++
>>> MAINTAINERS | 7 +
>>> drivers/hwtracing/coresight/Kconfig | 3 +
>>> drivers/hwtracing/coresight/Makefile | 2 +
>>> drivers/hwtracing/coresight/ultrasoc/Kconfig | 12 +
>>> drivers/hwtracing/coresight/ultrasoc/Makefile | 6 +
>>> .../coresight/ultrasoc/ultrasoc-smb.c | 722 ++++++++++++++++++
>>> .../coresight/ultrasoc/ultrasoc-smb.h | 142 ++++
>>> 8 files changed, 1087 insertions(+)
>>> create mode 100644 Documentation/trace/coresight/ultrasoc-trace.rst
>>> create mode 100644 drivers/hwtracing/coresight/ultrasoc/Kconfig
>>> create mode 100644 drivers/hwtracing/coresight/ultrasoc/Makefile
>>> create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.c
>>> create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.h
>>>
>>
> .
>

Re: [PATCH 0/2] coresight: ultrasoc: Add support for System Memory Buffer device [ In reply to ]

mathieu.poirier at linaro

Sep 2, 2021, 12:15 PM

Post #5 of 5 (1 views)

Permalink

On Mon, Jul 19, 2021 at 07:17:35PM +0800, Qi Liu wrote:
> This patchset add support for SMB(System Memory Buffer) device, SMB
> obtains CPU instructions from Coresight ETM device and stores these
> messages in system memory.
> SMB is developed by Ultrasoc technology, which is acquired by Siemens,
> and we still use "Ultrasoc" to name document and driver.
>
> Change since RFC:
> - Move ultrasoc driver to drivers/hwtracing/coresight.
> - Remove ultrasoc-axi-com.c, as AXI-COM doesn't need to be configured in
> basic tracing function.
> - Remove ultrasoc.c as SMB does not need to register with the ultrasoc core.
> - Address the comments from Mathieu and Suzuki.
> - Link: https://lists.linaro.org/pipermail/coresight/2021-June/006535.html
>
> Qi Liu (2):
> Documentation: tracing: Documentation for ultrasoc SMB drivers
> coresight: ultrasoc: Add System Memory Buffer driver
>
> .../trace/coresight/ultrasoc-trace.rst | 193 +++++
> MAINTAINERS | 7 +
> drivers/hwtracing/coresight/Kconfig | 3 +
> drivers/hwtracing/coresight/Makefile | 2 +
> drivers/hwtracing/coresight/ultrasoc/Kconfig | 12 +
> drivers/hwtracing/coresight/ultrasoc/Makefile | 6 +
> .../coresight/ultrasoc/ultrasoc-smb.c | 722 ++++++++++++++++++
> .../coresight/ultrasoc/ultrasoc-smb.h | 142 ++++
> 8 files changed, 1087 insertions(+)

I have started to review this set. Comments will follow shortly.

Thanks,
Mathieu

> create mode 100644 Documentation/trace/coresight/ultrasoc-trace.rst
> create mode 100644 drivers/hwtracing/coresight/ultrasoc/Kconfig
> create mode 100644 drivers/hwtracing/coresight/ultrasoc/Makefile
> create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.c
> create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.h
>
> --
> 2.17.1
>