Mailing List Archive

On Tue 26 Jan 02:52 CST 2021, Jiapeng Zhong wrote:

> Fix the following coccicheck warnings:
>
> ./drivers/firmware/qcom_scm.c:324:20-22: WARNING !A || A && B is
> equivalent to !A || B.
>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> ---
> drivers/firmware/qcom_scm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 7be48c1..c530072 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -321,7 +321,7 @@ int qcom_scm_set_cold_boot_addr(void *entry, const cpumask_t *cpus)
> .owner = ARM_SMCCC_OWNER_SIP,
> };
>
> - if (!cpus || (cpus && cpumask_empty(cpus)))
> + if (!cpus || cpumask_empty(cpus))
> return -EINVAL;
>
> for_each_cpu(cpu, cpus) {
> --
> 1.8.3.1
>