Mailing List Archive: [PATCH] xen: remove redundant initialization of variable ret

[PATCH] xen: remove redundant initialization of variable ret

Sep 19, 2020, 1:05 AM

Post #1 of 3 (9 views)

After commit 9f51c05dc41a ("pvcalls-front: Avoid
get_free_pages(GFP_KERNEL) under spinlock"), the variable ret is being
initialized with '-ENOMEM' that is meaningless. So remove it.

Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/xen/pvcalls-front.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c
index 72d725a0ab5c..7984645b5956 100644
--- a/drivers/xen/pvcalls-front.c
+++ b/drivers/xen/pvcalls-front.c
@@ -371,7 +371,7 @@ static int alloc_active_ring(struct sock_mapping *map)
static int create_active(struct sock_mapping *map, evtchn_port_t *evtchn)
{
void *bytes;
- int ret = -ENOMEM, irq = -1, i;
+ int ret, irq = -1, i;

*evtchn = 0;
init_waitqueue_head(&map->active.inflight_conn_req);
--
2.17.1

Re: [PATCH] xen: remove redundant initialization of variable ret [ In reply to ]

jgross at suse

Sep 22, 2020, 2:15 AM

Post #2 of 3 (9 views)

Permalink

On 19.09.20 05:17, Jing Xiangfeng wrote:
> After commit 9f51c05dc41a ("pvcalls-front: Avoid
> get_free_pages(GFP_KERNEL) under spinlock"), the variable ret is being
> initialized with '-ENOMEM' that is meaningless. So remove it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>

Reviewed-by: Juergen Gross <jgross@suse.com>

Juergen

Re: [PATCH] xen: remove redundant initialization of variable ret [ In reply to ]

boris.ostrovsky at oracle

Sep 30, 2020, 8:15 AM

Post #3 of 3 (9 views)

Permalink

On 9/18/20 11:17 PM, Jing Xiangfeng wrote:
> After commit 9f51c05dc41a ("pvcalls-front: Avoid
> get_free_pages(GFP_KERNEL) under spinlock"), the variable ret is being
> initialized with '-ENOMEM' that is meaningless. So remove it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>

Applied to for-linus-5.10

-boris