Advanced
Mailing List Archive

Mailing List Archive

  1. Home >
  2. Interchange>
  3. users
Re: [interchange] Fix redundant sprintf errors in perl 5.22.0
racke at linuxia
Jun 23, 2017, 12:17 AM
Post #1 of 8 (2256 views)
Permalink
Hello David,

thanks very much on your effort to clean up Interchange!

This change caused the following error in the demo on the ICDEVGROUP server:

Unknown warnings category 'redundant' at /home/demo1/interchange/lib/Vend/Util.pm line 95

Regards
Racke


On 06/22/2017 10:05 PM, David Christensen wrote:
> commit 2488528ca1b4f0e0bb8d7d916ac407fbbc00a276
> Author: David Christensen <david@endpoint.com>
> Date: Thu Jun 22 14:40:35 2017 -0500
>
> Fix redundant sprintf errors in perl 5.22.0
>
> lib/Vend/Util.pm | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> ---
> diff --git a/lib/Vend/Util.pm b/lib/Vend/Util.pm
> index be01779..b133663 100644
> --- a/lib/Vend/Util.pm
> +++ b/lib/Vend/Util.pm
> @@ -92,7 +92,7 @@ else {
> );
>
> use strict;
> -no warnings qw(uninitialized numeric);
> +no warnings qw(uninitialized numeric redundant);
> use Config;
> use Fcntl;
> use Errno;
>
> _______________________________________________
> interchange-cvs mailing list
> interchange-cvs@icdevgroup.org
> http://www.icdevgroup.org/mailman/listinfo/interchange-cvs
>


--
Ecommerce and Linux consulting + Perl and web application programming.
Debian and Sympa administration.

_______________________________________________
interchange-users mailing list
interchange-users@icdevgroup.org
http://www.icdevgroup.org/mailman/listinfo/interchange-users
Re: [interchange] Fix redundant sprintf errors in perl 5.22.0 [ In reply to ]
peter at pajamian
Jun 23, 2017, 2:31 AM
Post #2 of 8 (2256 views)
Permalink
On 23/06/17 19:17, Stefan Hornburg (Racke) wrote:
> Hello David,
>
> thanks very much on your effort to clean up Interchange!
>
> This change caused the following error in the demo on the ICDEVGROUP server:
>
> Unknown warnings category 'redundant' at /home/demo1/interchange/lib/Vend/Util.pm line 95

I suggest changing it to:
no warnings qw(uninitialized numeric);
no warnings qw(redundant) if $^V ge v5.22.0;


Peter

_______________________________________________
interchange-users mailing list
interchange-users@icdevgroup.org
http://www.icdevgroup.org/mailman/listinfo/interchange-users
Re: [interchange] Fix redundant sprintf errors in perl 5.22.0 [ In reply to ]
racke at linuxia
Jun 23, 2017, 2:38 AM
Post #3 of 8 (2256 views)
Permalink
On 06/23/2017 11:31 AM, Peter wrote:
> On 23/06/17 19:17, Stefan Hornburg (Racke) wrote:
>> Hello David,
>>
>> thanks very much on your effort to clean up Interchange!
>>
>> This change caused the following error in the demo on the ICDEVGROUP server:
>>
>> Unknown warnings category 'redundant' at /home/demo1/interchange/lib/Vend/Util.pm line 95
>
> I suggest changing it to:
> no warnings qw(uninitialized numeric);
> no warnings qw(redundant) if $^V ge v5.22.0;
>
>
> Peter

Sounds good to me.

Regards
Racke


--
Ecommerce and Linux consulting + Perl and web application programming.
Debian and Sympa administration.

_______________________________________________
interchange-users mailing list
interchange-users@icdevgroup.org
http://www.icdevgroup.org/mailman/listinfo/interchange-users
Re: [interchange] Fix redundant sprintf errors in perl 5.22.0 [ In reply to ]
racke at linuxia
Jun 24, 2017, 6:00 AM
Post #4 of 8 (2252 views)
Permalink
On 06/23/2017 11:38 AM, Stefan Hornburg (Racke) wrote:
> On 06/23/2017 11:31 AM, Peter wrote:
>> On 23/06/17 19:17, Stefan Hornburg (Racke) wrote:
>>> Hello David,
>>>
>>> thanks very much on your effort to clean up Interchange!
>>>
>>> This change caused the following error in the demo on the ICDEVGROUP server:
>>>
>>> Unknown warnings category 'redundant' at /home/demo1/interchange/lib/Vend/Util.pm line 95
>>
>> I suggest changing it to:
>> no warnings qw(uninitialized numeric);
>> no warnings qw(redundant) if $^V ge v5.22.0;
>>
>>
>> Peter
>
> Sounds good to me.
>
> Regards
> Racke
>
>

Doesn't seem to work though ...

syntax error at /home/demo4/interchange/lib/Vend/Util.pm line 96, near "qw(redundant) if"

Regards
Racke

--
Ecommerce and Linux consulting + Perl and web application programming.
Debian and Sympa administration.

_______________________________________________
interchange-users mailing list
interchange-users@icdevgroup.org
http://www.icdevgroup.org/mailman/listinfo/interchange-users
Re: [interchange] Fix redundant sprintf errors in perl 5.22.0 [ In reply to ]
peter at pajamian
Jun 24, 2017, 3:23 PM
Post #5 of 8 (2249 views)
Permalink
On 25/06/17 01:00, Stefan Hornburg (Racke) wrote:
>>> I suggest changing it to:
>>> no warnings qw(uninitialized numeric);
>>> no warnings qw(redundant) if $^V ge v5.22.0;
>>>
>>>
>>> Peter
> Doesn't seem to work though ...
>
> syntax error at /home/demo4/interchange/lib/Vend/Util.pm line 96, near "qw(redundant) if"

Reading perl docs it looks like this is implemented at compilation time
so run time constructs don't work. Try this instead:

no if $^V ge v5.22.0, warnings => qw(redundant);

The above does not kick back any errors or warnings on 5.16.0.


Peter

_______________________________________________
interchange-users mailing list
interchange-users@icdevgroup.org
http://www.icdevgroup.org/mailman/listinfo/interchange-users
Re: [interchange] Fix redundant sprintf errors in perl 5.22.0 [ In reply to ]
peter at pajamian
Jun 25, 2017, 11:13 AM
Post #6 of 8 (2246 views)
Permalink
On 25/06/17 10:23, Peter wrote:
>> syntax error at /home/demo4/interchange/lib/Vend/Util.pm line 96, near "qw(redundant) if"
>
> Reading perl docs it looks like this is implemented at compilation time
> so run time constructs don't work. Try this instead:
>
> no if $^V ge v5.22.0, warnings => qw(redundant);
>
> The above does not kick back any errors or warnings on 5.16.0.

I pushed this change out, we'll see if it fixes the issue.


Peter

_______________________________________________
interchange-users mailing list
interchange-users@icdevgroup.org
http://www.icdevgroup.org/mailman/listinfo/interchange-users
Re: [interchange] Fix redundant sprintf errors in perl 5.22.0 [ In reply to ]
david at endpoint
Jul 3, 2017, 6:29 AM
Post #7 of 8 (2229 views)
Permalink
> On Jun 25, 2017, at 1:13 PM, Peter <peter@pajamian.dhs.org> wrote:
>
> On 25/06/17 10:23, Peter wrote:
>>> syntax error at /home/demo4/interchange/lib/Vend/Util.pm line 96, near "qw(redundant) if"
>>
>> Reading perl docs it looks like this is implemented at compilation time
>> so run time constructs don't work. Try this instead:
>>
>> no if $^V ge v5.22.0, warnings => qw(redundant);
>>
>> The above does not kick back any errors or warnings on 5.16.0.
>
> I pushed this change out, we'll see if it fixes the issue.

Been out for a week, but I assume by the silence that this fixed the issue. Sidebar, while functional, that is a very funky construct for conditional compile-time operations! :-)

David
--
David Christensen
End Point Corporation
david@endpoint.com
785-727-1171




_______________________________________________
interchange-users mailing list
interchange-users@icdevgroup.org
http://www.icdevgroup.org/mailman/listinfo/interchange-users
Re: [interchange] Fix redundant sprintf errors in perl 5.22.0 [ In reply to ]
peter at pajamian
Jul 3, 2017, 12:48 PM
Post #8 of 8 (2229 views)
Permalink
On 04/07/17 01:29, David Christensen wrote:
>>> no if $^V ge v5.22.0, warnings => qw(redundant);

> Sidebar, while functional, that is a very funky construct for
> conditional compile-time operations! :-)

I agree, but it appears to be the only way to do it. I found the
construct documented for use in perldoc -f use and figured that by
extension it should work for no, tried it and it does.


Peter

_______________________________________________
interchange-users mailing list
interchange-users@icdevgroup.org
http://www.icdevgroup.org/mailman/listinfo/interchange-users

©2024 GT.net. A Gossamer Threads company.
5th Floor, 455 Granville St., Vancouver, BC V6C 1T1, Canada | Legal