Mailing List Archive

Patch for gpgme.texi bug
Hi,

I just tried to compile a current gpgme from CVS and it failed when
building the docs. gpgme.texi has a wrong closing brace. See patch.

Bernhard

--
Intevation GmbH http://intevation.de/
Skencil http://sketch.sourceforge.net/
Thuban http://thuban.intevation.org/
Re: Patch for gpgme.texi bug [ In reply to ]
At Tue, 28 Sep 2004 13:21:06 +0200,
Bernhard Herzog wrote:
> I just tried to compile a current gpgme from CVS and it failed when
> building the docs. gpgme.texi has a wrong closing brace. See patch.

D'oh, thanks. Fixed in CVS. (BTW, just as a general note, unified
context diffs are much more readable when the changes are complex, so
please use the "-u" option with diff or cvs diff).

Thanks,
Marcus
Re: Patch for gpgme.texi bug [ In reply to ]
On Tue, Sep 28, 2004 at 01:47:04PM +0200, Marcus Brinkmann wrote:
> (BTW, just as a general note, unified
> context diffs are much more readable when the changes are complex, so
> please use the "-u" option with diff or cvs diff).

It is good to know you prefer them,
I think that the debate about -c or -u is not decided yet,
some developers prefer -c.
;)
Bernhard
Re: Patch for gpgme.texi bug [ In reply to ]
On Wed, 29 Sep 2004 16:57:51 +0200, Bernhard Reiter said:

> I think that the debate about -c or -u is not decided yet,
> some developers prefer -c.
> ;)

Maybe -c is better fro python stuff ;-)
Re: Patch for gpgme.texi bug [ In reply to ]
At Wed, 29 Sep 2004 16:57:51 +0200,
Bernhard Reiter <bernhard@intevation.de> wrote:
> > context diffs are much more readable when the changes are complex, so
> > please use the "-u" option with diff or cvs diff).
>
> It is good to know you prefer them,
> I think that the debate about -c or -u is not decided yet,
> some developers prefer -c.
> ;)

Well, I could see why, but it really depends on the type of changes.
Unfortunately that makes it impossible to give easy instructions for a
contributor to follow. :-/ For a one-liner -u has the obvious
advantage of putting the changed line directly next to the original,
though.

But yeah, it's probably subjective. It's not a big deal, as long it's
-c or -u at least. What I forgot to mention though (and sometimes
forget using myself) is the---for C code---highly useful option -p
(--show-c-function), a real underdog!

Thanks,
Marcus