Mailing List Archive

[PATCH 3/3] ecc: Wrong flag and elements_enc fix.
* cipher/ecc.c (ecc_generate): Fix wrong flag and elements_enc.

Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
---
cipher/ecc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cipher/ecc.c b/cipher/ecc.c
index 921510cc..10e11243 100644
--- a/cipher/ecc.c
+++ b/cipher/ecc.c
@@ -577,7 +577,7 @@ ecc_generate (const gcry_sexp_t genparms, gcry_sexp_t *r_skey)
(&curve_flags, NULL,
((flags & PUBKEY_FLAG_PARAM) && (flags & PUBKEY_FLAG_EDDSA))?
"(flags param eddsa)" :
- ((flags & PUBKEY_FLAG_PARAM) && (flags & PUBKEY_FLAG_EDDSA))?
+ ((flags & PUBKEY_FLAG_PARAM) && (flags & PUBKEY_FLAG_DJB_TWEAK))?
"(flags param djb-tweak)" :
((flags & PUBKEY_FLAG_PARAM))?
"(flags param)" : ((flags & PUBKEY_FLAG_EDDSA))?
@@ -1712,7 +1712,7 @@ gcry_pk_spec_t _gcry_pubkey_spec_ecc =
GCRY_PK_ECC, { 0, 1 },
(GCRY_PK_USAGE_SIGN | GCRY_PK_USAGE_ENCR),
"ECC", ecc_names,
- "pabgnhq", "pabgnhqd", "sw", "rs", "pabgnhq",
+ "pabgnhq", "pabgnhqd", "se", "rs", "pabgnhq",
ecc_generate,
ecc_check_secret_key,
ecc_encrypt_raw,
--
2.17.1


_______________________________________________
Gcrypt-devel mailing list
Gcrypt-devel@gnupg.org
http://lists.gnupg.org/mailman/listinfo/gcrypt-devel
Re: [PATCH 3/3] ecc: Wrong flag and elements_enc fix. [ In reply to ]
Hello,

On 22.12.2019 11.15, Tianjia Zhang via Gcrypt-devel wrote:
> * cipher/ecc.c (ecc_generate): Fix wrong flag and elements_enc.
>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> ---
> cipher/ecc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cipher/ecc.c b/cipher/ecc.c
> index 921510cc..10e11243 100644
> --- a/cipher/ecc.c
> +++ b/cipher/ecc.c
> @@ -577,7 +577,7 @@ ecc_generate (const gcry_sexp_t genparms, gcry_sexp_t *r_skey)
> (&curve_flags, NULL,
> ((flags & PUBKEY_FLAG_PARAM) && (flags & PUBKEY_FLAG_EDDSA))?
> "(flags param eddsa)" :
> - ((flags & PUBKEY_FLAG_PARAM) && (flags & PUBKEY_FLAG_EDDSA))?
> + ((flags & PUBKEY_FLAG_PARAM) && (flags & PUBKEY_FLAG_DJB_TWEAK))?
> "(flags param djb-tweak)" :
> ((flags & PUBKEY_FLAG_PARAM))?
> "(flags param)" : ((flags & PUBKEY_FLAG_EDDSA))?
> @@ -1712,7 +1712,7 @@ gcry_pk_spec_t _gcry_pubkey_spec_ecc =
> GCRY_PK_ECC, { 0, 1 },
> (GCRY_PK_USAGE_SIGN | GCRY_PK_USAGE_ENCR),
> "ECC", ecc_names,
> - "pabgnhq", "pabgnhqd", "sw", "rs", "pabgnhq",
> + "pabgnhq", "pabgnhqd", "se", "rs", "pabgnhq",
> ecc_generate,
> ecc_check_secret_key,
> ecc_encrypt_raw,
>

Looks ok.

-Jussi

_______________________________________________
Gcrypt-devel mailing list
Gcrypt-devel@gnupg.org
http://lists.gnupg.org/mailman/listinfo/gcrypt-devel