Mailing List Archive

[PATCH] Fix three errors for ec algorithm
Fix three errors in EC alogrithm and mpi.



_______________________________________________
Gcrypt-devel mailing list
Gcrypt-devel@gnupg.org
http://lists.gnupg.org/mailman/listinfo/gcrypt-devel
Re: [PATCH] Fix three errors for ec algorithm [ In reply to ]
Hello,

On 22.12.2019 11.15, Tianjia Zhang via Gcrypt-devel wrote:
> Fix three errors in EC alogrithm and mpi.
>

Thanks for your contributions. I'll leave some comments on the patches in few days but it would be better if someone more familiar with MPI/EC side of gcrypt checks the patches too.

One thing for you to do is to send your signed DCO to this mailing-list (see 'License policy' in doc/HACKING).

-Jussi

>
>
> _______________________________________________
> Gcrypt-devel mailing list
> Gcrypt-devel@gnupg.org
> http://lists.gnupg.org/mailman/listinfo/gcrypt-devel
>


_______________________________________________
Gcrypt-devel mailing list
Gcrypt-devel@gnupg.org
http://lists.gnupg.org/mailman/listinfo/gcrypt-devel
Re: [PATCH] Fix three errors for ec algorithm [ In reply to ]
Hello,

Jussi Kivilinna via Gcrypt-devel wrote:
> Thanks for your contributions. I'll leave some comments on the patches
> in few days but it would be better if someone more familiar with
> MPI/EC side of gcrypt checks the patches too.

Acked by me for:
[PATCH 1/3] Update .gitignore
[PATCH v2] mpi: Fix error that point not uninitialized
[PATCH 3/3] ecc: Wrong flag and elements_enc fix.

To Tianjia Zhang: Thanks for your good catch. I just realized that you
also sent me other patches directly to me for review. I'll do that
soon.

My excuse for 3/3 is that: the feature (flags param) is basically for
classic ECC where (some) people want to define their own domain
parameters, and it has been not used with modern ECC (which may have
eddsa or djb-tweak flag). For the _gcry_pubkey_spec_ecc fix, I should
have fixed the "sw" -> "se" when I touched other parameters.
--

_______________________________________________
Gcrypt-devel mailing list
Gcrypt-devel@gnupg.org
http://lists.gnupg.org/mailman/listinfo/gcrypt-devel
Re: [PATCH] Fix three errors for ec algorithm [ In reply to ]
On 9.1.2020 1.24, NIIBE Yutaka wrote:
> Hello,
>
> Jussi Kivilinna via Gcrypt-devel wrote:
>> Thanks for your contributions. I'll leave some comments on the patches
>> in few days but it would be better if someone more familiar with
>> MPI/EC side of gcrypt checks the patches too.
>
> Acked by me for:
> [PATCH 1/3] Update .gitignore
> [PATCH v2] mpi: Fix error that point not uninitialized
> [PATCH 3/3] ecc: Wrong flag and elements_enc fix.
>

I've applied these now.

-Jussi

_______________________________________________
Gcrypt-devel mailing list
Gcrypt-devel@gnupg.org
http://lists.gnupg.org/mailman/listinfo/gcrypt-devel