Mailing List Archive

[gpgme][PATCH] autogen.sh: remove '-unknown' in version
python setuptools >=66.0.0 treats '-unknown' as an invalid version.
The error message is as below:
pkg_resources.extern.packaging.version.InvalidVersion: Invalid version: '1.18.0-unknown'

Remove the '-unknown' suffix to fix this issue.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
autogen.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/autogen.sh b/autogen.sh
index 9b361581..d5cccd2a 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -266,7 +266,7 @@ if [ "$myhost" = "find-version" ]; then
else
ingit=no
beta=yes
- tmp="-unknown"
+ tmp=""
rev="0000000"
rvd="0"
fi
--
2.17.1


_______________________________________________
Gnupg-devel mailing list
Gnupg-devel@gnupg.org
https://lists.gnupg.org/mailman/listinfo/gnupg-devel
[gpgme][PATCH] autogen.sh: remove '-unknown' in version [ In reply to ]
python setuptools >=66.0.0 treats '-unknown' as an invalid version.
The error message is as below:
pkg_resources.extern.packaging.version.InvalidVersion: Invalid version: '1.18.0-unknown'

Remove the '-unknown' suffix to fix this issue.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
autogen.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/autogen.sh b/autogen.sh
index 9b361581..d5cccd2a 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -266,7 +266,7 @@ if [ "$myhost" = "find-version" ]; then
else
ingit=no
beta=yes
- tmp="-unknown"
+ tmp=""
rev="0000000"
rvd="0"
fi
--
2.17.1


_______________________________________________
Gnupg-devel mailing list
Gnupg-devel@gnupg.org
https://lists.gnupg.org/mailman/listinfo/gnupg-devel
[gpgme][PATCH] autogen.sh: remove '-unknown' in version [ In reply to ]
python setuptools >=66.0.0 treats '-unknown' as an invalid version.
The error message is as below:
pkg_resources.extern.packaging.version.InvalidVersion: Invalid version: '1.18.0-unknown'

Remove the '-unknown' suffix to fix this issue.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
autogen.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/autogen.sh b/autogen.sh
index 9b361581..d5cccd2a 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -266,7 +266,7 @@ if [ "$myhost" = "find-version" ]; then
else
ingit=no
beta=yes
- tmp="-unknown"
+ tmp=""
rev="0000000"
rvd="0"
fi
--
2.17.1


_______________________________________________
Gnupg-devel mailing list
Gnupg-devel@gnupg.org
https://lists.gnupg.org/mailman/listinfo/gnupg-devel
Re: [gpgme][PATCH] autogen.sh: remove '-unknown' in version [ In reply to ]
On Tue, 28 Feb 2023 14:09, Chen Qi said:

> Remove the '-unknown' suffix to fix this issue.

This is in the repo for a reason. Regular builds from the released
tarball don't have this.


Salam-Shalom,

Werner

--
The pioneers of a warless world are the youth that
refuse military service. - A. Einstein
RE: [gpgme][PATCH] autogen.sh: remove '-unknown' in version [ In reply to ]
I'm using gpgme-1.18.0.tar.bz2.
I'm not building from git repo.
Also, I'm using cross-compile, more specially a Yocto environment.

I don't know much about gpgme. Could you please tell me why this function will not be called when building from tarball?

Regards,
Qi

-----Original Message-----
From: Werner Koch <wk@gnupg.org>
Sent: Tuesday, February 28, 2023 3:08 PM
To: Chen Qi via Gnupg-devel <gnupg-devel@gnupg.org>
Cc: Chen, Qi <Qi.Chen@windriver.com>
Subject: Re: [gpgme][PATCH] autogen.sh: remove '-unknown' in version

On Tue, 28 Feb 2023 14:09, Chen Qi said:

> Remove the '-unknown' suffix to fix this issue.

This is in the repo for a reason. Regular builds from the released tarball don't have this.


Salam-Shalom,

Werner

--
The pioneers of a warless world are the youth that
refuse military service. - A. Einstein

_______________________________________________
Gnupg-devel mailing list
Gnupg-devel@gnupg.org
https://lists.gnupg.org/mailman/listinfo/gnupg-devel
Re: [gpgme][PATCH] autogen.sh: remove '-unknown' in version [ In reply to ]
On Tue, 28 Feb 2023 07:22, Chen, Qi said:

> I don't know much about gpgme. Could you please tell me why this
> function will not be called when building from tarball?

You ran the script. This is only needed if you want to build a new
configure script.

./configure
make
make install # usually as root

is the canonical triple jump to build software


Shalom-Salam,

Werner

--
The pioneers of a warless world are the youth that
refuse military service. - A. Einstein
RE: [gpgme][PATCH] autogen.sh: remove '-unknown' in version [ In reply to ]
Thanks. You're right. We're building a new configure script. Is it not expected for users using tarball?

Regards,
Qi

-----Original Message-----
From: Werner Koch <wk@gnupg.org>
Sent: Tuesday, February 28, 2023 3:30 PM
To: Chen, Qi via Gnupg-devel <gnupg-devel@gnupg.org>
Cc: Chen, Qi <Qi.Chen@windriver.com>
Subject: Re: [gpgme][PATCH] autogen.sh: remove '-unknown' in version

On Tue, 28 Feb 2023 07:22, Chen, Qi said:

> I don't know much about gpgme. Could you please tell me why this
> function will not be called when building from tarball?

You ran the script. This is only needed if you want to build a new configure script.

./configure
make
make install # usually as root

is the canonical triple jump to build software


Shalom-Salam,

Werner

--
The pioneers of a warless world are the youth that
refuse military service. - A. Einstein

_______________________________________________
Gnupg-devel mailing list
Gnupg-devel@gnupg.org
https://lists.gnupg.org/mailman/listinfo/gnupg-devel
Re: [gpgme][PATCH] autogen.sh: remove '-unknown' in version [ In reply to ]
On Tue, 28 Feb 2023 07:43, Chen, Qi said:
> Thanks. You're right. We're building a new configure script. Is it not
> expected for users using tarball?

The whole point of providing a configure script is to test the
capabilities of the system and build the software according to these
capabilities. Creating a new configure is a maintainer task and only
needed if you change Makefiles or want to make changes to the
configuration system. This is usually done in the Git checkout and the
version suffix will then be something with -betaNNNN




Shalom-Salam,

Werner

--
The pioneers of a warless world are the youth that
refuse military service. - A. Einstein
Re: [gpgme][PATCH] autogen.sh: remove '-unknown' in version [ In reply to ]
Hi Werner,

Werner Koch via Gnupg-devel <gnupg-devel@gnupg.org> wrote:

> On Tue, 28 Feb 2023 07:22, Chen, Qi said:
>
>> I don't know much about gpgme. Could you please tell me why this
>> function will not be called when building from tarball?
>
> You ran the script. This is only needed if you want to build a new
> configure script.
>
> ./configure
> make
> make install # usually as root
>
> is the canonical triple jump to build software


There are a few distribution build systems out there that will always
re-generate configure scripts from configure.ac, and Yocto (as mentioned by
the reporter) is one of them.

They do this because some projects have been slow in updating their
dependencies which occasionally causes problems with the configure scripts,
because macros from those dependencies are being copied into ./configure,
and re-generating the scripts fixes this. This often addresses problems on
new architectures, for example.

It would be helpful if GnuPG and gpgme could support re-creation of the
configure scripts from the tarballs.


Qi: You could delete configure.ac before do_configure, which makes
autotools.bbclass avoid the autoreconf [1].

[1] https://git.yoctoproject.org/poky/tree/meta/classes-recipe/autotools.bbclass#n174


HTH,
Clemens


_______________________________________________
Gnupg-devel mailing list
Gnupg-devel@gnupg.org
https://lists.gnupg.org/mailman/listinfo/gnupg-devel
Re: [gpgme][PATCH] autogen.sh: remove '-unknown' in version [ In reply to ]
On Tue, 28 Feb 2023 10:44, Clemens Lang said:

> It would be helpful if GnuPG and gpgme could support re-creation of the
> configure scripts from the tarballs.

No, we don't do this on purpose. We use our version of the M4 macros
and we have seen in the past that they had regression which introduced
hard to find bugs in GnuPG. Thus we don't support anything else than
what we delivered in the release tarballs.


Viele Grüße,

Werner Koch

--
The pioneers of a warless world are the youth that
refuse military service. - A. Einstein