Mailing List Archive

On Wed, 17 Oct 2018 21:56, astieger@suse.com said:
> Hello,
>
> It would seem that gpa needs gpgme 1.11.1 to build. See attached patch.

I wonder why this should be the case.

> 9e11986 references GPGME_AUDITLOG_DIAG (new in gpgme 1.11.1)

The code is only build if gpgme is recent enough:

--8<---------------cut here---------------start------------->8---
#if GPGME_VERSION_NUMBER >= 0x010c00 /* >= 1.12 */
gpgme_data_t diag;
char *info, *buffer, *result;
gpg_error_t err;
gpgme_engine_info_t engine;
gpgme_protocol_t proto;
int need_gpgme_free;

if (!context)
return NULL;
if (gpgme_data_new (&diag))
return NULL; /* Ooops. */

context->inhibit_gpgme_events++;
err = gpgme_op_getauditlog (context->ctx, diag, GPGME_AUDITLOG_DIAG);
--8<---------------cut here---------------end--------------->8---

I wonder what went wrong here.

> f160e92 references GPGME_KEYLIST_MODE_LOCATE (new in 1.11.0)

You are right. A simple fix is attached.



Salam-Shalom,

Werner

--
Die Gedanken sind frei. Ausnahmen regelt ein Bundesgesetz.

On 10/18/18 11:31 AM, Werner Koch wrote:
>> 9e11986 references GPGME_AUDITLOG_DIAG (new in gpgme 1.11.1)
> The code is only build if gpgme is recent enough:
>
> --8<---------------cut here---------------start------------->8---
> #if GPGME_VERSION_NUMBER >= 0x010c00 /* >= 1.12 */


Right. For GPGME_AUDITLOG_DIAG I was merely looking for new symbols in
gpgme. The actual build failure with 1.10.0 exactly was
GPGME_KEYLIST_MODE_LOCATE.


>> f160e92 references GPGME_KEYLIST_MODE_LOCATE (new in 1.11.0)
> You are right. A simple fix is attached.


Looks good.


Thanks,

Andreas


--
Andreas Stieger <astieger@suse.com>
Head of Product Security
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton,
HRB 21284 (AG Nürnberg)


_______________________________________________
Gnupg-devel mailing list
Gnupg-devel@gnupg.org
http://lists.gnupg.org/mailman/listinfo/gnupg-devel