Advanced
Mailing List Archive

Mailing List Archive

  1. Home >
  2. Gentoo>
  3. Dev
[PATCH] cuda.eclass: EAPI support: add 8, drop 5 and 6
marecki at gentoo
Jul 14, 2021, 3:49 PM
Post #1 of 4 (48 views)
Permalink
Signed-off-by: Marek Szuba <marecki@gentoo.org>
---
eclass/cuda.eclass | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/eclass/cuda.eclass b/eclass/cuda.eclass
index b1da77c69dd..08d2302d55b 100644
--- a/eclass/cuda.eclass
+++ b/eclass/cuda.eclass
@@ -1,11 +1,11 @@
-# Copyright 1999-2020 Gentoo Authors
+# Copyright 1999-2021 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2

case "${EAPI:-0}" in
- 0|1|2|3|4)
+ [0-6])
die "Unsupported EAPI=${EAPI:-0} (too old) for ${ECLASS}"
;;
- 5|6|7)
+ 7|8)
;;
*)
die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
@@ -15,7 +15,7 @@ esac
# @ECLASS: cuda.eclass
# @MAINTAINER:
# Gentoo Science Project <sci@gentoo.org>
-# @SUPPORTED_EAPIS: 5 6 7
+# @SUPPORTED_EAPIS: 7 8
# @BLURB: Common functions for cuda packages
# @DESCRIPTION:
# This eclass contains functions to be used with cuda package. Currently it is
--
2.31.1
Re: [PATCH] cuda.eclass: EAPI support: add 8, drop 5 and 6 [ In reply to ]
ulm at gentoo
Jul 14, 2021, 10:58 PM
Post #2 of 4 (48 views)
Permalink
>>>>> On Thu, 15 Jul 2021, Marek Szuba wrote:

> case "${EAPI:-0}" in
> - 0|1|2|3|4)
> + [0-6])
> die "Unsupported EAPI=${EAPI:-0} (too old) for ${ECLASS}"
> ;;
> - 5|6|7)
> + 7|8)
> ;;
> *)
> die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"

In the latest bunch of updates, we have changed many eclasses to have
only a single error case, and also standardized the die message.
Maybe simplify this eclass as well?

case ${EAPI} in
7|8) ;;
*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
esac

Attached Files:

Re: [PATCH] cuda.eclass: EAPI support: add 8, drop 5 and 6 [ In reply to ]
marecki at gentoo
Jul 15, 2021, 1:41 PM
Post #3 of 4 (48 views)
Permalink
On 2021-07-15 06:58, Ulrich Mueller wrote:

> In the latest bunch of updates, we have changed many eclasses to have
> only a single error case, and also standardized the die message.
> Maybe simplify this eclass as well?

If anyone from Sci suggests/seconds this I shall not argue, that said I
do in fact like having both the two cases separate and the eclass name
in the die message - so between that and the fact we have already got
EAPI 8-compatible eclasses in the tree which do it this way, I am
leaving this part be at present.

--
Marecki

Attached Files:

Re: [PATCH] cuda.eclass: EAPI support: add 8, drop 5 and 6 [ In reply to ]
sam at gentoo
Jul 16, 2021, 2:41 PM
Post #4 of 4 (46 views)
Permalink
> On 15 Jul 2021, at 21:41, Marek Szuba <marecki@gentoo.org> wrote:
>
> On 2021-07-15 06:58, Ulrich Mueller wrote:
>
>> In the latest bunch of updates, we have changed many eclasses to have
>> only a single error case, and also standardized the die message.
>> Maybe simplify this eclass as well?
>
> If anyone from Sci suggests/seconds this I shall not argue, that said I do in fact like having both the two cases separate and the eclass name in the die message - so between that and the fact we have already got EAPI 8-compatible eclasses in the tree which do it this way, I am leaving this part be at present.
>

I'd prefer the consistency given that's what we're moving towards, if possible.

Attached Files:

©2024 GT.net. A Gossamer Threads company.
5th Floor, 455 Granville St., Vancouver, BC V6C 1T1, Canada | Legal