Advanced
Mailing List Archive

Mailing List Archive

  1. Home >
  2. Gentoo>
  3. Dev
[PATCH 1/1] docs.eclass: invert (B)DEPEND if condition
andrewammerlaan at gentoo
Jul 1, 2021, 12:14 AM
Post #1 of 2 (16 views)
Permalink
As suggested by Soap (Thank You!)

Makes this part more future proof, and removes the "," that shouldn't
have been there.

diff --git a/eclass/docs.eclass b/eclass/docs.eclass
index f49c6aeab9d..684ab26919c 100644
--- a/eclass/docs.eclass
+++ b/eclass/docs.eclass
@@ -378,7 +378,7 @@ case ${DOCS_BUILDER} in
;;
esac

-if [[ ${EAPI} == [7,8] ]]; then
+if [[ ${EAPI} != 6 ]]; then
BDEPEND+=" doc? ( ${DOCS_DEPEND} )"
else
DEPEND+=" doc? ( ${DOCS_DEPEND} )"
Re: [PATCH 1/1] docs.eclass: invert (B)DEPEND if condition [ In reply to ]
soap at gentoo
Jul 1, 2021, 1:13 AM
Post #2 of 2 (16 views)
Permalink
On Thu, 2021-07-01 at 09:14 +0200, Andrew Ammerlaan wrote:
> As suggested by Soap (Thank You!)
>
> Makes this part more future proof, and removes the "," that shouldn't
> have been there.
>
> diff --git a/eclass/docs.eclass b/eclass/docs.eclass
> index f49c6aeab9d..684ab26919c 100644
> --- a/eclass/docs.eclass
> +++ b/eclass/docs.eclass
> @@ -378,7 +378,7 @@ case ${DOCS_BUILDER} in
>                 ;;
>   esac
>
> -if [[ ${EAPI} == [7,8] ]]; then
> +if [[ ${EAPI} != 6 ]]; then
>         BDEPEND+=" doc? ( ${DOCS_DEPEND} )"
>   else
>         DEPEND+=" doc? ( ${DOCS_DEPEND} )"
>

+1, go ahead and commit it

©2024 GT.net. A Gossamer Threads company.
5th Floor, 455 Granville St., Vancouver, BC V6C 1T1, Canada | Legal