On 2020-06-14 16:30, a.m@freemail.hu wrote:
>
> Suggested fix for: https://bugs.gentoo.org/show_bug.cgi?id=489542
> Bug 489542 - netsurf.eclass should not include EROOT in PREFIX
>
Well, I've applied this as well as some other fixes for the eclass, only
to find that the problem has been relocated from netsurf.eclass into
/usr/share/netsurf-buildsystem/gentoo-helpers.sh (which it looks like is
just an out-of-tree eclass?).
There are only two ebuilds left in the tree using netsurf.eclass:
* dev-libs/libparserutils-0.2.3 (superseded by v0.2.4-r1)
* net-libs/libhubbub-0.3.3 (superseded by v0.3.6)
The first one needs a stabilization, but then the old versions can be
removed and netsurf.eclass can be last-rited. That leaves us with a
similar problem in gentoo-helpers.sh, which does...
NSSHARED="${EROOT}"/usr/share/netsurf-buildsystem
LIBDIR="$(get_libdir)"
PREFIX="${EROOT}/usr"
Digging into the netsurf buildsystem it looks like PREFIX is already
pre/appended to the uses of NSSHARED and DESTDIR. So I think we should
have instead,
LIBDIR="$(get_libdir)"
PREFIX="${EPREFIX}/usr"
and then the ebuilds themselves need to be fixed. For example,
_emake TARGET=framebuffer DESTDIR="${ED}" install
should have DESTDIR="${D}" instead, because the buildsystem already
installs to $(DESTDIR)$(PREFIX). As it is, you're getting the "E" twice.
Removing the EROOT (as in the proposed patch) would also fix this, but
the standard pattern for ebuilds is to use the "E" variables at
configure-time, and only $D at install-time.
>
> Suggested fix for: https://bugs.gentoo.org/show_bug.cgi?id=489542
> Bug 489542 - netsurf.eclass should not include EROOT in PREFIX
>
Well, I've applied this as well as some other fixes for the eclass, only
to find that the problem has been relocated from netsurf.eclass into
/usr/share/netsurf-buildsystem/gentoo-helpers.sh (which it looks like is
just an out-of-tree eclass?).
There are only two ebuilds left in the tree using netsurf.eclass:
* dev-libs/libparserutils-0.2.3 (superseded by v0.2.4-r1)
* net-libs/libhubbub-0.3.3 (superseded by v0.3.6)
The first one needs a stabilization, but then the old versions can be
removed and netsurf.eclass can be last-rited. That leaves us with a
similar problem in gentoo-helpers.sh, which does...
NSSHARED="${EROOT}"/usr/share/netsurf-buildsystem
LIBDIR="$(get_libdir)"
PREFIX="${EROOT}/usr"
Digging into the netsurf buildsystem it looks like PREFIX is already
pre/appended to the uses of NSSHARED and DESTDIR. So I think we should
have instead,
LIBDIR="$(get_libdir)"
PREFIX="${EPREFIX}/usr"
and then the ebuilds themselves need to be fixed. For example,
_emake TARGET=framebuffer DESTDIR="${ED}" install
should have DESTDIR="${D}" instead, because the buildsystem already
installs to $(DESTDIR)$(PREFIX). As it is, you're getting the "E" twice.
Removing the EROOT (as in the proposed patch) would also fix this, but
the standard pattern for ebuilds is to use the "E" variables at
configure-time, and only $D at install-time.