https://bugs.exim.org/show_bug.cgi?id=2732
--- Comment #1 from Jeremy Harris <jgh146exb@wizmail.org> ---
Full marks for writing a lookup module.
I might suggest that using the same indent and comments standards as the rest
of Exim tries to would be preferred. Also, please look into using
project-standard memory allocation (rather than the malloc family).
Finally, some additions to the main documentation (assuming you want
mainline support of the compile option, rather than Experimental)
and testcases for the testsuite would both be wanted.
I see you chose to offer a query-style interface rather than single-key.
Yet the support seems to be limited to a (tagged) key and one return datum.
What is the reasoning?
--
You are receiving this mail because:
You are on the CC list for the bug.
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##
--- Comment #1 from Jeremy Harris <jgh146exb@wizmail.org> ---
Full marks for writing a lookup module.
I might suggest that using the same indent and comments standards as the rest
of Exim tries to would be preferred. Also, please look into using
project-standard memory allocation (rather than the malloc family).
Finally, some additions to the main documentation (assuming you want
mainline support of the compile option, rather than Experimental)
and testcases for the testsuite would both be wanted.
I see you chose to offer a query-style interface rather than single-key.
Yet the support seems to be limited to a (tagged) key and one return datum.
What is the reasoning?
--
You are receiving this mail because:
You are on the CC list for the bug.
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##