Mailing List Archive

https://bugs.exim.org/show_bug.cgi?id=2639

--- Comment #2 from Git Commit <git@exim.org> ---
Git commit:
https://git.exim.org/exim.git/commitdiff/29041f6cd4b0d8a0ee109ed0a0efaaf929d6a804

commit 29041f6cd4b0d8a0ee109ed0a0efaaf929d6a804
Author: Jeremy Harris <jgh146exb@wizmail.org>
AuthorDate: Tue Nov 24 22:11:09 2020 +0000
Commit: Jeremy Harris <jgh146exb@wizmail.org>
CommitDate: Tue Nov 24 22:11:09 2020 +0000

ARC: harden parsing of signing spec. Bug 2639
---
src/src/arc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/src/arc.c b/src/src/arc.c
index 0617312..c1407af 100644
--- a/src/src/arc.c
+++ b/src/src/arc.c
@@ -1607,10 +1607,10 @@ expire = now = 0;

/* Parse the signing specification */

-identity = string_nextinlist(&signspec, &sep, NULL, 0);
-selector = string_nextinlist(&signspec, &sep, NULL, 0);
-if ( !*identity || !*selector
- || !(privkey = string_nextinlist(&signspec, &sep, NULL, 0)) || !*privkey)
+if ( !(identity = string_nextinlist(&signspec, &sep, NULL, 0)) || !*identity
+ || !(selector = string_nextinlist(&signspec, &sep, NULL, 0)) || !*selector
+ || !(privkey = string_nextinlist(&signspec, &sep, NULL, 0)) || !*privkey
+ )
{
s = !*identity ? US"identity" : !*selector ? US"selector" : US"private-key";
goto bad_arg_ret;

--
You are receiving this mail because:
You are on the CC list for the bug.
--
## List details at https://lists.exim.org/mailman/listinfo/exim-dev Exim details at http://www.exim.org/ ##