Mailing List Archive

Patch to force freshclam download progress meter
Hi all,

With the release of 0.99, I got caught out by a change to freshclam's output. The end result is the same (defs do/don't get updated) so none of my automated tests caught it, but when you actually sit and watch the output, I'm not getting the download progress meter in my GUI any more.

The change that tripped it up was commit #cf5ba11 - Avoid emitting incremental progress messages when not outputting to a terminal.

I've included a patch which works against 0.99 stable as well as current HEAD (#1f85811) to add a new command line flag --show-progress to freshclam to force the output of the progress meter if freshclam isn't being called via a terminal.

Hopefully the additional flag won't cause problems for anyone, so it would be really great if the patch could be included please.

Many thanks,
Mark
Re: Patch to force freshclam download progress meter [ In reply to ]
Mark,

Thank you for sending a patch. Tracking with
https://bugzilla.clamav.net/show_bug.cgi?id=11455

Steve

On Tue, Dec 15, 2015 at 9:24 AM, Mark Allan <markjallan@gmail.com> wrote:

> Hi all,
>
> With the release of 0.99, I got caught out by a change to freshclam's
> output. The end result is the same (defs do/don't get updated) so none of
> my automated tests caught it, but when you actually sit and watch the
> output, I'm not getting the download progress meter in my GUI any more.
>
> The change that tripped it up was commit #cf5ba11 - Avoid emitting
> incremental progress messages when not outputting to a terminal.
>
> I've included a patch which works against 0.99 stable as well as current
> HEAD (#1f85811) to add a new command line flag --show-progress to freshclam
> to force the output of the progress meter if freshclam isn't being called
> via a terminal.
>
> Hopefully the additional flag won't cause problems for anyone, so it would
> be really great if the patch could be included please.
>
> Many thanks,
> Mark
>
>
>
> _______________________________________________
> http://lurker.clamav.net/list/clamav-devel.html
> Please submit your patches to our Bugzilla: http://bugs.clamav.net
>
> http://www.clamav.net/contact.html#ml
>
_______________________________________________
http://lurker.clamav.net/list/clamav-devel.html
Please submit your patches to our Bugzilla: http://bugs.clamav.net

http://www.clamav.net/contact.html#ml