Mailing List Archive

Anyone else seeing this in bric_queued.log ?
[/home/tyee/bricolage2/lib/Bric.pm:931]
[/home/tyee/bricolage2/lib/Bric/Util/Burner/Mason.pm:290]
[/home/tyee/bricolage2/lib/Bric/Util/Burner.pm:1600]
[/home/tyee/bricolage2/lib/Bric/Util/Burner.pm:1340]
[/home/tyee/bricolage2/lib/Bric/Util/Job/Pub.pm:187]
[/home/tyee/bricolage2/lib/Bric/Util/Job.pm:1886]
[/home/tyee/bricolage2/bin/bric_queued:247]
[/home/tyee/bricolage2/bin/bric_queued:213]
Use of uninitialized value $outbuf in pattern match (m//) at /home/tyee/bricolage2/lib/Bric/Util/Burner/Mason.pm line 290.


https://github.com/bricoleurs/bricolage/blob/master/lib/Bric/Util/Burner/Mason.pm#L290


Phillip.

--
Phillip Smith
http://phillipadsmith.com
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On Jul 14, 2014, at 10:48 AM, Phillip Smith <ps@phillipadsmith.com> wrote:

> Use of uninitialized value $outbuf in pattern match (m//) at /home/tyee/bricolage2/lib/Bric/Util/Burner/Mason.pm line 290.
>
> https://github.com/bricoleurs/bricolage/blob/master/lib/Bric/Util/Burner/Mason.pm#L290

Are you aborting the burn? That might leave $outbuf undefined. Should probably change the code to initialize it to ''.

Best,

David
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On 2014-07-14, at 5:20 PM, David E. Wheeler <david@justatheory.com> wrote:

>
> On Jul 14, 2014, at 10:48 AM, Phillip Smith <ps@phillipadsmith.com> wrote:
>
>> Use of uninitialized value $outbuf in pattern match (m//) at /home/tyee/bricolage2/lib/Bric/Util/Burner/Mason.pm line 290.
>>
>> https://github.com/bricoleurs/bricolage/blob/master/lib/Bric/Util/Burner/Mason.pm#L290
>
> Are you aborting the burn?

Not that I know of…


> That might leave $outbuf undefined. Should probably change the code to initialize it to ''.

Seemed like a relatively innocuous change, so I've done that quickly here:
https://github.com/bricoleurs/bricolage

(Feel free to slap my wrist for that!)

I will wrestle my Bricolage install to the death this week, so I can resume actually running tests on my local machine first.

Phillip.

--
Phillip Smith
http://phillipadsmith.com
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On Jul 14, 2014, at 2:36 PM, Phillip Smith <ps@phillipadsmith.com> wrote:

> Seemed like a relatively innocuous change, so I've done that quickly here:
> https://github.com/bricoleurs/bricolage
>
> (Feel free to slap my wrist for that!)

Do all tests pass?

D
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On 2014-07-14, at 5:38 PM, David E. Wheeler <david@justatheory.com> wrote:

> On Jul 14, 2014, at 2:36 PM, Phillip Smith <ps@phillipadsmith.com> wrote:
>
>> Seemed like a relatively innocuous change, so I've done that quickly here:
>> https://github.com/bricoleurs/bricolage
>>
>> (Feel free to slap my wrist for that!)
>
> Do all tests pass?

➜ bricolage-2.1.0 git:(master) ✗ make test
PERL_DL_NONLAZY=1 /Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.3/bin/perl inst/runtests.pl
t/Bric/Test/Runner.pm .. ok
All tests successful.
Files=1, Tests=2610, 3 wallclock secs ( 0.43 usr 0.04 sys + 2.46 cusr 0.22 csys = 3.15 CPU)
Result: PASS

Will run the devtest momentarily…

Phillip.

--
Phillip Smith
http://phillipadsmith.com
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On 2014-07-14, at 5:50 PM, Phillip Smith <ps@phillipadsmith.com> wrote:

> On 2014-07-14, at 5:38 PM, David E. Wheeler <david@justatheory.com> wrote:
>
>> On Jul 14, 2014, at 2:36 PM, Phillip Smith <ps@phillipadsmith.com> wrote:
>>
>>> Seemed like a relatively innocuous change, so I've done that quickly here:
>>> https://github.com/bricoleurs/bricolage
>>>
>>> (Feel free to slap my wrist for that!)
>>
>> Do all tests pass?
>
> ➜ bricolage-2.1.0 git:(master) ✗ make test
> PERL_DL_NONLAZY=1 /Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.3/bin/perl inst/runtests.pl
> t/Bric/Test/Runner.pm .. ok
> All tests successful.
> Files=1, Tests=2610, 3 wallclock secs ( 0.43 usr 0.04 sys + 2.46 cusr 0.22 csys = 3.15 CPU)
> Result: PASS
>
> Will run the devtest momentarily…

I'm still getting these 50 errors:
https://gist.github.com/phillipadsmith/7ac5dad1f6221c562cbb

… same I've been seeing for a bit now.

Point me in the right direction; will continue sleuthing.

--
Phillip Smith
http://phillipadsmith.com
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On Jul 14, 2014, at 3:09 PM, Phillip Smith <ps@phillipadsmith.com> wrote:

> I'm still getting these 50 errors:
> https://gist.github.com/phillipadsmith/7ac5dad1f6221c562cbb
>
> … same I've been seeing for a bit now.
>
> Point me in the right direction; will continue sleuthing.

Looks like maybe some new data was added or something, and the number of something was changed. Servers and Permissions?

Anyway, I suggest using `git bisect` to find the offending commit.

http://www.askbjoernhansen.com/2010/04/30/git_bisect_mini_tutorial.html

Best,

David
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On 2014-07-14, at 6:20 PM, "David E. Wheeler" <david@justatheory.com> wrote:

> On Jul 14, 2014, at 3:09 PM, Phillip Smith <ps@phillipadsmith.com> wrote:
>
>> I'm still getting these 50 errors:
>> https://gist.github.com/phillipadsmith/7ac5dad1f6221c562cbb
>>
>> … same I've been seeing for a bit now.
>>
>> Point me in the right direction; will continue sleuthing.
>
> Looks like maybe some new data was added or something, and the number of something was changed. Servers and Permissions?
>
> Anyway, I suggest using `git bisect` to find the offending commit.
>
> http://www.askbjoernhansen.com/2010/04/30/git_bisect_mini_tutorial.html

Hmmm…

Okay, so, a few of these:

[lib/Bric.pm:931]
[lib/Bric/SOAP/Story.pm:914]
[lib/Bric/SOAP/Story.pm:914]
[/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.1/lib/5.16.1/Test/More.pm:860]
[t/Bric/SOAP/Story/Test.pm:11]
[/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.1/lib/site_perl/5.16.1/Test/Class.pm:281]
[/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.1/lib/site_perl/5.16.1/Test/Class.pm:384]
[t/Bric/Test/Runner.pm:101]
Use of qw(...) as parentheses is deprecated at lib/Bric/SOAP/Story.pm line 1199.

but otherwise:

All tests successful.
Files=1, Tests=12677, 35 wallclock secs ( 1.92 usr 0.14 sys + 22.24 cusr 1.60 csys = 25.90 CPU)
Result: PASS

… for v2.0.1

Going to re-try a 2.1.0 from scratch to see what happens. If it's still failing, I'll start working through the `git bisect` steps…

Phillip.

--
Phillip Smith
http://phillipadsmith.com
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On Jul 14, 2014, at 5:07 PM, Phillip Smith <ps@phillipadsmith.com> wrote:

> Use of qw(...) as parentheses is deprecated at lib/Bric/SOAP/Story.pm line 1199.

Those are easily fixed.

> but otherwise:
>
> All tests successful.
> Files=1, Tests=12677, 35 wallclock secs ( 1.92 usr 0.14 sys + 22.24 cusr 1.60 csys = 25.90 CPU)
> Result: PASS
>
> … for v2.0.1

Great!

> Going to re-try a 2.1.0 from scratch to see what happens. If it's still failing, I'll start working through the `git bisect` steps…

Good, thanks!

David
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On 2014-07-14, at 8:07 PM, Phillip Smith <ps@phillipadsmith.com> wrote:

>
> On 2014-07-14, at 6:20 PM, "David E. Wheeler" <david@justatheory.com> wrote:
>
>> On Jul 14, 2014, at 3:09 PM, Phillip Smith <ps@phillipadsmith.com> wrote:
>>
>>> I'm still getting these 50 errors:
>>> https://gist.github.com/phillipadsmith/7ac5dad1f6221c562cbb
>>>
>>> … same I've been seeing for a bit now.
>>>
>>> Point me in the right direction; will continue sleuthing.
>>
>> Looks like maybe some new data was added or something, and the number of something was changed. Servers and Permissions?
>>
>> Anyway, I suggest using `git bisect` to find the offending commit.
>>
>> http://www.askbjoernhansen.com/2010/04/30/git_bisect_mini_tutorial.html
>
> Hmmm…
>
> Okay, so, a few of these:
>
> [lib/Bric.pm:931]
> [lib/Bric/SOAP/Story.pm:914]
> [lib/Bric/SOAP/Story.pm:914]
> [/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.1/lib/5.16.1/Test/More.pm:860]
> [t/Bric/SOAP/Story/Test.pm:11]
> [/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.1/lib/site_perl/5.16.1/Test/Class.pm:281]
> [/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.1/lib/site_perl/5.16.1/Test/Class.pm:384]
> [t/Bric/Test/Runner.pm:101]
> Use of qw(...) as parentheses is deprecated at lib/Bric/SOAP/Story.pm line 1199.
>
> but otherwise:
>
> All tests successful.
> Files=1, Tests=12677, 35 wallclock secs ( 1.92 usr 0.14 sys + 22.24 cusr 1.60 csys = 25.90 CPU)
> Result: PASS
>
> … for v2.0.1
>
> Going to re-try a 2.1.0 from scratch to see what happens. If it's still failing, I'll start working through the `git bisect` steps…

Okay, so I think I was neglecting the step where the previous database was dropped and, thus, causing those errors. Here's what I get now:

➜ bricolage-2.1.0 make devtest
PERL_DL_NONLAZY=1 /Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.1/bin/perl inst/runtests.pl -d
t/Bric/Test/Runner.pm .. 271/? # expected 41 test(s) in Bric::Util::Pref::DevTest::test_list, 42 completed
t/Bric/Test/Runner.pm .. 11676/? # expected 26 test(s) in Bric::Biz::Asset::Business::Media::Image::DevTest::test_alternate_thumb, 27 completed
t/Bric/Test/Runner.pm .. ok
All tests successful.
Files=1, Tests=12710, 35 wallclock secs ( 1.92 usr 0.14 sys + 22.31 cusr 1.61 csys = 25.98 CPU)
Result: PASS



--
Phillip Smith
http://phillipadsmith.com
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On 2014-07-14, at 8:11 PM, Phillip Smith <ps@phillipadsmith.com> wrote:

>
> On 2014-07-14, at 8:07 PM, Phillip Smith <ps@phillipadsmith.com> wrote:
>
>>
>> On 2014-07-14, at 6:20 PM, "David E. Wheeler" <david@justatheory.com> wrote:
>>
>>> On Jul 14, 2014, at 3:09 PM, Phillip Smith <ps@phillipadsmith.com> wrote:
>>>
>>>> I'm still getting these 50 errors:
>>>> https://gist.github.com/phillipadsmith/7ac5dad1f6221c562cbb
>>>>
>>>> … same I've been seeing for a bit now.
>>>>
>>>> Point me in the right direction; will continue sleuthing.
>>>
>>> Looks like maybe some new data was added or something, and the number of something was changed. Servers and Permissions?
>>>
>>> Anyway, I suggest using `git bisect` to find the offending commit.
>>>
>>> http://www.askbjoernhansen.com/2010/04/30/git_bisect_mini_tutorial.html
>>
>> Hmmm…
>>
>> Okay, so, a few of these:
>>
>> [lib/Bric.pm:931]
>> [lib/Bric/SOAP/Story.pm:914]
>> [lib/Bric/SOAP/Story.pm:914]
>> [/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.1/lib/5.16.1/Test/More.pm:860]
>> [t/Bric/SOAP/Story/Test.pm:11]
>> [/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.1/lib/site_perl/5.16.1/Test/Class.pm:281]
>> [/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.1/lib/site_perl/5.16.1/Test/Class.pm:384]
>> [t/Bric/Test/Runner.pm:101]
>> Use of qw(...) as parentheses is deprecated at lib/Bric/SOAP/Story.pm line 1199.
>>
>> but otherwise:
>>
>> All tests successful.
>> Files=1, Tests=12677, 35 wallclock secs ( 1.92 usr 0.14 sys + 22.24 cusr 1.60 csys = 25.90 CPU)
>> Result: PASS
>>
>> … for v2.0.1
>>
>> Going to re-try a 2.1.0 from scratch to see what happens. If it's still failing, I'll start working through the `git bisect` steps…
>
> Okay, so I think I was neglecting the step where the previous database was dropped and, thus, causing those errors. Here's what I get now:
>
> ➜ bricolage-2.1.0 make devtest
> PERL_DL_NONLAZY=1 /Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.1/bin/perl inst/runtests.pl -d
> t/Bric/Test/Runner.pm .. 271/? # expected 41 test(s) in Bric::Util::Pref::DevTest::test_list, 42 completed
> t/Bric/Test/Runner.pm .. 11676/? # expected 26 test(s) in Bric::Biz::Asset::Business::Media::Image::DevTest::test_alternate_thumb, 27 completed
> t/Bric/Test/Runner.pm .. ok
> All tests successful.
> Files=1, Tests=12710, 35 wallclock secs ( 1.92 usr 0.14 sys + 22.31 cusr 1.61 csys = 25.98 CPU)
> Result: PASS

Logging in and messing about with the Web UI is working fine. So -- Phew! -- the tests still pass and most things appear to be working.

Now, where were we? :)

--
Phillip Smith
http://phillipadsmith.com
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On Jul 14, 2014, at 5:14 PM, Phillip Smith <ps@phillipadsmith.com> wrote:

> Logging in and messing about with the Web UI is working fine. So -- Phew! -- the tests still pass and most things appear to be working.

Good.

D
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On 2014-07-14, at 8:18 PM, "David E. Wheeler" <david@justatheory.com> wrote:

> On Jul 14, 2014, at 5:14 PM, Phillip Smith <ps@phillipadsmith.com> wrote:
>
>> Logging in and messing about with the Web UI is working fine. So -- Phew! -- the tests still pass and most things appear to be working.
>
> Good.

So, given that I've just followed 98% of the steps here:
https://github.com/bricoleurs/bricolage/wiki/Creating-a-Release

… that process is feeling less onerous than I'd previously thought.

I see that there are a bunch of pull requests too.

Advice on how to proceed?

Phillip.

--
Phillip Smith
http://phillipadsmith.com
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On Jul 14, 2014, at 5:22 PM, Phillip Smith <ps@phillipadsmith.com> wrote:

> So, given that I've just followed 98% of the steps here:
> https://github.com/bricoleurs/bricolage/wiki/Creating-a-Release
>
> … that process is feeling less onerous than I'd previously thought.
>
> I see that there are a bunch of pull requests too.
>
> Advice on how to proceed?

Evaluate pull requests and see if they make sense, and tests pass for each, and merge as appropriate?

D
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On 2014-07-14, at 8:26 PM, "David E. Wheeler" <david@justatheory.com> wrote:

> On Jul 14, 2014, at 5:22 PM, Phillip Smith <ps@phillipadsmith.com> wrote:
>
>> So, given that I've just followed 98% of the steps here:
>> https://github.com/bricoleurs/bricolage/wiki/Creating-a-Release
>>
>> … that process is feeling less onerous than I'd previously thought.
>>
>> I see that there are a bunch of pull requests too.
>>
>> Advice on how to proceed?
>
> Evaluate pull requests and see if they make sense, and tests pass for each, and merge as appropriate?

Okay, so back to where I was many months ago:


➜ bricolage-2.1.0 git:(brewt-desk_fixes) ✗ make devtest
All tests successful.
Files=1, Tests=12710, 38 wallclock secs ( 2.01 usr 0.15 sys + 23.10 cusr 1.72 csys = 26.98 CPU)
Result: PASS

So, Bret's pull request is tested and working.

I'm assuming I should not merge that into the master branch directly, but instead make a tag or some such? Git advises this:

git checkout master
git merge --no-ff brewt-desk_fixes
git push origin master

A couple more pointers, and I'll be on my way to working through the other pull requests. And, from there, WORLD DOMINATION (or maybe a release).

Phillip.

--
Phillip Smith
http://phillipadsmith.com
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On 2014-07-14, at 8:43 PM, Phillip Smith <ps@phillipadsmith.com> wrote:

> A couple more pointers, and I'll be on my way to working through the other pull requests. And, from there, WORLD DOMINATION (or maybe a release).

This pull request passes too:
https://github.com/bricoleurs/bricolage/pull/38

➜ bricolage-2.1.0 git:(bretdawson-280) ✗ sudo make devtest
PERL_DL_NONLAZY=1 /Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.1/bin/perl inst/runtests.pl -d
t/Bric/Test/Runner.pm .. 29/? # expected 41 test(s) in Bric::Util::Pref::DevTest::test_list, 42 completed
t/Bric/Test/Runner.pm .. 11702/? # expected 26 test(s) in Bric::Biz::Asset::Business::Media::Image::DevTest::test_alternate_thumb, 27 completed
t/Bric/Test/Runner.pm .. ok
All tests successful.
Files=1, Tests=12710, 44 wallclock secs ( 2.36 usr 0.19 sys + 27.90 cusr 1.95 csys = 32.40 CPU)
Result: PASS


--
Phillip Smith
http://phillipadsmith.com
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On Jul 14, 2014, at 5:43 PM, Phillip Smith <ps@phillipadsmith.com> wrote:

> ➜ bricolage-2.1.0 git:(brewt-desk_fixes) ✗ make devtest
> All tests successful.
> Files=1, Tests=12710, 38 wallclock secs ( 2.01 usr 0.15 sys + 23.10 cusr 1.72 csys = 26.98 CPU)
> Result: PASS
>
> So, Bret's pull request is tested and working.
>
> I'm assuming I should not merge that into the master branch directly, but instead make a tag or some such? Git advises this:
>
> git checkout master
> git merge --no-ff brewt-desk_fixes
> git push origin master

I would merge it into rev-2.0, note the change there, then merge those changes into master. No need for --no-ff since it's a single commit.

> A couple more pointers, and I'll be on my way to working through the other pull requests. And, from there, WORLD DOMINATION (or maybe a release).

HTH,

D
Re: Anyone else seeing this in bric_queued.log ? [ In reply to ]
On Jul 14, 2014, at 5:59 PM, Phillip Smith <ps@phillipadsmith.com> wrote:

> This pull request passes too:
> https://github.com/bricoleurs/bricolage/pull/38

Merge it, same as instructions for the other one.

D