Mailing List Archive

Re: [bricolage] Desk pagination fixes (#47)
Hmmm…


➜ bricolage-2.1.0 git:(master) ✗ make test
PERL_DL_NONLAZY=1 /Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.3/bin/perl inst/runtests.pl
t/Bric/Test/Runner.pm .. 1347/? "my" variable $self masks earlier declaration in same scope at lib/Bric/App/Callback/Desk.pm line 218.

[lib/Bric.pm:931]
[lib/Bric/App/Callback/Desk.pm:218]
[lib/Bric/App/Callback/Desk.pm:218]
[lib/Bric/App/Callback/Desk.pm:218]
[/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.3/lib/5.16.3/Test/More.pm:967]
[(eval 440):4]
[/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/Test/Class.pm:289]
[/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/Test/Class.pm:392]
[t/Bric/Test/Runner.pm:101]
t/Bric/Test/Runner.pm .. ok
All tests successful.
Files=1, Tests=2610, 2 wallclock secs ( 0.35 usr 0.03 sys + 1.60 cusr 0.17 csys = 2.15 CPU)
Result: PASS

… what's going on here?

Phillip.

On 2014-02-19, at 3:09 PM, David E. Wheeler <david@justatheory.com> wrote:

> Looks like a pretty smart change. Who wants to merge it into the 2.0 maint and master branches and run the tests?
>
> Best,
>
> David
>
> Begin forwarded message:
>
>> From: Adrian Yee <notifications@github.com>
>> Subject: [bricolage] Desk pagination fixes (#47)
>> Date: February 18, 2014 at 7:36:32 PM PST
>> To: bricoleurs/bricolage <bricolage@noreply.github.com>
>> Reply-To: bricoleurs/bricolage <reply+i-27848709-1ce2742cc49cdce34544ea623cdf0396c1757be2-46604@reply.github.com>
>>
>> Fix two desk pagination bugs:
>>
>> Fatal error with paging
>> Current page isn't highlighted
>> You can merge this Pull Request by running
>>
>> git pull https://github.com/brewt/bricolage desk_fixes
>> Or view, comment on, or merge it at:
>>
>> https://github.com/bricoleurs/bricolage/pull/47
>>
>> Commit Summary
>>
>> Add desk/workspace paging fixes changelog entry.
>> Fix desk/workspace current page highlighting with paging.
>> Fix desk/workspace paging fatal error.
>> File Changes
>>
>> M comp/widgets/desk/desk.mc (2)
>> M comp/widgets/desk/desk_bottom.html (2)
>> M lib/Bric/Changes.pod (5)
>> Patch Links:
>>
>> https://github.com/bricoleurs/bricolage/pull/47.patch
>> https://github.com/bricoleurs/bricolage/pull/47.diff
>> —
>> Reply to this email directly or view it on GitHub.
>>
>

--
Phillip Smith
http://phillipadsmith.com
http://twitter.com/phillipadsmith
http://linkedin.com/in/phillipadsmith

Oaxaca: (011 52 1) 951 154 4620
Toronto: (647) 361-8248
Toll-free: (888) 418-1868

PGP: 25F7 F458 C261 B25B 5297 8F0A 518B F15D D63C 5D49

If your email inbox is out of control, check out http://sanebox.com/t/s0q7m

Save our in-boxes! http://emailcharter.org
Re: [bricolage] Desk pagination fixes (#47) [ In reply to ]
I feel like I've had historically bad follow through on this, but it's my turn to try and it has been on my list for months now.

Damn distractions! :(

I've got everything set-up on both of my machines now, so no excuses remain. I'll prioritize this for this weekend, or -- worst case -- Monday.

You around on IRC, David?

Phillip.

On 2014-02-19, at 3:09 PM, David E. Wheeler <david@justatheory.com> wrote:

> Looks like a pretty smart change. Who wants to merge it into the 2.0 maint and master branches and run the tests?
>
> Best,
>
> David
>
> Begin forwarded message:
>
>> From: Adrian Yee <notifications@github.com>
>> Subject: [bricolage] Desk pagination fixes (#47)
>> Date: February 18, 2014 at 7:36:32 PM PST
>> To: bricoleurs/bricolage <bricolage@noreply.github.com>
>> Reply-To: bricoleurs/bricolage <reply+i-27848709-1ce2742cc49cdce34544ea623cdf0396c1757be2-46604@reply.github.com>
>>
>> Fix two desk pagination bugs:
>>
>> Fatal error with paging
>> Current page isn't highlighted
>> You can merge this Pull Request by running
>>
>> git pull https://github.com/brewt/bricolage desk_fixes
>> Or view, comment on, or merge it at:
>>
>> https://github.com/bricoleurs/bricolage/pull/47
>>
>> Commit Summary
>>
>> Add desk/workspace paging fixes changelog entry.
>> Fix desk/workspace current page highlighting with paging.
>> Fix desk/workspace paging fatal error.
>> File Changes
>>
>> M comp/widgets/desk/desk.mc (2)
>> M comp/widgets/desk/desk_bottom.html (2)
>> M lib/Bric/Changes.pod (5)
>> Patch Links:
>>
>> https://github.com/bricoleurs/bricolage/pull/47.patch
>> https://github.com/bricoleurs/bricolage/pull/47.diff
>> —
>> Reply to this email directly or view it on GitHub.
>>
>

--
Phillip Smith
http://phillipadsmith.com
http://twitter.com/phillipadsmith
http://linkedin.com/in/phillipadsmith

Oaxaca: (011 52 1) 951 154 4620
Toronto: (647) 361-8248
Toll-free: (888) 418-1868

PGP: 25F7 F458 C261 B25B 5297 8F0A 518B F15D D63C 5D49

If your email inbox is out of control, check out http://sanebox.com/t/s0q7m

Save our in-boxes! http://emailcharter.org
Re: [bricolage] Desk pagination fixes (#47) [ In reply to ]
I'm not seeing a "2.0 maintenance" branch… that would be 'rev-2.0'? (Apologies if asking the obvious!)

On 2014-02-19, at 3:09 PM, David E. Wheeler <david@justatheory.com> wrote:

> Looks like a pretty smart change. Who wants to merge it into the 2.0 maint and master branches and run the tests?
>
> Best,
>
> David
>
> Begin forwarded message:
>
>> From: Adrian Yee <notifications@github.com>
>> Subject: [bricolage] Desk pagination fixes (#47)
>> Date: February 18, 2014 at 7:36:32 PM PST
>> To: bricoleurs/bricolage <bricolage@noreply.github.com>
>> Reply-To: bricoleurs/bricolage <reply+i-27848709-1ce2742cc49cdce34544ea623cdf0396c1757be2-46604@reply.github.com>
>>
>> Fix two desk pagination bugs:
>>
>> Fatal error with paging
>> Current page isn't highlighted
>> You can merge this Pull Request by running
>>
>> git pull https://github.com/brewt/bricolage desk_fixes
>> Or view, comment on, or merge it at:
>>
>> https://github.com/bricoleurs/bricolage/pull/47
>>
>> Commit Summary
>>
>> Add desk/workspace paging fixes changelog entry.
>> Fix desk/workspace current page highlighting with paging.
>> Fix desk/workspace paging fatal error.
>> File Changes
>>
>> M comp/widgets/desk/desk.mc (2)
>> M comp/widgets/desk/desk_bottom.html (2)
>> M lib/Bric/Changes.pod (5)
>> Patch Links:
>>
>> https://github.com/bricoleurs/bricolage/pull/47.patch
>> https://github.com/bricoleurs/bricolage/pull/47.diff
>> —
>> Reply to this email directly or view it on GitHub.
>>
>
Re: [bricolage] Desk pagination fixes (#47) [ In reply to ]
Further:

PERL_DL_NONLAZY=1 /Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.3/bin/perl inst/runtests.pl -d
t/Bric/Test/Runner.pm .. 1/? # expected 41 test(s) in Bric::Util::Pref::DevTest::test_list, 42 completed
t/Bric/Test/Runner.pm .. 696/?
# Failed test 'Checking that _fetch_objects produces the correct object structure'
# at t/Bric/Util/DBI/DevTest.pm line 98.
# (in Bric::Util::DBI::DevTest->test_fetch_objects)
# Structures begin differing at:
# $got->[2]{uuid} = '2FB9CEFE-2EC7-11E3-A539-9D8A6DADDCAC'
# $expected->[2]{uuid} = '3'

# Failed test 'offset of 2 gets last 2 objects'
# at t/Bric/Util/DBI/DevTest.pm line 155.
# (in Bric::Util::DBI::DevTest->test_fetch_objects)
# Structures begin differing at:
# $got->[0]{uuid} = '2FB9CEFE-2EC7-11E3-A539-9D8A6DADDCAC'
# $expected->[0]{uuid} = '3'

# Failed test 'can use limit and offset together to return middle 2 objects'
# at t/Bric/Util/DBI/DevTest.pm line 183.
# (in Bric::Util::DBI::DevTest->test_fetch_objects)
# Structures begin differing at:
# $got->[1]{uuid} = '2FB9CEFE-2EC7-11E3-A539-9D8A6DADDCAC'
# $expected->[1]{uuid} = '3'
t/Bric/Test/Runner.pm .. 5302/?
# Failed test 'Check for 5 servers'
# at t/Bric/Dist/Server/DevTest.pm line 233.
# (in Bric::Dist::Server::DevTest->test_href)
# got: '6'
# expected: '5'

# Failed test 'Check for 5 servers'
# at t/Bric/Dist/Server/DevTest.pm line 154.
# (in Bric::Dist::Server::DevTest->test_list)
# got: '6'
# expected: '5'

# Failed test 'Check for 5 server IDs'
# at t/Bric/Dist/Server/DevTest.pm line 308.
# (in Bric::Dist::Server::DevTest->test_list_ids)
# got: '6'
# expected: '5'
t/Bric/Test/Runner.pm .. 5904/?
# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 170.
# (in Bric::Dist::Action::Email::DevTest->test_href)
# got: '3'
# expected: '2'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 180.
# (in Bric::Dist::Action::Email::DevTest->test_href)
# got: '3'
# expected: '2'

# Failed test 'Check for 5 actions'
# at t/Bric/Dist/Action/DevTest.pm line 190.
# (in Bric::Dist::Action::Email::DevTest->test_href)
# got: '6'
# expected: '5'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 196.
# (in Bric::Dist::Action::Email::DevTest->test_href)
# got: '3'
# expected: '2'

# Failed test 'Check for 3 actions'
# at t/Bric/Dist/Action/DevTest.pm line 213.
# (in Bric::Dist::Action::Email::DevTest->test_href)
# got: '4'
# expected: '3'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 92.
# (in Bric::Dist::Action::Email::DevTest->test_list)
# got: '3'
# expected: '2'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 102.
# (in Bric::Dist::Action::Email::DevTest->test_list)
# got: '3'
# expected: '2'

# Failed test 'Check for 5 actions'
# at t/Bric/Dist/Action/DevTest.pm line 112.
# (in Bric::Dist::Action::Email::DevTest->test_list)
# got: '6'
# expected: '5'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 118.
# (in Bric::Dist::Action::Email::DevTest->test_list)
# got: '3'
# expected: '2'

# Failed test 'Check for 3 actions'
# at t/Bric/Dist/Action/DevTest.pm line 135.
# (in Bric::Dist::Action::Email::DevTest->test_list)
# got: '4'
# expected: '3'

# Failed test 'Check for 2 action IDs'
# at t/Bric/Dist/Action/DevTest.pm line 249.
# (in Bric::Dist::Action::Email::DevTest->test_list_ids)
# got: '3'
# expected: '2'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 259.
# (in Bric::Dist::Action::Email::DevTest->test_list_ids)
# got: '3'
# expected: '2'

# Failed test 'Check for 5 actions'
# at t/Bric/Dist/Action/DevTest.pm line 269.
# (in Bric::Dist::Action::Email::DevTest->test_list_ids)
# got: '6'
# expected: '5'

# Failed test 'Check for 2 action IDs'
# at t/Bric/Dist/Action/DevTest.pm line 275.
# (in Bric::Dist::Action::Email::DevTest->test_list_ids)
# got: '3'
# expected: '2'

# Failed test 'Check for 3 action IDs'
# at t/Bric/Dist/Action/DevTest.pm line 292.
# (in Bric::Dist::Action::Email::DevTest->test_list_ids)
# got: '4'
# expected: '3'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 170.
# (in Bric::Dist::Action::DTDValidate::DevTest->test_href)
# got: '3'
# expected: '2'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 180.
# (in Bric::Dist::Action::DTDValidate::DevTest->test_href)
# got: '3'
# expected: '2'

# Failed test 'Check for 5 actions'
# at t/Bric/Dist/Action/DevTest.pm line 190.
# (in Bric::Dist::Action::DTDValidate::DevTest->test_href)
# got: '6'
# expected: '5'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 196.
# (in Bric::Dist::Action::DTDValidate::DevTest->test_href)
# got: '3'
# expected: '2'

# Failed test 'Check for 3 actions'
# at t/Bric/Dist/Action/DevTest.pm line 213.
# (in Bric::Dist::Action::DTDValidate::DevTest->test_href)
# got: '4'
# expected: '3'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 92.
# (in Bric::Dist::Action::DTDValidate::DevTest->test_list)
# got: '3'
# expected: '2'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 102.
# (in Bric::Dist::Action::DTDValidate::DevTest->test_list)
# got: '3'
# expected: '2'

# Failed test 'Check for 5 actions'
# at t/Bric/Dist/Action/DevTest.pm line 112.
# (in Bric::Dist::Action::DTDValidate::DevTest->test_list)
# got: '6'
# expected: '5'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 118.
# (in Bric::Dist::Action::DTDValidate::DevTest->test_list)
# got: '3'
# expected: '2'

# Failed test 'Check for 3 actions'
# at t/Bric/Dist/Action/DevTest.pm line 135.
# (in Bric::Dist::Action::DTDValidate::DevTest->test_list)
# got: '4'
# expected: '3'

# Failed test 'Check for 2 action IDs'
# at t/Bric/Dist/Action/DevTest.pm line 249.
# (in Bric::Dist::Action::DTDValidate::DevTest->test_list_ids)
# got: '3'
# expected: '2'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 259.
# (in Bric::Dist::Action::DTDValidate::DevTest->test_list_ids)
# got: '3'
# expected: '2'

# Failed test 'Check for 5 actions'
# at t/Bric/Dist/Action/DevTest.pm line 269.
# (in Bric::Dist::Action::DTDValidate::DevTest->test_list_ids)
# got: '6'
# expected: '5'

# Failed test 'Check for 2 action IDs'
# at t/Bric/Dist/Action/DevTest.pm line 275.
# (in Bric::Dist::Action::DTDValidate::DevTest->test_list_ids)
# got: '3'
# expected: '2'

# Failed test 'Check for 3 action IDs'
# at t/Bric/Dist/Action/DevTest.pm line 292.
# (in Bric::Dist::Action::DTDValidate::DevTest->test_list_ids)
# got: '4'
# expected: '3'
t/Bric/Test/Runner.pm .. 6421/?
# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 170.
# (in Bric::Dist::Action::DevTest->test_href)
# got: '3'
# expected: '2'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 180.
# (in Bric::Dist::Action::DevTest->test_href)
# got: '3'
# expected: '2'

# Failed test 'Check for 5 actions'
# at t/Bric/Dist/Action/DevTest.pm line 190.
# (in Bric::Dist::Action::DevTest->test_href)
# got: '6'
# expected: '5'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 196.
# (in Bric::Dist::Action::DevTest->test_href)
# got: '3'
# expected: '2'

# Failed test 'Check for 3 actions'
# at t/Bric/Dist/Action/DevTest.pm line 213.
# (in Bric::Dist::Action::DevTest->test_href)
# got: '4'
# expected: '3'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 92.
# (in Bric::Dist::Action::DevTest->test_list)
# got: '3'
# expected: '2'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 102.
# (in Bric::Dist::Action::DevTest->test_list)
# got: '3'
# expected: '2'

# Failed test 'Check for 5 actions'
# at t/Bric/Dist/Action/DevTest.pm line 112.
# (in Bric::Dist::Action::DevTest->test_list)
# got: '6'
# expected: '5'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 118.
# (in Bric::Dist::Action::DevTest->test_list)
# got: '3'
# expected: '2'

# Failed test 'Check for 3 actions'
# at t/Bric/Dist/Action/DevTest.pm line 135.
# (in Bric::Dist::Action::DevTest->test_list)
# got: '4'
# expected: '3'

# Failed test 'Check for 2 action IDs'
# at t/Bric/Dist/Action/DevTest.pm line 249.
# (in Bric::Dist::Action::DevTest->test_list_ids)
# got: '3'
# expected: '2'

# Failed test 'Check for 2 actions'
# at t/Bric/Dist/Action/DevTest.pm line 259.
# (in Bric::Dist::Action::DevTest->test_list_ids)
# got: '3'
# expected: '2'

# Failed test 'Check for 5 actions'
# at t/Bric/Dist/Action/DevTest.pm line 269.
# (in Bric::Dist::Action::DevTest->test_list_ids)
# got: '6'
# expected: '5'

# Failed test 'Check for 2 action IDs'
# at t/Bric/Dist/Action/DevTest.pm line 275.
# (in Bric::Dist::Action::DevTest->test_list_ids)
# got: '3'
# expected: '2'

# Failed test 'Check for 3 action IDs'
# at t/Bric/Dist/Action/DevTest.pm line 292.
# (in Bric::Dist::Action::DevTest->test_list_ids)
# got: '4'
# expected: '3'
t/Bric/Test/Runner.pm .. 11651/? # expected 26 test(s) in Bric::Biz::Asset::Business::Media::Image::DevTest::test_alternate_thumb, 27 completed
t/Bric/Test/Runner.pm .. 12646/? # Looks like you failed 51 tests of 12710.
"my" variable $self masks earlier declaration in same scope at lib/Bric/App/Callback/Desk.pm line 218.

[lib/Bric.pm:931]
[lib/Bric/App/Callback/Desk.pm:218]
[lib/Bric/App/Callback/Desk.pm:218]
[lib/Bric/App/Callback/Desk.pm:218]
[/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.3/lib/5.16.3/Test/More.pm:967]
[(eval 693):4]
[/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/Test/Class.pm:289]
[/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/Test/Class.pm:392]
[t/Bric/Test/Runner.pm:101]
t/Bric/Test/Runner.pm .. Dubious, test returned 51 (wstat 13056, 0x3300)
Failed 51/12710 subtests
(less 566 skipped subtests: 12093 okay)

Test Summary Report
-------------------
t/Bric/Test/Runner.pm (Wstat: 13056 Tests: 12710 Failed: 51)
Failed tests: 1291, 1293-1294, 5497, 5533, 5569, 6181
6185, 6189, 6191, 6197, 6211, 6215, 6219
6221, 6227, 6241, 6245, 6249, 6251, 6257
6337, 6341, 6345, 6347, 6353, 6367, 6371
6375, 6377, 6383, 6397, 6401, 6405, 6407
6413, 6469, 6473, 6477, 6479, 6485, 6499
6503, 6507, 6509, 6515, 6529, 6533, 6537
6539, 6545
Non-zero exit status: 51
Files=1, Tests=12710, 37 wallclock secs ( 1.91 usr 0.15 sys + 22.31 cusr 1.62 csys = 25.99 CPU)
Result: FAIL
Failed 1/1 test programs. 51/12710 subtests failed.
make: *** [devtest] Error 51

Hrmph….

Phillip.

On 2014-02-22, at 5:29 PM, Phillip Smith <ps@phillipadsmith.com> wrote:

>
> Hmmm…
>
>
> ➜ bricolage-2.1.0 git:(master) ✗ make test
> PERL_DL_NONLAZY=1 /Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.3/bin/perl inst/runtests.pl
> t/Bric/Test/Runner.pm .. 1347/? "my" variable $self masks earlier declaration in same scope at lib/Bric/App/Callback/Desk.pm line 218.
>
> [lib/Bric.pm:931]
> [lib/Bric/App/Callback/Desk.pm:218]
> [lib/Bric/App/Callback/Desk.pm:218]
> [lib/Bric/App/Callback/Desk.pm:218]
> [/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.3/lib/5.16.3/Test/More.pm:967]
> [(eval 440):4]
> [/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/Test/Class.pm:289]
> [/Users/phillipadsmith/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/Test/Class.pm:392]
> [t/Bric/Test/Runner.pm:101]
> t/Bric/Test/Runner.pm .. ok
> All tests successful.
> Files=1, Tests=2610, 2 wallclock secs ( 0.35 usr 0.03 sys + 1.60 cusr 0.17 csys = 2.15 CPU)
> Result: PASS
>
> … what's going on here?
>
> Phillip.
>
> On 2014-02-19, at 3:09 PM, David E. Wheeler <david@justatheory.com> wrote:
>
>> Looks like a pretty smart change. Who wants to merge it into the 2.0 maint and master branches and run the tests?
>>
>> Best,
>>
>> David
>>
>> Begin forwarded message:
>>
>>> From: Adrian Yee <notifications@github.com>
>>> Subject: [bricolage] Desk pagination fixes (#47)
>>> Date: February 18, 2014 at 7:36:32 PM PST
>>> To: bricoleurs/bricolage <bricolage@noreply.github.com>
>>> Reply-To: bricoleurs/bricolage <reply+i-27848709-1ce2742cc49cdce34544ea623cdf0396c1757be2-46604@reply.github.com>
>>>
>>> Fix two desk pagination bugs:
>>>
>>> Fatal error with paging
>>> Current page isn't highlighted
>>> You can merge this Pull Request by running
>>>
>>> git pull https://github.com/brewt/bricolage desk_fixes
>>> Or view, comment on, or merge it at:
>>>
>>> https://github.com/bricoleurs/bricolage/pull/47
>>>
>>> Commit Summary
>>>
>>> Add desk/workspace paging fixes changelog entry.
>>> Fix desk/workspace current page highlighting with paging.
>>> Fix desk/workspace paging fatal error.
>>> File Changes
>>>
>>> M comp/widgets/desk/desk.mc (2)
>>> M comp/widgets/desk/desk_bottom.html (2)
>>> M lib/Bric/Changes.pod (5)
>>> Patch Links:
>>>
>>> https://github.com/bricoleurs/bricolage/pull/47.patch
>>> https://github.com/bricoleurs/bricolage/pull/47.diff
>>> —
>>> Reply to this email directly or view it on GitHub.
>>>
>>
>
> --
> Phillip Smith
> http://phillipadsmith.com
> http://twitter.com/phillipadsmith
> http://linkedin.com/in/phillipadsmith
>
> Oaxaca: (011 52 1) 951 154 4620
> Toronto: (647) 361-8248
> Toll-free: (888) 418-1868
>
> PGP: 25F7 F458 C261 B25B 5297 8F0A 518B F15D D63C 5D49
>
> If your email inbox is out of control, check out http://sanebox.com/t/s0q7m
>
> Save our in-boxes! http://emailcharter.org
>
Re: [bricolage] Desk pagination fixes (#47) [ In reply to ]
On Feb 19, 2014, at 1:09 PM, David E. Wheeler <david@justatheory.com> wrote:

> Looks like a pretty smart change. Who wants to merge it into the 2.0 maint and master branches and run the tests?

Anybody? Bueller?

Actually, just testing to see if the mail list still works, since there’s virtually no traffic…

David
Re: [bricolage] Desk pagination fixes (#47) [ In reply to ]
On 2014-02-23, at 7:14 PM, "David E. Wheeler" <david@justatheory.com> wrote:

> On Feb 19, 2014, at 1:09 PM, David E. Wheeler <david@justatheory.com> wrote:
>
>> Looks like a pretty smart change. Who wants to merge it into the 2.0 maint and master branches and run the tests?
>
> Anybody? Bueller?
>
> Actually, just testing to see if the mail list still works, since there’s virtually no traffic…


This came through on my end (finally). :)



--
Phillip Smith
http://phillipadsmith.com
Re: [bricolage] Desk pagination fixes (#47) [ In reply to ]
On Feb 20, 2014, at 1:33 PM, Phillip Smith <ps@phillipadsmith.com> wrote:

> You around on IRC, David?

Only by chance. I don’t work on weekends much anymore.

D
Re: [bricolage] Desk pagination fixes (#47) [ In reply to ]
On Feb 22, 2014, at 2:50 PM, Phillip Smith <ps@phillipadsmith.com> wrote:

> I'm not seeing a "2.0 maintenance" branch… that would be 'rev-2.0'? (Apologies if asking the obvious!)

Yes.

D