Mailing List Archive

[bricoleurs/bricolage] 6fbfba: Fix Back button when viewing an asset.
Branch: refs/heads/rev-2.0
Home: https://github.com/bricoleurs/bricolage

Commit: 6fbfbac9b29eb3ec9f2e4d4f0d9168c1187d9e75
https://github.com/bricoleurs/bricolage/commit/6fbfbac9b29eb3ec9f2e4d4f0d9168c1187d9e75
Author: David E. Wheeler <david@justatheory.com>
Date: 2011-12-01 (Thu, 01 Dec 2011)

Changed paths:
M comp/widgets/media_prof/view_meta.html
M comp/widgets/story_prof/view_meta.html
M comp/widgets/tmpl_prof/view_meta.html
M lib/Bric/App/Callback/Profile/Media.pm
M lib/Bric/App/Callback/Profile/Story.pm
M lib/Bric/App/Callback/Profile/Template.pm

Log Message:
-----------
Fix Back button when viewing an asset.

Has been broken by the HTML 5 standard, which has image inputs no longer submit their values, but their .x and .y positions. This is annoying, and more like how IE has always behaved. In [this commit](https://github.com/bricoleurs/bricolage/commit/534e739a34e6d71835033bcf560cb54745dd9222) (and others like it for media nd templates), Scott fixed a bug related to get the Return button to work on the diff view. Removing that change fixes the view Return button, but breaks the Diff return button. So switch to using a very simple image link for the Diff page return button instead of the image input. That works on any browser, and so now the Return button should work properly both when viewing assets and when viewing diffs.

[#240 state:closed]


Commit: 338ff3f722694ec0ac067830ea1809e2ecac92d5
https://github.com/bricoleurs/bricolage/commit/338ff3f722694ec0ac067830ea1809e2ecac92d5
Author: David E. Wheeler <david@justatheory.com>
Date: 2011-12-01 (Thu, 01 Dec 2011)

Changed paths:
M lib/Bric/Changes.pod

Log Message:
-----------
Document fix for Bug # 240 in Changes.


Commit: 5931980b727b1b7a3b7a1dbb133b838e83fd8cdf
https://github.com/bricoleurs/bricolage/commit/5931980b727b1b7a3b7a1dbb133b838e83fd8cdf
Author: David E. Wheeler <david@justatheory.com>
Date: 2011-12-01 (Thu, 01 Dec 2011)

Changed paths:
M lib/Bric/Changes.pod

Log Message:
-----------
Nick!


Compare: https://github.com/bricoleurs/bricolage/compare/4d4d18a...5931980