Mailing List Archive

Re: svn commit: r1907680 - /httpd/httpd/trunk/modules/dav/main/ms_wdv.c
On Wed, Feb 15, 2023 at 02:07:14PM -0000, manu@apache.org wrote:
> Author: manu
> Date: Wed Feb 15 14:07:14 2023
> New Revision: 1907680
>
> URL: http://svn.apache.org/viewvc?rev=1907680&view=rev
> Log:
> Fix warnings

Thanks! There are a still a couple more warnings with GCC 10 from a %s
argument being passed a constant NULL:

https://github.com/apache/httpd/actions/runs/4184691029/jobs/7250692033#step:10:2774

In function ‘mswdv_combined_lock’,
inlined from ‘dav_mswdv_preprocessing’ at /home/runner/work/httpd/httpd/modules/dav/main/ms_wdv.c:693:20:
/home/runner/work/httpd/httpd/include/http_log.h:454:23: error: ‘%s’ directive argument is null [-Werror=format-overflow=]
454 | #define ap_log_rerror ap_log_rerror_
/home/runner/work/httpd/httpd/modules/dav/main/ms_wdv.c:410:5: note: in expansion of macro ‘ap_log_rerror’
410 | ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r,
| ^~~~~~~~~~~~~
/home/runner/work/httpd/httpd/include/http_log.h:454:23: error: ‘%s’ directive argument is null [-Werror=format-overflow=]
454 | #define ap_log_rerror ap_log_rerror_
/home/runner/work/httpd/httpd/modules/dav/main/ms_wdv.c:410:5: note: in expansion of macro ‘ap_log_rerror’
410 | ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r,
| ^~~~~~~~~~~~~
cc1: all warnings being treated as errors