Mailing List Archive

On 2/13/23 5:48 PM, manu@apache.org wrote:
> Author: manu
> Date: Mon Feb 13 16:48:35 2023
> New Revision: 1907608
>
> URL: http://svn.apache.org/viewvc?rev=1907608&view=rev
> Log:
> Add MS-WDV support
>
> MS-WDV specification:
> https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-wdv
>
> The changes introduces the DAVMSext directive, which is used to
> enable MS-WDV: DAVMSext +WDV
>
> dav_get_timeout_string() is introduced as a variant of dav_get_timeout().
> The former parses a string, the later parse the Timeout HTTP header.
>
>
> Added:
> httpd/httpd/trunk/modules/dav/main/ms_wdv.c
> Modified:
> httpd/httpd/trunk/CMakeLists.txt
> httpd/httpd/trunk/modules/dav/main/NWGNUmakefile
> httpd/httpd/trunk/modules/dav/main/config5.m4
> httpd/httpd/trunk/modules/dav/main/mod_dav.c
> httpd/httpd/trunk/modules/dav/main/mod_dav.dsp
> httpd/httpd/trunk/modules/dav/main/mod_dav.h
> httpd/httpd/trunk/modules/dav/main/util.c
>

Noticed the below warnings when compiling:

ms_wdv.c: In function ‘mswdv_combined_lock’:
ms_wdv.c:496:55: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘time_t’ {aka ‘long int’} [-Wformat=]
apr_psprintf(r->pool, "Second-%d",
~^
%ld
newlock->timeout - time(NULL)));
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ms_wdv.c:183:9: warning: unused variable ‘locked_by_other’ [-Wunused-variable]
int locked_by_other = 0;
^~~~~~~~~~~~~~~
ms_wdv.c:171:18: warning: unused variable ‘status’ [-Wunused-variable]
apr_status_t status;
^~~~~~
ms_wdv.c: In function ‘mswdv_combined_propfind’:
ms_wdv.c:523:17: warning: unused variable ‘b’ [-Wunused-variable]
apr_bucket *b;
^
ms_wdv.c: In function ‘mswdv_combined_proppatch’:
ms_wdv.c:605:9: warning: unused variable ‘ret’ [-Wunused-variable]
int ret;
^~~
ms_wdv.c:604:18: warning: unused variable ‘rr’ [-Wunused-variable]
request_rec *rr;
^~
ms_wdv.c:603:18: warning: unused variable ‘f’ [-Wunused-variable]
ap_filter_t *f;
^
ms_wdv.c:602:16: warning: unused variable ‘proppatch_datalen’ [-Wunused-variable]
apr_size_t proppatch_datalen;
^~~~~~~~~~~~~~~~~
ms_wdv.c:601:15: warning: unused variable ‘index’ [-Wunused-variable]
apr_off_t index;
^~~~~
ms_wdv.c:596:11: warning: unused variable ‘proppach_data’ [-Wunused-variable]
char *proppach_data;
^~~~~~~~~~~~~
ms_wdv.c:594:17: warning: unused variable ‘b’ [-Wunused-variable]
apr_bucket *b;
^
ms_wdv.c:592:25: warning: unused variable ‘bbsub’ [-Wunused-variable]
apr_bucket_brigade *bbsub;
^~~~~
ms_wdv.c:591:16: warning: unused variable ‘err’ [-Wunused-variable]
dav_error *err = NULL;
^~~

Regards

Rüdiger