Mailing List Archive

problems with proxy worker and name_ex
Hi,

I think we have something wrong:
https://github.com/apache/httpd/blob/trunk/include/ap_mmn.h#L719
and
https://github.com/apache/httpd/blob/2.4.x/include/ap_mmn.h#L601

How external modules can detect that 2.4.x has diverged from trunk?
--
Cheers

Jean-Frederic
Re: problems with proxy worker and name_ex [ In reply to ]
On Wed, Jul 20, 2022 at 10:43 AM jean-frederic clere <jfclere@gmail.com> wrote:
>
> Hi,
>
> I think we have something wrong:
> https://github.com/apache/httpd/blob/trunk/include/ap_mmn.h#L719
> and
> https://github.com/apache/httpd/blob/2.4.x/include/ap_mmn.h#L601
>
> How external modules can detect that 2.4.x has diverged from trunk?

For 2.5.x/trunk (where PROXY_WORKER_MAX_NAME_SIZE bumped to 384):
#if AP_MODULE_MAGIC_AT_LEAST(20211221, 0)

For 2.4.x (where name_ex[PROXY_WORKER_EXT_NAME_SIZE] was added):
#if MODULE_MAGIC_NUMBER_MAJOR == 20120211 && MODULE_MAGIC_NUMBER_MINOR >= 124

?

Regards;
Yann.
Re: problems with proxy worker and name_ex [ In reply to ]
On 20/07/2022 11:09, Yann Ylavic wrote:
> On Wed, Jul 20, 2022 at 10:43 AM jean-frederic clere <jfclere@gmail.com> wrote:
>>
>> Hi,
>>
>> I think we have something wrong:
>> https://github.com/apache/httpd/blob/trunk/include/ap_mmn.h#L719
>> and
>> https://github.com/apache/httpd/blob/2.4.x/include/ap_mmn.h#L601
>>
>> How external modules can detect that 2.4.x has diverged from trunk?
>
> For 2.5.x/trunk (where PROXY_WORKER_MAX_NAME_SIZE bumped to 384):
> #if AP_MODULE_MAGIC_AT_LEAST(20211221, 0)
>
> For 2.4.x (where name_ex[PROXY_WORKER_EXT_NAME_SIZE] was added):
> #if MODULE_MAGIC_NUMBER_MAJOR == 20120211 && MODULE_MAGIC_NUMBER_MINOR >= 124
>
> ?
Oops too tired today... Sorry for the noises... Thanks ;-)

>
> Regards;
> Yann.


--
Cheers

Jean-Frederic