Mailing List Archive

[VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54
Hi all,

Please find below the proposed release tarball and signatures:

https://dist.apache.org/repos/dist/dev/httpd/

I would like to call a VOTE over the next few days (at least
up to and including Monday) to release this candidate tarball
httpd-2.4.54-rc1 as 2.4.54:
[ ] +1: It's not just good, it's good enough!
[ ] +0: Let's have a talk.
[ ] -1: There's trouble in paradise. Here's what's wrong.

The computed digests of the tarball up for vote are:
sha256: 06d4b6f769afb2f80e5b5857be3411a8f13368de01ffe952ccd918309bc49a69 *httpd-2.4.54-rc1.tar.gz
sha512: 32c00a09562323e030a459313545f1242244f2f7cad2c07006930c9b9e65b79ab267ca321ee24b826d1d9c0caaed2078fac9793ed380a6176bc7b3fe92fe2b37 *httpd-2.4.54-rc1.tar.gz

The SVN candidate source is found at tags/2.4.54-rc1-candidate.

Kind Regards,
Stefan
Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54 [ In reply to ]
-1

Does not build :


Error C2018 C:\VC16\Win32\httpd-2.4\server\core_filters.c
638 unknown character '0x40'




On Friday 03/06/2022 at 16:57, Stefan Eissing wrote:
> Hi all,
>
> Please find below the proposed release tarball and signatures:
>
> https://dist.apache.org/repos/dist/dev/httpd/
>
> I would like to call a VOTE over the next few days (at least
> up to and including Monday) to release this candidate tarball
> httpd-2.4.54-rc1 as 2.4.54:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
>
> The computed digests of the tarball up for vote are:
> sha256:
> 06d4b6f769afb2f80e5b5857be3411a8f13368de01ffe952ccd918309bc49a69
> *httpd-2.4.54-rc1.tar.gz
> sha512:
> 32c00a09562323e030a459313545f1242244f2f7cad2c07006930c9b9e65b79ab267ca321ee24b826d1d9c0caaed2078fac9793ed380a6176bc7b3fe92fe2b37
> *httpd-2.4.54-rc1.tar.gz
>
> The SVN candidate source is found at tags/2.4.54-rc1-candidate.
>
> Kind Regards,
> Stefan
Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54 [ In reply to ]
> Am 04.06.2022 um 11:23 schrieb SteffenAL <info@apachelounge.com>:
>
> -1
>
> Does not build :
>
> Error C2018 C:\VC16\Win32\httpd-2.4\server\core_filters.c 638 unknown character '0x40'

Hmm, 0x40 would be ‘@‘ and on line 638 there is none. Could you find out more what the offending code piece is?

Thanks,
Stefan

>
>
>
> On Friday 03/06/2022 at 16:57, Stefan Eissing wrote:
>> Hi all,
>>
>> Please find below the proposed release tarball and signatures:
>>
>> https://dist.apache.org/repos/dist/dev/httpd/
>>
>> I would like to call a VOTE over the next few days (at least
>> up to and including Monday) to release this candidate tarball
>> httpd-2.4.54-rc1 as 2.4.54:
>> [ ] +1: It's not just good, it's good enough!
>> [ ] +0: Let's have a talk.
>> [ ] -1: There's trouble in paradise. Here's what's wrong.
>>
>> The computed digests of the tarball up for vote are:
>> sha256: 06d4b6f769afb2f80e5b5857be3411a8f13368de01ffe952ccd918309bc49a69 *httpd-2.4.54-rc1.tar.gz
>> sha512: 32c00a09562323e030a459313545f1242244f2f7cad2c07006930c9b9e65b79ab267ca321ee24b826d1d9c0caaed2078fac9793ed380a6176bc7b3fe92fe2b37 *httpd-2.4.54-rc1.tar.gz
>>
>> The SVN candidate source is found at tags/2.4.54-rc1-candidate.
>>
>> Kind Regards,
>> Stefan
>
>
Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54 [ In reply to ]
Thats all the compiler says.

This can happen when copied code from one machine (OS) to another,
causing encoding issues.

https://stackoverflow.com/questions/1169670/how-to-interpret-error-c2018-unknown-character-0x40


On Saturday 04/06/2022 at 12:11, Stefan Eissing wrote:
>
>
>>
>> Am 04.06.2022 um 11:23 schrieb SteffenAL <info@apachelounge.com>:
>>
>> -1
>>
>> Does not build :
>>
>> Error
>> C2018 C:\VC16\Win32\httpd-2.4\server\core_filters.c 638 unknown
>> character '0x40'
>
> Hmm, 0x40 would be ‘@‘ and on line 638 there is none. Could you
> find out more what the offending code piece is?
>
> Thanks,
> Stefan
>
>>
>>
>>
>>
>> On Friday 03/06/2022 at 16:57, Stefan Eissing wrote:
>>>
>>> Hi all,
>>>
>>> Please find below the proposed release tarball and signatures:
>>>
>>> https://dist.apache.org/repos/dist/dev/httpd/
>>>
>>> I would like to call a VOTE over the next few days (at least
>>> up to and including Monday) to release this candidate tarball
>>> httpd-2.4.54-rc1 as 2.4.54:
>>> [ ] +1: It's not just good, it's good enough!
>>> [ ] +0: Let's have a talk.
>>> [ ] -1: There's trouble in paradise. Here's what's wrong.
>>>
>>> The computed digests of the tarball up for vote are:
>>> sha256:
>>> 06d4b6f769afb2f80e5b5857be3411a8f13368de01ffe952ccd918309bc49a69
>>> *httpd-2.4.54-rc1.tar.gz
>>> sha512:
>>> 32c00a09562323e030a459313545f1242244f2f7cad2c07006930c9b9e65b79ab267ca321ee24b826d1d9c0caaed2078fac9793ed380a6176bc7b3fe92fe2b37
>>> *httpd-2.4.54-rc1.tar.gz
>>>
>>> The SVN candidate source is found at tags/2.4.54-rc1-candidate.
>>>
>>> Kind Regards,
>>> Stefan
>>
>>
>
Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54 [ In reply to ]
Gregg told me:

r1901201 was introduced 10 days ago. If I revert the commit, it
compiles. I have not tested yet beyond the It works! page but I do get
that far.


On Saturday 04/06/2022 at 12:35, SteffenAL wrote:
>
>
> Thats all the compiler says.
>
> This can happen when copied code from one machine (OS) to another,
> causing encoding issues.
>
> https://stackoverflow.com/questions/1169670/how-to-interpret-error-c2018-unknown-character-0x40
>
>
> On Saturday 04/06/2022 at 12:11, Stefan Eissing wrote:
>>
>>
>>>
>>> Am 04.06.2022 um 11:23 schrieb SteffenAL <info@apachelounge.com>:
>>>
>>> -1
>>>
>>> Does not build :
>>>
>>> Error
>>> C2018 C:\VC16\Win32\httpd-2.4\server\core_filters.c 638 unknown
>>> character '0x40'
>>
>> Hmm, 0x40 would be ‘@‘ and on line 638 there is none. Could you
>> find out more what the offending code piece is?
>>
>> Thanks,
>> Stefan
>>
>>>
>>>
>>>
>>>
>>> On Friday 03/06/2022 at 16:57, Stefan Eissing wrote:
>>>>
>>>> Hi all,
>>>>
>>>> Please find below the proposed release tarball and signatures:
>>>>
>>>> https://dist.apache.org/repos/dist/dev/httpd/
>>>>
>>>> I would like to call a VOTE over the next few days (at least
>>>> up to and including Monday) to release this candidate tarball
>>>> httpd-2.4.54-rc1 as 2.4.54:
>>>> [ ] +1: It's not just good, it's good enough!
>>>> [ ] +0: Let's have a talk.
>>>> [ ] -1: There's trouble in paradise. Here's what's wrong.
>>>>
>>>> The computed digests of the tarball up for vote are:
>>>> sha256:
>>>> 06d4b6f769afb2f80e5b5857be3411a8f13368de01ffe952ccd918309bc49a69
>>>> *httpd-2.4.54-rc1.tar.gz
>>>> sha512:
>>>> 32c00a09562323e030a459313545f1242244f2f7cad2c07006930c9b9e65b79ab267ca321ee24b826d1d9c0caaed2078fac9793ed380a6176bc7b3fe92fe2b37
>>>> *httpd-2.4.54-rc1.tar.gz
>>>>
>>>> The SVN candidate source is found at tags/2.4.54-rc1-candidate.
>>>>
>>>> Kind Regards,
>>>> Stefan
>>>
>>>
>>
>
Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54 [ In reply to ]
How is the definition in your include/apr.h for APR_TCP_NOPUSH_FLAG? On my macOS it is:

#define APR_TCP_NOPUSH_FLAG TCP_NOPUSH

It maybe that the added lines

#if APR_TCP_NOPUSH_FLAG && !defined(__APPLE__)

needs a check for Windows too?

> Am 04.06.2022 um 12:49 schrieb SteffenAL <info@apachelounge.com>:
>
> r1901201
Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54 [ In reply to ]
No apr.h in httpd/include. In APR yes, but not the line you mention.

I am going out of town now. Monday again.

Maybe Gregg can chime in.




> Op 4 jun. 2022 om 13:18 heeft Stefan Eissing <stefan@eissing.org> het volgende geschreven:
>
> ?How is the definition in your include/apr.h for APR_TCP_NOPUSH_FLAG? On my macOS it is:
>
> #define APR_TCP_NOPUSH_FLAG TCP_NOPUSH
>
> It maybe that the added lines
>
> #if APR_TCP_NOPUSH_FLAG && !defined(__APPLE__)
>
> needs a check for Windows too?
>
>> Am 04.06.2022 um 12:49 schrieb SteffenAL <info@apachelounge.com>:
>>
>> r1901201
>
Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54 [ In reply to ]
On Sat, Jun 4, 2022 at 7:11 AM Stefan Eissing <stefan@eissing.org> wrote:
>
> How is the definition in your include/apr.h for APR_TCP_NOPUSH_FLAG? On my macOS it is:
>
> #define APR_TCP_NOPUSH_FLAG TCP_NOPUSH
>
> It maybe that the added lines
>
> #if APR_TCP_NOPUSH_FLAG && !defined(__APPLE__)
>
> needs a check for Windows too?

On my fork which is the only thing I can easily rebuild on Windows:

C:\cygwin64\home\ihstest\SRC\2.4.x\server\core_filters.c(87) : fatal
error C1017: invalid integer constant expression^M

srclib/apr/cmakebuild/apr.h:#define APR_TCP_NOPUSH_FLAG

I think whatever APR is missing 892162 from apr-trunk which defines this to 0.

We should put some kind of hack into httpd I guess. I will do some
trial and error in my sandbox.

--
Eric Covener
covener@gmail.com
Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54 [ In reply to ]
2.4.x ready to reroll

On Sat, Jun 4, 2022 at 7:36 AM Eric Covener <covener@gmail.com> wrote:
>
> On Sat, Jun 4, 2022 at 7:11 AM Stefan Eissing <stefan@eissing.org> wrote:
> >
> > How is the definition in your include/apr.h for APR_TCP_NOPUSH_FLAG? On my macOS it is:
> >
> > #define APR_TCP_NOPUSH_FLAG TCP_NOPUSH
> >
> > It maybe that the added lines
> >
> > #if APR_TCP_NOPUSH_FLAG && !defined(__APPLE__)
> >
> > needs a check for Windows too?
>
> On my fork which is the only thing I can easily rebuild on Windows:
>
> C:\cygwin64\home\ihstest\SRC\2.4.x\server\core_filters.c(87) : fatal
> error C1017: invalid integer constant expression^M
>
> srclib/apr/cmakebuild/apr.h:#define APR_TCP_NOPUSH_FLAG
>
> I think whatever APR is missing 892162 from apr-trunk which defines this to 0.
>
> We should put some kind of hack into httpd I guess. I will do some
> trial and error in my sandbox.
>
> --
> Eric Covener
> covener@gmail.com



--
Eric Covener
covener@gmail.com
Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54 [ In reply to ]
> Am 04.06.2022 um 14:08 schrieb Eric Covener <covener@gmail.com>:
>
> 2.4.x ready to reroll

Nice! Thanks Eric. Will roll an rc2 in a few minutes.

Cheers, Stefan

>
> On Sat, Jun 4, 2022 at 7:36 AM Eric Covener <covener@gmail.com> wrote:
>>
>> On Sat, Jun 4, 2022 at 7:11 AM Stefan Eissing <stefan@eissing.org> wrote:
>>>
>>> How is the definition in your include/apr.h for APR_TCP_NOPUSH_FLAG? On my macOS it is:
>>>
>>> #define APR_TCP_NOPUSH_FLAG TCP_NOPUSH
>>>
>>> It maybe that the added lines
>>>
>>> #if APR_TCP_NOPUSH_FLAG && !defined(__APPLE__)
>>>
>>> needs a check for Windows too?
>>
>> On my fork which is the only thing I can easily rebuild on Windows:
>>
>> C:\cygwin64\home\ihstest\SRC\2.4.x\server\core_filters.c(87) : fatal
>> error C1017: invalid integer constant expression^M
>>
>> srclib/apr/cmakebuild/apr.h:#define APR_TCP_NOPUSH_FLAG
>>
>> I think whatever APR is missing 892162 from apr-trunk which defines this to 0.
>>
>> We should put some kind of hack into httpd I guess. I will do some
>> trial and error in my sandbox.
>>
>> --
>> Eric Covener
>> covener@gmail.com
>
>
>
> --
> Eric Covener
> covener@gmail.com
Re: [VOTE] Release httpd-2.4.54-rc1 as httpd-2.4.54 [ In reply to ]
This vote is cancelled due to build problems under Windows.

I'll create a rc2 candidate and post that for voting soon.

Thanks everyone.

> Am 03.06.2022 um 16:57 schrieb Stefan Eissing <stefan@eissing.org>:
>
> Hi all,
>
> Please find below the proposed release tarball and signatures:
>
> https://dist.apache.org/repos/dist/dev/httpd/
>
> I would like to call a VOTE over the next few days (at least
> up to and including Monday) to release this candidate tarball
> httpd-2.4.54-rc1 as 2.4.54:
> [ ] +1: It's not just good, it's good enough!
> [ ] +0: Let's have a talk.
> [ ] -1: There's trouble in paradise. Here's what's wrong.
>
> The computed digests of the tarball up for vote are:
> sha256: 06d4b6f769afb2f80e5b5857be3411a8f13368de01ffe952ccd918309bc49a69 *httpd-2.4.54-rc1.tar.gz
> sha512: 32c00a09562323e030a459313545f1242244f2f7cad2c07006930c9b9e65b79ab267ca321ee24b826d1d9c0caaed2078fac9793ed380a6176bc7b3fe92fe2b37 *httpd-2.4.54-rc1.tar.gz
>
> The SVN candidate source is found at tags/2.4.54-rc1-candidate.
>
> Kind Regards,
> Stefan