Advanced
Mailing List Archive

Mailing List Archive

  1. Home >
  2. Apache>
  3. Dev
Re: svn commit: r1901554 - /httpd/test/framework/trunk/t/modules/sed.t
ylavic.dev at gmail
Jun 2, 2022, 9:54 AM
Post #1 of 4 (295 views)
Permalink
On Thu, Jun 2, 2022 at 1:04 PM <rpluem@apache.org> wrote:
>
> Author: rpluem
> Date: Thu Jun 2 11:04:13 2022
> New Revision: 1901554
>
> URL: http://svn.apache.org/viewvc?rev=1901554&view=rev
> Log:
> * Test returns 200, but content is !!!ERROR!!!

On my machine it returns 400 (hitting the mem limit) with html content..

Also I can't the "plan" line to work, the 'need
"LWP::Protocol::AnyEvent::http"' raises the same error as the
(currently failing) ci:
Test::plan(): skipping unrecognized directive '1' at
/home/yle/src/apache/asf/httpd/trunk.head/framework/Apache-Test/lib/Apache/Test.pm
line 298.
I tried with and without the "need" keyword or with "need_lwp,
qw(LWP::Protocol::AnyEvent::http)" like it's done elsewhere, to no
avail.
Sorry my Apache::Test foo is quite limited..

The only thing working here is the attached patch, but I guess we need
to make everyone happy (including travis) :)

Regards;
Yann.

Attached Files:

Re: svn commit: r1901554 - /httpd/test/framework/trunk/t/modules/sed.t [ In reply to ]
rpluem at apache
Jun 2, 2022, 1:15 PM
Post #2 of 4 (293 views)
Permalink
On 6/2/22 6:54 PM, Yann Ylavic wrote:
> On Thu, Jun 2, 2022 at 1:04 PM <rpluem@apache.org> wrote:
>>
>> Author: rpluem
>> Date: Thu Jun 2 11:04:13 2022
>> New Revision: 1901554
>>
>> URL: http://svn.apache.org/viewvc?rev=1901554&view=rev
>> Log:
>> * Test returns 200, but content is !!!ERROR!!!
>
> On my machine it returns 400 (hitting the mem limit) with html content..

This is quite strange. On mine it does not and this is also what reading the code of echo_post_handler
in c-modules/echo_post/mod_echo_post.c tells me as ap_get_client_block fails.

>
> Also I can't the "plan" line to work, the 'need
> "LWP::Protocol::AnyEvent::http"' raises the same error as the
> (currently failing) ci:
> Test::plan(): skipping unrecognized directive '1' at
> /home/yle/src/apache/asf/httpd/trunk.head/framework/Apache-Test/lib/Apache/Test.pm
> line 298.
> I tried with and without the "need" keyword or with "need_lwp,
> qw(LWP::Protocol::AnyEvent::http)" like it's done elsewhere, to no
> avail.
> Sorry my Apache::Test foo is quite limited..

Hopefully r1901566 fixed this.

Regards

Rüdiger
Re: svn commit: r1901554 - /httpd/test/framework/trunk/t/modules/sed.t [ In reply to ]
rpluem at apache
Jun 2, 2022, 1:16 PM
Post #3 of 4 (293 views)
Permalink
On 6/2/22 10:15 PM, Ruediger Pluem wrote:
>
>
> On 6/2/22 6:54 PM, Yann Ylavic wrote:
>> On Thu, Jun 2, 2022 at 1:04 PM <rpluem@apache.org> wrote:
>>>
>>> Author: rpluem
>>> Date: Thu Jun 2 11:04:13 2022
>>> New Revision: 1901554
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1901554&view=rev
>>> Log:
>>> * Test returns 200, but content is !!!ERROR!!!
>>
>> On my machine it returns 400 (hitting the mem limit) with html content..
>
> This is quite strange. On mine it does not and this is also what reading the code of echo_post_handler
> in c-modules/echo_post/mod_echo_post.c tells me as ap_get_client_block fails.

Error messages:

[Thu Jun 02 22:00:57.445702 2022] [sed:error] [pid 253311:tid 139929220736768] (12)Cannot allocate memory: [client
127.0.0.1:47366] AH10395: error evaluating sed on input
[Thu Jun 02 22:00:57.445714 2022] [:debug] [pid 253311:tid 139929220736768] mod_echo_post.c(85): [client 127.0.0.1:47366]
[mod_echo_post] ap_get_client_block got error
[Thu Jun 02 22:00:57.445715 2022] [:debug] [pid 253311:tid 139929220736768] mod_echo_post.c(96): [client 127.0.0.1:47366]
[mod_echo_post] done reading 0 bytes, 12582912 bytes remain


Regards

Rüdiger
Re: svn commit: r1901554 - /httpd/test/framework/trunk/t/modules/sed.t [ In reply to ]
covener at gmail
Jun 2, 2022, 1:25 PM
Post #4 of 4 (293 views)
Permalink
On Thu, Jun 2, 2022 at 4:17 PM Ruediger Pluem <rpluem@apache.org> wrote:
>
>
>
> On 6/2/22 10:15 PM, Ruediger Pluem wrote:
> >
> >
> > On 6/2/22 6:54 PM, Yann Ylavic wrote:
> >> On Thu, Jun 2, 2022 at 1:04 PM <rpluem@apache.org> wrote:
> >>>
> >>> Author: rpluem
> >>> Date: Thu Jun 2 11:04:13 2022
> >>> New Revision: 1901554
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=1901554&view=rev
> >>> Log:
> >>> * Test returns 200, but content is !!!ERROR!!!
> >>
> >> On my machine it returns 400 (hitting the mem limit) with html content..
> >
> > This is quite strange. On mine it does not and this is also what reading the code of echo_post_handler
> > in c-modules/echo_post/mod_echo_post.c tells me as ap_get_client_block fails.
>
> Error messages:
>
> [Thu Jun 02 22:00:57.445702 2022] [sed:error] [pid 253311:tid 139929220736768] (12)Cannot allocate memory: [client
> 127.0.0.1:47366] AH10395: error evaluating sed on input
> [Thu Jun 02 22:00:57.445714 2022] [:debug] [pid 253311:tid 139929220736768] mod_echo_post.c(85): [client 127.0.0.1:47366]
> [mod_echo_post] ap_get_client_block got error
> [Thu Jun 02 22:00:57.445715 2022] [:debug] [pid 253311:tid 139929220736768] mod_echo_post.c(96): [client 127.0.0.1:47366]
> [mod_echo_post] done reading 0 bytes, 12582912 bytes remain


Sorry for the headache. I think ap_get_client_block() is not expected
to fail here. Maybe it's some perl issue.
The sed line limit is what should make this test give up, not a
generic body limit.

I think we should just comment it out.

©2024 GT.net. A Gossamer Threads company.
5th Floor, 455 Granville St., Vancouver, BC V6C 1T1, Canada | Legal