Mailing List Archive

Re: svn commit: r1900356 - in /httpd/httpd/trunk: changes-entries/pr66037.txt modules/http2/h2_util.c modules/http2/h2_util.h
Le 28/04/2022 à 12:41, icing@apache.org a écrit :
> Author: icing
> Date: Thu Apr 28 10:41:48 2022
> New Revision: 1900356
>
> URL: http://svn.apache.org/viewvc?rev=1900356&view=rev
> Log:
> *) mod_http2: remove unused and insecure code. Fixes PR66037.
> Thanks to Ronald Crane (Zippenhop LLC) for reporting this.
>
>
> Added:
> httpd/httpd/trunk/changes-entries/pr66037.txt
> Modified:
> httpd/httpd/trunk/modules/http2/h2_util.c
> httpd/httpd/trunk/modules/http2/h2_util.h
>
> Added: httpd/httpd/trunk/changes-entries/pr66037.txt
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/changes-entries/pr66037.txt?rev=1900356&view=auto
> ==============================================================================
> --- httpd/httpd/trunk/changes-entries/pr66037.txt (added)
> +++ httpd/httpd/trunk/changes-entries/pr66037.txt Thu Apr 28 10:41:48 2022
> @@ -0,0 +1,3 @@
> + *) mod_http2: remove unused and insecure code. Fixes PR66037.
> + Thanks to Ronald Crane (Zippenhop LLC) for reporting this.
> + [Stefan Eissing]

Hi Stefan,

Missing vote for this trivial clean-up?

CJ

> \ No newline at end of file
>
> Modified: httpd/httpd/trunk/modules/http2/h2_util.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/h2_util.c?rev=1900356&r1=1900355&r2=1900356&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/http2/h2_util.c (original)
> +++ httpd/httpd/trunk/modules/http2/h2_util.c Thu Apr 28 10:41:48 2022
> @@ -76,26 +76,6 @@ size_t h2_util_hex_dump(char *buffer, si
> return strlen(buffer);
> }
>
> -size_t h2_util_header_print(char *buffer, size_t maxlen,
> - const char *name, size_t namelen,
> - const char *value, size_t valuelen)
> -{
> - size_t offset = 0;
> - size_t i;
> - for (i = 0; i < namelen && offset < maxlen; ++i, ++offset) {
> - buffer[offset] = name[i];
> - }
> - for (i = 0; i < 2 && offset < maxlen; ++i, ++offset) {
> - buffer[offset] = ": "[i];
> - }
> - for (i = 0; i < valuelen && offset < maxlen; ++i, ++offset) {
> - buffer[offset] = value[i];
> - }
> - buffer[offset] = '\0';
> - return offset;
> -}
> -
> -
> void h2_util_camel_case_header(char *s, size_t len)
> {
> size_t start = 1;
>
> Modified: httpd/httpd/trunk/modules/http2/h2_util.h
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/h2_util.h?rev=1900356&r1=1900355&r2=1900356&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/http2/h2_util.h (original)
> +++ httpd/httpd/trunk/modules/http2/h2_util.h Thu Apr 28 10:41:48 2022
> @@ -28,10 +28,6 @@ struct nghttp2_frame;
> size_t h2_util_hex_dump(char *buffer, size_t maxlen,
> const char *data, size_t datalen);
>
> -size_t h2_util_header_print(char *buffer, size_t maxlen,
> - const char *name, size_t namelen,
> - const char *value, size_t valuelen);
> -
> void h2_util_camel_case_header(char *s, size_t len);
>
> int h2_util_frame_print(const nghttp2_frame *frame, char *buffer, size_t maxlen);
>
>
>