Mailing List Archive

On Wed, Sep 8, 2021 at 3:23 PM Yann Ylavic <ylavic.dev@gmail.com> wrote:
>
> On Wed, Sep 8, 2021 at 3:00 PM <icing@apache.org> wrote:
> >
> > Author: icing
> > Date: Wed Sep 8 13:00:17 2021
> > New Revision: 1893136
> >
> > URL: http://svn.apache.org/viewvc?rev=1893136&view=rev
> > Log:
> > Tag branches/2.4.x@1893131 as 2.4.49-rc1
> >
> > Added:
> > httpd/httpd/tags/candidate-2.4.49-rc1/ (props changed)
> > - copied from r1893131, httpd/httpd/branches/2.4.x/
>
> Maybe the script should bail out if `make update-log-tags
> update-changes` would do anything?

Something like the attached patch maybe?

On Wed, Sep 8, 2021 at 4:06 PM Yann Ylavic <ylavic.dev@gmail.com> wrote:
>
> On Wed, Sep 8, 2021 at 3:23 PM Yann Ylavic <ylavic.dev@gmail.com> wrote:
> >
> > On Wed, Sep 8, 2021 at 3:00 PM <icing@apache.org> wrote:
> > >
> > > Author: icing
> > > Date: Wed Sep 8 13:00:17 2021
> > > New Revision: 1893136
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1893136&view=rev
> > > Log:
> > > Tag branches/2.4.x@1893131 as 2.4.49-rc1
> > >
> > > Added:
> > > httpd/httpd/tags/candidate-2.4.49-rc1/ (props changed)
> > > - copied from r1893131, httpd/httpd/branches/2.4.x/
> >
> > Maybe the script should bail out if `make update-log-tags
> > update-changes` would do anything?
>
> Something like the attached patch maybe?

Well it looks more complicated than that, no Makefile on fresh checkout.
So I borrowed the right command from tag.sh I got this v2 instead
(attached, not tested..).

Also we probably shouldn't put a potential failure for update-log-tags
on the RM (let's not lose you this far :), so the patch is checking
for update-changes only.

Cheers;
Yann.