Mailing List Archive

Trunk errors
Tried revision 1877505.

libhttpd :
miss in trunk modules\http\http_etag.c. Moved the one from Branches to
include, libhttpd builds then, is that ok ?

mod_cache :
#include "test_char.h" not found. Copied the generated
server/test_char.h to /include, mod_cache builds then, is that ok ?

htdbm and htpasswd :
support\passwd_common.h(31,10): fatal error C1083: Cannot open include
file: 'ap_config_auto.h': No such file or directory.

mod_ssl :
ssl_engine_io.obj : error LNK2019: unresolved external symbol
_ap_filter_adopt_brigade referenced in function _char_buffer_insert

Looks like all the errors are related to changes in/after 2018. In
2018 I build it without errors.

Did not build all yet and only Win32 VS16, so maybe more to come.


Steffen
Re: Trunk errors [ In reply to ]
Hi Steffen,


Assuming your building in the IDE as I know to be your usual;

On 5/8/2020 4:59 AM, Steffen wrote:
>
>
> Tried revision 1877505.
>
> libhttpd :
> miss in trunk modules\http\http_etag.c. Moved the one from Branches to
> include, libhttpd builds then, is that ok ?
>
Yes to get it to build for now. Question is why isn't it in trunk,
modules/http like it is in branches or anywhere (quick look and I can't
see it).

> mod_cache :
> #include "test_char.h"  not found.  Copied the generated
> server/test_char.h to /include, mod_cache builds then, is that ok ?
>
Yes to get it to build for now. We may just need to change the location
it's generated to, or just point to it's location in the build. If it's
not a public header then we do the second option. I'll look at that.

> htdbm and htpasswd :
> support\passwd_common.h(31,10): fatal error C1083: Cannot open include
> file: 'ap_config_auto.h': No such file or directory.
>
This gives me a deja vu feeling with what stopped mod_ssl from building
in 2.4.42. The winbuilds dsp/mak files generate headers by copying a
.h.in file of the same name like ap_config_layout.h.in. This deja vu
feeling tells me just feeding it an empty ap_config_auto.h will not do.
It might build at least and seem to work but wouldn't be correct.
Yann? :)

> mod_ssl :
> ssl_engine_io.obj : error LNK2019: unresolved external symbol
> _ap_filter_adopt_brigade referenced in function _char_buffer_insert
>
AFAIK all ap_* functions are in libhttpd, maybe we're not
compiling/linking a new file. It looks to be in util_filters.c and that
shows as being compiled/linked to libhttpd. ???Huh???

> Looks like all the errors are related to changes in/after 2018. In 2018
> I build it without errors.
>
> Did not build all yet and only Win32 VS16, so maybe more to come.
Let's get it building on one version first, worry about any nuances in
the various VC versions second.


Gregg
Re: Trunk errors [ In reply to ]
Forget mod_ssl error below for now.

The first error is: ssl\ssl_engine_io.c(33,10): fatal error C1083:
Cannot open include file: 'core.h'

When I copy core.h to mod_ssl dir, then I get below error.

Tried also link with libhttpd.lib, no go.

So first solve the core.h error.




On Saturday 09/05/2020 at 01:10, Gregg Smith wrote:
> Hi Steffen,
>
>
> Assuming your building in the IDE as I know to be your usual;
>
> On 5/8/2020 4:59 AM, Steffen wrote:
>>
>> Tried revision 1877505.
>> libhttpd :
>> miss in trunk modules\http\http_etag.c. Moved the one from Branches to
>> include, libhttpd builds then, is that ok ?
>> Yes to get it to build for now. Question is why isn't it in trunk,
>> modules/http like it is in branches or anywhere (quick look and I
>> can't see it).
>
>>
>> mod_cache :
>> #include "test_char.h" not found. Copied the generated
>> server/test_char.h to /include, mod_cache builds then, is that ok ?
>> Yes to get it to build for now. We may just need to change the
>> location it's generated to, or just point to it's location in the
>> build. If it's not a public header then we do the second option. I'll
>> look at that.
>
>>
>> htdbm and htpasswd :
>> support\passwd_common.h(31,10): fatal error C1083: Cannot open include
>> file: 'ap_config_auto.h': No such file or directory.
>> This gives me a deja vu feeling with what stopped mod_ssl from
>> building in 2.4.42. The winbuilds dsp/mak files generate headers by
>> copying a .h.in file of the same name like ap_config_layout.h.in. This
>> deja vu feeling tells me just feeding it an empty ap_config_auto.h
>> will not do.
> It might build at least and seem to work but wouldn't be correct.
> Yann? :)
>
>>
>> mod_ssl :
>> ssl_engine_io.obj : error LNK2019: unresolved external symbol
>> _ap_filter_adopt_brigade referenced in function _char_buffer_insert
>> AFAIK all ap_* functions are in libhttpd, maybe we're not
>> compiling/linking a new file. It looks to be in util_filters.c and
>> that shows as being compiled/linked to libhttpd. ???Huh???
>
>>
>> Looks like all the errors are related to changes in/after 2018. In
>> 2018 I build it without errors.
>> Did not build all yet and only Win32 VS16, so maybe more to come.
> Let's get it building on one version first, worry about any nuances in
> the various VC versions second.
>
>
> Gregg
Re: Trunk errors [ In reply to ]
On Sat, May 9, 2020 at 1:10 AM Gregg Smith <gls@gknw.net> wrote:
>
> > htdbm and htpasswd :
> > support\passwd_common.h(31,10): fatal error C1083: Cannot open include
> > file: 'ap_config_auto.h': No such file or directory.
> >
> This gives me a deja vu feeling with what stopped mod_ssl from building
> in 2.4.42. The winbuilds dsp/mak files generate headers by copying a
> .h.in file of the same name like ap_config_layout.h.in. This deja vu
> feeling tells me just feeding it an empty ap_config_auto.h will not do.
> It might build at least and seem to work but wouldn't be correct.
> Yann? :)

I think we should not #include ap_config_auto.h directly, but
ap_config.h instead (which has the necessary #ifnot WINW32..).

So how about the attached patch?

Regards,
Yann.
Re: Trunk errors [ In reply to ]
Patch gives errors, but was given me the direction, Thanks!

htdbm and htpasswd got it running !!


by adding in support/passwd_common.h :


#if !defined(WIN32) && !defined(NETWARE)
#include "ap_config_auto.h"
#endif

Your patch not used it is giving other errors, for example ab is not
building, get
ab.obj : error LNK2001: unresolved external symbol
__imp__ap_real_exit_code


So left issues :

mod_ssl :
ssl\ssl_engine_io.c(33,10): fatal error C1083: Cannot open include
file: 'core.h'
When I copy server/core.h to mod_ssl dir, then error:
ssl_engine_io.obj : error LNK2019: unresolved external symbol
_ap_filter_adopt_brigade referenced in function _char_buffer_insert
Tried also link with libhttpd.lib, no go.

And the ones with Greggs answer.

>
> Tried revision 1877505.
> libhttpd :
> miss in trunk modules\http\http_etag.c. Moved the one from Branches to
> include, libhttpd builds then, is that ok ?
Gregg: Yes to get it to build for now. Question is why isn't it in
trunk, modules/http like it is in branches or anywhere (quick look and
I can't see it).

>
> mod_cache :
> #include "test_char.h" not found. Copied the generated
> server/test_char.h to /include, mod_cache builds then, is that ok ?
Gregg: Yes to get it to build for now. We may just need to change the
location it's generated to, or just point to it's location in the
build. If it's not a public header then we do the second option. I'll
look at that.


Steffen, trying to be a human Travis :)





On Saturday 09/05/2020 at 14:59, Yann Ylavic wrote:
> On Sat, May 9, 2020 at 1:10 AM Gregg Smith <gls@gknw.net> wrote:
>>
>>
>>>
>>> htdbm and htpasswd :
>>> support\passwd_common.h(31,10): fatal error C1083: Cannot open include
>>> file: 'ap_config_auto.h': No such file or directory.
>>>
>> This gives me a deja vu feeling with what stopped mod_ssl from
>> building
>> in 2.4.42. The winbuilds dsp/mak files generate headers by copying a
>> .h.in file of the same name like ap_config_layout.h.in. This deja vu
>> feeling tells me just feeding it an empty ap_config_auto.h will not
>> do.
>> It might build at least and seem to work but wouldn't be correct.
>> Yann? :)
>
> I think we should not #include ap_config_auto.h directly, but
> ap_config.h instead (which has the necessary #ifnot WINW32..).
>
> So how about the attached patch?
>
> Regards,
> Yann.
>
Re: Trunk errors [ In reply to ]
On Sat, May 9, 2020 at 5:30 PM Steffen <info@apachelounge.com> wrote:
>
> Patch gives errors, but was given me the direction, Thanks!
>
> htdbm and htpasswd got it running !!
>
>
> by adding in support/passwd_common.h :
>
> #if !defined(WIN32) && !defined(NETWARE)
> #include "ap_config_auto.h"
> #endif
>
> Your patch not used it is giving other errors, for example ab is not building, get
> ab.obj : error LNK2001: unresolved external symbol __imp__ap_real_exit_code

OK, fair enough.

>
> mod_ssl :
> ssl\ssl_engine_io.c(33,10): fatal error C1083: Cannot open include file: 'core.h'
> When I copy server/core.h to mod_ssl dir, then error: ssl_engine_io.obj : error LNK2019: unresolved external symbol _ap_filter_adopt_brigade referenced in function _char_buffer_insert

So on Windows ap_filter_adopt_brigade() needs to be exported to be
used by modules, oh well.
How about the attached patch then?


Regards,
Yann.
Re: Trunk errors [ In reply to ]
Errors,

what I did: copied server/core.h to /include


Get:


C:\VC16\Win32\httpd-trunk\include\core.h(44,6): error C2373:
'ap_filter_adopt_brigade': redefinition; different type modifiers
C:\VC16\Win32\httpd-trunk\include\util_filter.h(631): message : see
declaration of 'ap_filter_adopt_brigade'




On Sunday 10/05/2020 at 12:10, Yann Ylavic wrote:
> On Sat, May 9, 2020 at 5:30 PM Steffen <info@apachelounge.com> wrote:
>>
>>
>> Patch gives errors, but was given me the direction, Thanks!
>>
>> htdbm and htpasswd got it running !!
>>
>>
>> by adding in support/passwd_common.h :
>>
>> #if !defined(WIN32) && !defined(NETWARE)
>> #include "ap_config_auto.h"
>> #endif
>>
>> Your patch not used it is giving other errors, for example ab is not
>> building, get
>> ab.obj : error LNK2001: unresolved external symbol
>> __imp__ap_real_exit_code
>
> OK, fair enough.
>
>>
>>
>> mod_ssl :
>> ssl\ssl_engine_io.c(33,10): fatal error C1083: Cannot open include
>> file: 'core.h'
>> When I copy server/core.h to mod_ssl dir, then error:
>> ssl_engine_io.obj : error LNK2019: unresolved external symbol
>> _ap_filter_adopt_brigade referenced in function _char_buffer_insert
>
> So on Windows ap_filter_adopt_brigade() needs to be exported to be
> used by modules, oh well.
> How about the attached patch then?
>
>
> Regards,
> Yann.
>
Re: Trunk errors [ In reply to ]
On Sun, May 10, 2020 at 1:30 PM Steffen <info@apachelounge.com> wrote:
>
> Errors,
>
> what I did: copied server/core.h to /include

You don't need this, my patch missed removing #include "core.h" from
"modules/ssl/ssl_engine_io.c", just do that.

Cheers,
Yann.
Re: Trunk errors [ In reply to ]
On Sun, May 10, 2020 at 2:16 PM Yann Ylavic <ylavic.dev@gmail.com> wrote:
>
> On Sun, May 10, 2020 at 1:30 PM Steffen <info@apachelounge.com> wrote:
> >
> > Errors,
> >
> > what I did: copied server/core.h to /include
>
> You don't need this, my patch missed removing #include "core.h" from
> "modules/ssl/ssl_engine_io.c", just do that.

And probably from "server/util_filter.c" too, full patched attached.

>
> Cheers,
> Yann.
Re: Trunk errors [ In reply to ]
Builds now, Thanks!



On Sunday 10/05/2020 at 14:17, Yann Ylavic wrote:
> On Sun, May 10, 2020 at 1:30 PM Steffen <info@apachelounge.com> wrote:
>>
>>
>> Errors,
>>
>> what I did: copied server/core.h to /include
>
> You don't need this, my patch missed removing #include "core.h" from
> "modules/ssl/ssl_engine_io.c", just do that.
>
> Cheers,
> Yann.
Re: Trunk errors [ In reply to ]
On Sun, May 10, 2020 at 2:28 PM Steffen <info@apachelounge.com> wrote:
>
> Builds now, Thanks!

Thanks for testing, committed in r1877548.
Re: Trunk errors [ In reply to ]
Running trunk : cannot start.

First with generated httpd conf:


[ssl:warn] [pid 1836:tid 636] AH10235: SSLRandomSeed is deprecated and
has no effect with OpenSSL 1.1.1 and later
[ssl:warn] [pid 1836:tid 636] AH10235: SSLRandomSeed is deprecated and
has no effect with OpenSSL 1.1.1 and later

Then I commented out :
#SSLRandomSeed startup builtin
#SSLRandomSeed connect builtin

Then it did not start:


[core:error] [pid 2796:tid 864] (70023)This function has not been
implemented on this platform: AH10231: httpd: Failed creating pid file
C:/Apache2x/logs/httpd.pid.EnERCx

Here more work to be done after this VS16 Win64 is tested : VS16
Win64, VC15 Win32/Win64, VC14 Win32/64 and re-build all the
third-party modules. And test Win7/10 - Server 2016/2019

Left building issues, with comments from Gregg:

>
> Tried revision 1877505.
> libhttpd :
> miss in trunk modules\http\http_etag.c. Moved the one from Branches to
> include, libhttpd builds then, is that ok ?
Gregg: Yes to get it to build for now. Question is why isn't it in
trunk, modules/http like it is in branches or anywhere (quick look and
I can't see it).

>
> mod_cache :
> #include "test_char.h" not found. Copied the generated
> server/test_char.h to /include, mod_cache builds then, is that ok ?
Gregg: Yes to get it to build for now. We may just need to change the
location it's generated to, or just point to it's location in the
build. If it's not a public header then we do the second option. I'll
look at that.


Steffen



On Sunday 10/05/2020 at 14:36, Yann Ylavic wrote:
> On Sun, May 10, 2020 at 2:28 PM Steffen <info@apachelounge.com> wrote:
>>
>>
>> Builds now, Thanks!
>
> Thanks for testing, committed in r1877548.
Re: Trunk errors [ In reply to ]
I open a new thread, the build errors reported here are solved.

Steffen


On Sunday 10/05/2020 at 15:41, Steffen wrote:
>
>
>
> Running trunk : cannot start.
>
> First with generated httpd conf:
>
>
> [ssl:warn] [pid 1836:tid 636] AH10235: SSLRandomSeed is deprecated and
> has no effect with OpenSSL 1.1.1 and later
> [ssl:warn] [pid 1836:tid 636] AH10235: SSLRandomSeed is deprecated and
> has no effect with OpenSSL 1.1.1 and later
>
> Then I commented out :
> #SSLRandomSeed startup builtin
> #SSLRandomSeed connect builtin
>
> Then it did not start:
>
>
> [core:error] [pid 2796:tid 864] (70023)This function has not been
> implemented on this platform: AH10231: httpd: Failed creating pid file
> C:/Apache2x/logs/httpd.pid.EnERCx
>
> Here more work to be done after this VS16 Win64 is tested : VS16
> Win64, VC15 Win32/Win64, VC14 Win32/64 and re-build all the
> third-party modules. And test Win7/10 - Server 2016/2019
>
> Left building issues, with comments from Gregg:
>
>>
>> Tried revision 1877505.
>> libhttpd :
>> miss in trunk modules\http\http_etag.c. Moved the one from Branches to
>> include, libhttpd builds then, is that ok ?
> Gregg: Yes to get it to build for now. Question is why isn't it in
> trunk, modules/http like it is in branches or anywhere (quick look and
> I can't see it).
>
>>
>> mod_cache :
>> #include "test_char.h" not found. Copied the generated
>> server/test_char.h to /include, mod_cache builds then, is that ok ?
> Gregg: Yes to get it to build for now. We may just need to change the
> location it's generated to, or just point to it's location in the
> build. If it's not a public header then we do the second option. I'll
> look at that.
>
>
> Steffen
>
>
>
> On Sunday 10/05/2020 at 14:36, Yann Ylavic wrote:
>> On Sun, May 10, 2020 at 2:28 PM Steffen <info@apachelounge.com> wrote:
>>>
>>>
>>> Builds now, Thanks!
>>
>> Thanks for testing, committed in r1877548.
>