Mailing List Archive

svn commit: r1908691 - in /httpd/httpd/trunk: changes-entries/http2_pr66539.txt modules/http2/h2_request.c
Author: icing
Date: Fri Mar 24 16:16:29 2023
New Revision: 1908691

URL: http://svn.apache.org/viewvc?rev=1908691&view=rev
Log:
*) mod_http2: fixed a crash during connection termination. See PR 66539.


Added:
httpd/httpd/trunk/changes-entries/http2_pr66539.txt
Modified:
httpd/httpd/trunk/modules/http2/h2_request.c

Added: httpd/httpd/trunk/changes-entries/http2_pr66539.txt
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/changes-entries/http2_pr66539.txt?rev=1908691&view=auto
==============================================================================
--- httpd/httpd/trunk/changes-entries/http2_pr66539.txt (added)
+++ httpd/httpd/trunk/changes-entries/http2_pr66539.txt Fri Mar 24 16:16:29 2023
@@ -0,0 +1,2 @@
+ *) mod_http2: fixed a crash during connection termination. See PR 66539.
+ [Stefan Eissing]

Modified: httpd/httpd/trunk/modules/http2/h2_request.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/h2_request.c?rev=1908691&r1=1908690&r2=1908691&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/http2/h2_request.c (original)
+++ httpd/httpd/trunk/modules/http2/h2_request.c Fri Mar 24 16:16:29 2023
@@ -279,7 +279,7 @@ static request_rec *my_ap_create_request
apr_bucket *h2_request_create_bucket(const h2_request *req, request_rec *r)
{
conn_rec *c = r->connection;
- apr_table_t *headers = apr_table_copy(r->pool, req->headers);
+ apr_table_t *headers = apr_table_clone(r->pool, req->headers);
const char *uri = req->path;

AP_DEBUG_ASSERT(req->authority);
@@ -303,7 +303,7 @@ static void assign_headers(request_rec *
{
const char *cl;

- r->headers_in = apr_table_copy(r->pool, req->headers);
+ r->headers_in = apr_table_clone(r->pool, req->headers);
if (req->authority) {
/* for internal handling, we have to simulate that :authority
* came in as Host:, RFC 9113 ch. says that mismatches between