Mailing List Archive

[Bug 63893] Bogus warning "unsupported command 20"
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893

--- Comment #7 from Avinash S <avinashsnie@gmail.com> ---
This looks to be not working still.
Since, we are checking for
if (!conn_config->client_addr) {
ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, r, APLOGNO(03496)
"RemoteIPProxyProtocol data is missing, but required!
Aborting request.");
return HTTP_BAD_REQUEST;
}

We still return 400 Bad requests.
We may need to do something like below under switch statement
case 0x00: /* LOCAL command */
case 0x01: /* PROXY command */
switch (hdr->v2.fam) {
case 0x11: /* TCPv4 */
ret = apr_sockaddr_info_get(&conn_conf->client_addr, NULL,
APR_INET,

ntohs(hdr->v2.addr.ip4.src_port),
0, c->pool

And go ahead parsing client info even for LOCAL and so that
conn_config->client_addr is populated.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20" [ In reply to ]
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893

Avinash S <avinashsnie@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REOPENED

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20" [ In reply to ]
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893

--- Comment #8 from Avinash S <avinashsnie@gmail.com> ---
Btw, I was developing proxy protocol for my company and found across this issue
still.

is the above mentioned fix is fine ?

what's your opinion ?

Thanks,
Avinash

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20" [ In reply to ]
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893

--- Comment #9 from Joe Orton <jorton@redhat.com> ---
Created attachment 37712
--> https://bz.apache.org/bugzilla/attachment.cgi?id=37712&action=edit
don't log 400 for LOCAL PROXY connections

Can you try this patch? We really need a test suite for this stuff. :(

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20" [ In reply to ]
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893

--- Comment #10 from Avinash S <avinashsnie@gmail.com> ---
Hi Joe,
This patch is working fine.

Hi Joe, would like to contribute in bug fixes/new features.
Could you please help me in providing details on process for the same.

Thanks,
Avinash

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 63893] Bogus warning "unsupported command 20" [ In reply to ]
https://bz.apache.org/bugzilla/show_bug.cgi?id=63893

--- Comment #11 from Yann Ylavic <ylavic.dev@gmail.com> ---
(In reply to Avinash S from comment #10)
> would like to contribute in bug fixes/new features.
> Could you please help me in providing details on process for the same.

Thanks for proposing!

The best way to contribute is to propose the patch(es) and rationale on the
dev@httpd.apache.org mailing list, or for existing bugzilla tickets simply
attach the proposed fix there.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org