Mailing List Archive

https://bz.apache.org/bugzilla/show_bug.cgi?id=64665

Bug ID: 64665
Summary: Inconsistent error handling when file cannot be opened
Product: Apache httpd-2
Version: 2.5-HEAD
Hardware: PC
OS: Linux
Status: NEW
Severity: major
Priority: P2
Component: Core
Assignee: bugs@httpd.apache.org
Reporter: legendt@foxmail.com
Target Milestone: ---

server/log.c:351, function open_error_log()

```
if ((rc = apr_file_open(&s->error_log, fname,
APR_APPEND | APR_WRITE | APR_CREATE |
APR_LARGEFILE,
APR_OS_DEFAULT, p)) != APR_SUCCESS) {
ap_log_error(APLOG_MARK, APLOG_STARTUP, rc, ap_server_conf,
APLOGNO(00091)
"%s: could not open error log file %s.",
ap_server_argv0, fname);
return DONE; // from APR_INCOMPLETE, cannot open -> DONE
}
```

modules/loggers/mod_log_config.c:1889, function check_log_dir()

```
apr_status_t rv = apr_stat(&finfo, dir, APR_FINFO_TYPE, p);
cls->directive = NULL; /* Don't check this config_log_state again */
if (rv == APR_SUCCESS && finfo.filetype != APR_DIR)
rv = APR_ENOTDIR;
if (rv != APR_SUCCESS) {
ap_log_error(APLOG_MARK, APLOG_STARTUP|APLOG_EMERG, rv, s,
APLOGNO(02297)
"Cannot access directory '%s' for log file '%s' "
"defined at %s:%d", dir, cls->fname,
directive->filename, directive->line_num);
return !OK; // from APR_INCOMPLETE, cannot open -> !OK
}
```

Both errors can be seemed as file cannot be opened, but the handling is totally
different. I believe the same errors should be handled in the same way.

--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org